Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <55bc0656a841cc1229d2b1594d4f9eeabfd00ae5.camel@kernel.org>
Subject: Re: [PATCH v3 0/7] Wait for DELEGRETURN before returning
 NFS4ERR_DELAY
From:   Jeff Layton <jlayton@kernel.org>
To:     Chuck Lever <chuck.lever@oracle.com>, linux-nfs@vger.kernel.org
Date:   Mon, 08 Aug 2022 14:48:28 -0400
In-Reply-To: <165996657035.2637.4745479232455341597.stgit@manet.1015granger.net>
References: <165996657035.2637.4745479232455341597.stgit@manet.1015granger.net>
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.3 (3.44.3-1.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Mon, 2022-08-08 at 09:52 -0400, Chuck Lever wrote:
> This RFC series adds logic to the Linux NFS server to make it wait a
> few moments for clients to return a delegation before replying with
> NFS4ERR_DELAY. There are two main benefits:
>=20
> - This improves responsiveness when a delegated file is accessed
>  from another client
> - This removes an unnecessary latency if a client has neglected to
>  return a delegation before attempting a RENAME or SETATTR
>=20
> This series is incomplete:
> - There are likely other operations that can benefit (eg. OPEN)
>=20
> This series applies against v5.19.
>=20
> Changes since v2:
> - Wake immediately after client sends DELEGRETURN
> - More tracepoint improvements
>=20
> Changes since RFC:
> - Eliminate spurious console messages on the server
> - Wait for DELEGRETURN for RENAME operations
    ^^^^
Does REMOVE need similar treatment? Does the Apple client return a
delegation before attempting to unlink?

> - Add CB done tracepoints
> - Rework the retry loop
>=20
> ---
>=20
> Chuck Lever (7):
>       NFSD: Instrument fh_verify()
>       NFSD: Replace dprintk() call site in fh_verify()
>       NFSD: Trace NFSv4 COMPOUND tags
>       NFSD: Add tracepoints to report NFSv4 callback completions
>       NFSD: Add a mechanism to wait for a DELEGRETURN
>       NFSD: Make nfsd4_setattr() wait before returning NFS4ERR_DELAY
>       NFSD: Make nfsd4_rename() wait before returning NFS4ERR_DELAY
>=20
>=20
>  fs/nfsd/nfs4layouts.c |   2 +-
>  fs/nfsd/nfs4proc.c    |  56 +++++++++++---
>  fs/nfsd/nfs4state.c   |  35 +++++++++
>  fs/nfsd/nfsd.h        |   1 +
>  fs/nfsd/nfsfh.c       |  13 +---
>  fs/nfsd/trace.h       | 171 ++++++++++++++++++++++++++++++++++++++++--
>  fs/nfsd/xdr4.h        |   2 +
>  7 files changed, 251 insertions(+), 29 deletions(-)
>=20
> --
> Chuck Lever
>=20

The new tracepoints are nice and the patchset makes sense. You can add:

Reviewed-by: Jeff Layton <jlayton@kernel.org>