Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <07d99979-a395-64a9-f051-e400bfefe1ca@benettiengineering.com>
Date:   Wed, 10 Aug 2022 23:43:43 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.1.0
Subject: Re: [PATCH v2] nfsrahead: fix linking while static linking
Content-Language: en-US
To:     linux-nfs@vger.kernel.org
References: <20220809221252.772891-1-giulio.benetti@benettiengineering.com>
 <20220809223308.1421081-1-giulio.benetti@benettiengineering.com>
From:   Giulio Benetti <giulio.benetti@benettiengineering.com>
In-Reply-To: <20220809223308.1421081-1-giulio.benetti@benettiengineering.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi All,

please drop this patch in favor of upcoming V3. This is not a good way
to use pkg-config with Autotools.

Sorry for the noise

Best regards
-- 
Giulio Benetti
Benetti Engineering sas

On 10/08/22 00:33, Giulio Benetti wrote:
> -lmount must preceed -lblkid and to obtain this let's add:
> `pkg-config --libs mount`
> in place of:
> `-lmount`
> This ways the library order will always be correct.
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> V1->V2:
> * modify pkg-conf to pkg-config
> ---
>   tools/nfsrahead/Makefile.am | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/nfsrahead/Makefile.am b/tools/nfsrahead/Makefile.am
> index 845ea0d5..280a2eb4 100644
> --- a/tools/nfsrahead/Makefile.am
> +++ b/tools/nfsrahead/Makefile.am
> @@ -1,6 +1,6 @@
>   libexec_PROGRAMS = nfsrahead
>   nfsrahead_SOURCES = main.c
> -nfsrahead_LDFLAGS= -lmount
> +nfsrahead_LDFLAGS= `pkg-config --libs mount`
>   nfsrahead_LDADD = ../../support/nfs/libnfsconf.la
>   
>   man5_MANS = nfsrahead.man