Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <debe59b1-35cc-c3b0-f3ca-76d6a56b826b@oracle.com>
Date:   Fri, 19 Aug 2022 08:42:10 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.12.0
Subject: Re: [RFC] problems with alloc_file_pseudo() use in __nfs42_ssc_open()
Content-Language: en-US
To:     Olga Kornievskaia <aglo@umich.edu>
Cc:     Al Viro <viro@zeniv.linux.org.uk>,
        Amir Goldstein <amir73il@gmail.com>,
        linux-nfs <linux-nfs@vger.kernel.org>,
        Olga Kornievskaia <kolga@netapp.com>,
        linux-fsdevel <linux-fsdevel@vger.kernel.org>
References: <Yv1jwsHVWI+lguAT@ZenIV>
 <CAN-5tyFvV7QOxyAQXu3UM5swQVB2roDpQ5CBRVc64Epp1gj9hg@mail.gmail.com>
 <Yv2BVKuzZdMDY2Td@ZenIV>
 <CAN-5tyF0ZMX8a6M6Qbbco3EmOzwVnnGZmqak8=t4Cvtzc45g7Q@mail.gmail.com>
 <CAOQ4uxgA8jD6KnbuHDevNLsjD-LbEs_y1W6uYMEY6EG_es0o+Q@mail.gmail.com>
 <Yv3Ti/niVd5ZVPP+@ZenIV>
 <CAN-5tyHpDHzmo-rSw1X+0oX0xbxR+x13eP57osB0qhFLKbXzVA@mail.gmail.com>
 <b7a77d4f-32de-af24-ed5c-8a3e49947c5a@oracle.com>
 <CAN-5tyH6=GD_A48PEu0oWZYix4g0=+0FwVgE262Ek0U1qNiwvA@mail.gmail.com>
From:   dai.ngo@oracle.com
In-Reply-To: <CAN-5tyH6=GD_A48PEu0oWZYix4g0=+0FwVgE262Ek0U1qNiwvA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RVpyR2tiZUZNK29LVW1lVG5yU2Nubk5DSzJQQmhNSHRXQjhEQVBmSy9UdFhO?=
 =?utf-8?B?L1QyL1U1bjMvUWc3SFJVRk5QK3RtVW4xMUlOYm5maUNPU3ZzRnFyY1A4OUJl?=
 =?utf-8?B?Z1kzVzVhRVpSK2ZJZk5BcXc0cVVaSDJWcFRMM3IzbEhQbTJEeWtzb3BrWFdh?=
 =?utf-8?B?QS9mOFptaGtNNWw5NlpCekNkR1FGTWRmcFJiL2dQWGs4QkNUNUFnbGdRalYw?=
 =?utf-8?B?WWp1aW5xdFlOKzhhdzlORFBMZE4vamJmU3AyYUpPZGF1WFJOVVd5cjRJWk1H?=
 =?utf-8?B?KysySnhMdUhFamZOSVpKbmdMYTBzdW80ZFp0UUtabDRzVU1LU0pRZFRpN0xi?=
 =?utf-8?B?NGYyZ2Z6VDkyTTFicWEzZmpoaUlzUlNLRnVRRDNKaDdYSDB4RXMyWnNMZHBw?=
 =?utf-8?B?VExYS3U1YW5xYkY2Wmc0bS9KVjBqSmN1S3hpdDVzRkhjZm02SnpqWDVlUTlh?=
 =?utf-8?B?NVJaVWlwazNLZEdITXFCT1FiNmRhaW9iUDRDZmpjZU9CZGFjUFVVSWdYWVNy?=
 =?utf-8?B?aTYybngxWFYxK243ZGtvcGpxNUpHYWJTVmxEeTBEZjIrakloWWtmaE9WU1cx?=
 =?utf-8?B?QXVkMFhod0NiTk5EQURMdm9XTkZiSWdGOVdSZGFvYXFIdFo3UlZaMGhBdnh5?=
 =?utf-8?B?YnhadGYxQm9YMVkrSXVieCtzTlpuYy9ueXdKZnhuQzkwdEdodHFHbTFtYUJG?=
 =?utf-8?B?QWNaVW4zWjU5RkZjNUtHMmJiV1RHZkxBbEMxeUh3QnN2QUdlNFFQUjNJQngz?=
 =?utf-8?B?ZmwvVnBFbi8veERVT3dSaVcwM1pzYzJoM1JtbkdmNHdlV0JJYlhPbkZrZUs1?=
 =?utf-8?B?amtJZitEMzg5Y2VNWHVuN2NxUCtnaG45Ri9jS1RJTjJranBBYm1jSkY5NTlJ?=
 =?utf-8?B?N1NHZDh4U2Nja3A5cUxrSG9obWRPbHJkRStQdzhkNTlueUxxSnJPNlo3YzR6?=
 =?utf-8?B?REJjbzYxZmZBVVJ6SzBDT0YwdHZJQllOdUN4K2J6ZWgvT1ZxU1pHbXBvMDlz?=
 =?utf-8?B?RmgzUEhFaWhDWnVNRXkrblpTcVdqOG9BdExxaVdBLzZWaFg1ajA0eDlNbjdZ?=
 =?utf-8?B?UVlPZXpkUnJiOVBSWTRDdlZXU2phTmpUWjNITElvNnNRWlE5YnRUNExZcm44?=
 =?utf-8?B?K3pjN1JFRzdZZmUyZ2VVUG1Idm83M3ZnWlo5b3FmWUlFdzR0b1llTEFaNldH?=
 =?utf-8?B?WnM5akMxdDd2UG81VDBoWVNwWm1VSWFPMUJUVGRvbkZKMkFDYTlaYVMxNzhr?=
 =?utf-8?B?SmcrYnRGQ3MyT0ZUZk14b1BVMW4waWlnQUdDMXl1U0lIRUZmRXVoSWg5RC9P?=
 =?utf-8?B?ZlM2cDlYc1N5czdsZkNxZ2JWZi9lOU5sUVQ4NHBqMWgxR0J0WDk4MnNHayt2?=
 =?utf-8?B?ajU5NllXeHFwUnRlMy9VOVlhS1ZUaCtpMHhsYUErTUtXeWdXK3hMcXIxbDBL?=
 =?utf-8?B?MVNGMzk0Yy9QVVpWNlJrelRuT3RWejgwMTZzWktxTVQ5YkUyM0xTWW4vMmdm?=
 =?utf-8?B?RWY4bWFSYXBWemxQWWtjRm5xcytxN09vSW9JdDVROGhaY29TMUIzYWpVc0xN?=
 =?utf-8?B?WXZYbFZzZEVCa0ZPVVRsZlUyZzBRRlNwWDR2QTlsR0NrU1lGcENqcDVQc3ox?=
 =?utf-8?B?YVV2ait6N2ViNmZjVnpCa0dVOU1xdnNVZ3hqUk02ZmlGZ1ZNQVlqNGJqdmdj?=
 =?utf-8?B?RWY0OThhL3c0Q3NscldNbUxCYXpRNGRPMS8yUzRua25hQk42c3YzUzk5Ly9T?=
 =?utf-8?B?L0Z2UFltZkV5bUNvN2JuSWlaUjU3WFc4dUIyTFc3ZVpseWpYNkVYR0R0MEpJ?=
 =?utf-8?B?L011SWp0bmxPK2lnc1BISVhMVDBVb3lpdGtRMEkrWGZudUt5Tm5uRm1KbUZX?=
 =?utf-8?B?NDVqYkhYSUZwaXEzcFlKeUtvK2p0RktQb08rL1pBeVJ1UzhXRDNmY0JFRWVY?=
 =?utf-8?B?NVFveTRlMmgrQzJNVUdLaUFwSkFqdjY5ZmxEazNMN29Qd3BwdEo1WEZnajRR?=
 =?utf-8?B?QzJTTzMzcnkxSEZZMDlzQzNJL0Y2OWJHdDZQMlN1R3ZlMUdjbkhNWExFSk9a?=
 =?utf-8?B?VFdSckpFRnYwZnV3WnhOcGh1WnpyTU1jNlF1aTU1Snp3YlRKSjJidjNYT3cy?=
 =?utf-8?Q?LDUt4o+79z8xlc53x8A9ThXlX?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?T2UwNkdGKzF5dUNzZ3RXV2swekxDcWkrZXpTbXVJM0Z5ZFhiaG1zeTlvUk0y?=
 =?utf-8?B?a2cyUThGSE1tMStDZUdKTkZwQjlUWGdKRjd5VXFRSy9FeTcxWmw3emxQdndR?=
 =?utf-8?B?NEROWUdRRkFRVUxna3JSUGpNajdQdE5JUVdRdGNJTStvRVJqcmNnOEs0S1R2?=
 =?utf-8?B?R21aeVU1SnVDZklvOWwzc1krcm9oSFg4UzdmLzBta2tFRG1DalExMmdZUVNV?=
 =?utf-8?B?Q0d6eWpzTWVvK00rTXdQcGlYbmNQb2dFWE9rTElLcHBBSEswcHoxcDdCTUV1?=
 =?utf-8?B?cUJ6Sjl6ZjZKNWJYdXJzaDNqbGJ5dWdDeTF2bGcwUjNlMFpReWdWUzFLcTNm?=
 =?utf-8?B?VkIrTXUwUWhRRHVHaHMyNUJMeHR1RHFBYWJ5RTFKWmdiQWJSd0pPLzA1VUFs?=
 =?utf-8?B?RjFVU0NtSVhCeVowWStFajZ6VnZQYVRMYVVJa0M3Yzd2QTBxM0I0SWh5Ri9E?=
 =?utf-8?B?WTRFemZUS0NzeVVCL1N4YkEvWnhOL0tNeXROV0w1aXpTUFA3eXV0bWxQb1Bv?=
 =?utf-8?B?SGFFZG1CTWlQL25STGNOTDY1b01keXNVM1F2ZlU3VEg1RVBRZ2lOL0Z4dUl5?=
 =?utf-8?B?ZG1ndWNCekJmZHZhZE8reWhlUEs0QUNFUWJyS2Q4bUxaY2l0OTZJL2pxMnV4?=
 =?utf-8?B?SFY2VEE5ZUlVVDQySDJqSzd2cHA0eDZxa1V3TDczYi9zNktYdE4xVzN4bWdy?=
 =?utf-8?B?blFrVXVJT0YrMVRtOVdPUVRXWHhHVUVJTEUzaHh0WkZROU9qRyt0Wmsxb0p4?=
 =?utf-8?B?QjArMGg3Y3owTXFTeVlhR0JtTEwxOFJCeDJ0ekVjZTRwVENLQlVYeTJjYVdo?=
 =?utf-8?B?b29ZWFJ3ck8xU2JFRno5aC9FRHFacjBwZGJ2bHZobUZGa09jMGgrUjV0QlZG?=
 =?utf-8?B?bWY0WUoyWHJEM1FteVlXWmNsbVdyejdic3A3TGxja29XRWVIL3pDN2dNM05u?=
 =?utf-8?B?dGdPTTlGU2h5ejZuV0k2SHdINWtYK1pFMDJqekRJZ3hqQU5Vd09UOHR6T2Fv?=
 =?utf-8?B?NjE0aUxpTThEcHJnVFQwWFc4MEJFb2dQSDEzUDI3VXN4MU03U2JsczV2N2Fl?=
 =?utf-8?B?MXlqZE16VXdqTGRwS2NBMmhGb01iZnFrVGE3L0ZUNFVmcitkNHZEQXJGd2lP?=
 =?utf-8?B?MHZacXJWb2NOVWlDZGdnSmN3bjErdUxNWFJ6Ny9UZG8vZlpVRW9KZE9qQVlF?=
 =?utf-8?B?SlBsVXhqU05KZjZwaWoyZ3cwaldHSE1za2FJTlNEVUR5QnkwM0Fwd1BJUDRJ?=
 =?utf-8?B?bFZBZ2lmS0RIT2wxN1h4NXFvZkJRQml1SWFQUzJxMFBxWlU5aDB2eVlNd0RG?=
 =?utf-8?Q?yVKP4FvDrcHj0yVZocUexOAKSiUSVRrBnE?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bcbb4ccd-6ff8-4e8a-8a27-08da81f96676
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4257.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Aug 2022 15:42:19.3793
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 40gRhBHVqpHHLR0ttwOFSazD72BdYSd+0vP8i3w+am1e2t/4HHqlczcb2B+yAl/j2aGqdcw7O9COogPoRX4HpA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4772
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-19_08,2022-08-18_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 mlxscore=0
 adultscore=0 mlxlogscore=999 bulkscore=0 phishscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000
 definitions=main-2208190056
X-Proofpoint-GUID: YtB1jyEzQoqpGwVu5BrvzA5fGsnCbjgz
X-Proofpoint-ORIG-GUID: YtB1jyEzQoqpGwVu5BrvzA5fGsnCbjgz
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


On 8/19/22 7:22 AM, Olga Kornievskaia wrote:
> On Thu, Aug 18, 2022 at 10:52 PM <dai.ngo@oracle.com> wrote:
>>
>> On 8/18/22 6:13 AM, Olga Kornievskaia wrote:
>>> On Thu, Aug 18, 2022 at 1:52 AM Al Viro <viro@zeniv.linux.org.uk> wrote:
>>>> On Thu, Aug 18, 2022 at 08:19:54AM +0300, Amir Goldstein wrote:
>>>>
>>>>> NFS spec does not guarantee the safety of the server.
>>>>> It's like saying that the Law makes Crime impossible.
>>>>> The law needs to be enforced, so if server gets a request
>>>>> to COPY from/to an fhandle that resolves as a non-regular file
>>>>> (from a rogue or buggy NFS client) the server should return an
>>>>> error and not continue to alloc_file_pseudo().
>>>> FWIW, my preference would be to have alloc_file_pseudo() reject
>>>> directory inodes if it ever gets such.
>>>>
>>>> I'm still not sure that my (and yours, apparently) interpretation
>>>> of what Olga said is correct, though.
>>> Would it be appropriate to do the following then:
>>>
>>> diff --git a/fs/nfs/nfs4file.c b/fs/nfs/nfs4file.c
>>> index e88f6b18445e..112134b6438d 100644
>>> --- a/fs/nfs/nfs4file.c
>>> +++ b/fs/nfs/nfs4file.c
>>> @@ -340,6 +340,11 @@ static struct file *__nfs42_ssc_open(struct
>>> vfsmount *ss_mnt,
>>>                   goto out;
>>>           }
>>>
>>> +       if (S_ISDIR(fattr->mode)) {
>>> +               res = ERR_PTR(-EBADF);
>>> +               goto out;
>>> +       }
>>> +
>> Can we also enhance nfsd4_do_async_copy to check for
>> -EBADF and returns nfserr_wrong_type? perhaps adding
>> an error mapping function to handle other errors also.
> On the server side, if the open fails that's already translated into
> the appropriate error -- err_off_load_denied.

Currently the server returns nfserr_offload_denied if the open
fails for any reasons. I'm wondering whether the server should
return more accurate error code such as if the source file handle
is a wrong type then the server should return nfserr_wrong_type,
instead of nfserr_offload_denied, to match the spec:

    Both SAVED_FH and CURRENT_FH must be regular files.  If either
    SAVED_FH or CURRENT_FH is not a regular file, the operation MUST fail
    and return NFS4ERR_WRONG_TYPE.

-Dai

>
>> -Dai
>>
>>>           res = ERR_PTR(-ENOMEM);
>>>           len = strlen(SSC_READ_NAME_BODY) + 16;
>>>           read_name = kzalloc(len, GFP_KERNEL);
>>> @@ -357,6 +362,7 @@ static struct file *__nfs42_ssc_open(struct
>>> vfsmount *ss_mnt,
>>>                                        r_ino->i_fop);
>>>           if (IS_ERR(filep)) {
>>>                   res = ERR_CAST(filep);
>>> +               iput(r_ino);
>>>                   goto out_free_name;
>>>           }