Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp376004rwe; Wed, 24 Aug 2022 02:30:54 -0700 (PDT) X-Google-Smtp-Source: AA6agR4rr/M5hi6omIyk0FdqzekANEgrH/EC+fhHndL9NnitOoRkMHpu4qAI6UHXS3NBKK2vZn0f X-Received: by 2002:a05:6402:3214:b0:447:82cc:835 with SMTP id g20-20020a056402321400b0044782cc0835mr1526941eda.341.1661333453821; Wed, 24 Aug 2022 02:30:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661333453; cv=none; d=google.com; s=arc-20160816; b=zNy3Fxc8ZQgrnTGcqyaGvbiMtNJuJb0BnQMFYfJerVqHtY7QFiv/0TvhyGvnR/qLJ0 sLakd4AgdpPfCyVXjEQaeM/ml+9EamxkMEgYPUoS9/CyHuNlR3aAXbHJaLLkXiAP0dWI 6fkV5Gwg1LcmVt1A4a8lLlnAFl9j+AY+t2KMRv6wlpJkOH/FWlDRfRg4Wcbxd7qoZkQG ybyokYoI053podzGTCaTDKUu774ClcL9gauj8dySAewvmVCnwlAiPsth53JL7cqCJh8Y cSOz/gz4F5YMdd+xUylK0x1see0ROfU25eEfRHR5dPZM6cuek2W0b0a6A1hDypJSpN9R J5SQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=uNy5g62q4f3EfB4qc+LsCjFzKomFBcE/w1fy1NeXDz4=; b=TfKOy8mTLHh8F/KIapqB4OIRp+mKgf3sbT/uZ0jWtXuKbRdkjVHqxkIu4DAJ7ZcpGK kBhym4pwngT/zJV5DS2hGKTByOHswzwNr4Ik9MEK0VDWgXK2RaShL7xNELA0+28rALbD /i6TiHHym4bCOqbLf41V3ahOPuMCH/wGZZRYFIWbKVnHibM8RsHhCqmFr+pTgnDakGuy dt1EizvAerkmaUglrjBaTq97lRyv3lXpY/deo652mR2Ce11afl/FLYrEiBhDUgjKuBsf bNbxKkZRw1wx4CI2JTNnK6OzY3RV9fEL5MKUCptIg+R0uaJIuLkdIP19VbUMNBvrjVcy zmYQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oViOs84x; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lz4-20020a170906fb0400b0072aef2d3af1si1562457ejb.53.2022.08.24.02.29.49; Wed, 24 Aug 2022 02:30:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oViOs84x; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236247AbiHXJVC (ORCPT + 99 others); Wed, 24 Aug 2022 05:21:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43458 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235700AbiHXJVC (ORCPT ); Wed, 24 Aug 2022 05:21:02 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 53969832F7; Wed, 24 Aug 2022 02:21:01 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E27E4617E4; Wed, 24 Aug 2022 09:21:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C5138C433D6; Wed, 24 Aug 2022 09:20:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661332860; bh=aHssPV+PvZjgi8MDT5duCiMiIpJ6jhBj9xyXxHLUzok=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oViOs84xwCgHkMMjWBwXuyhM2PHi3AGoN+ld6xN6xhO9mFWy3Bc2Uig4xY8aGv7Lm j7vWnzOGmtaUYPT2p1zOzYWdT4QaMh4LlTP03Toqzftt7QykauJcCWSwGh4ev3qY5B D5gOQT3Li72E6iabkt9ppsTchjdJEnDJqZo1MM6c5pxxIv8LyT4algU2eQ1HnPi6/K 3lHkGpMrDV0fwjzdkJhdykuJ3/wJzn9eXAt+jtn+00n1t3a8W6RI4ribg7pqtku4FM fH4u44rFJlrz4rD7a/RD/dhLoMQ6PmouGfZzcpfsiXSnVsfTTxgXolmir4eF41TsJZ +drxOH8HV+chg== Date: Wed, 24 Aug 2022 12:20:56 +0300 From: Leon Romanovsky To: Chuck Lever III , Jason Gunthorpe Cc: Linux NFS Mailing List , "linux-rdma@vger.kernel.org" Subject: Re: [PATCH v1] RDMA/core: Fix check_flush_dependency splat on addr_wq Message-ID: References: <166118222093.3250511.11454048195824271658.stgit@morisot.1015granger.net> <584E7212-BC09-48E1-A27E-725E54FA075E@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <584E7212-BC09-48E1-A27E-725E54FA075E@oracle.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Tue, Aug 23, 2022 at 01:58:44PM +0000, Chuck Lever III wrote: > > > > On Aug 23, 2022, at 4:09 AM, Leon Romanovsky wrote: > > > > On Mon, Aug 22, 2022 at 11:30:20AM -0400, Chuck Lever wrote: <...> > >> The xprtiod work queue is WQ_MEM_RECLAIM, so any work queue that > >> one of its work items tries to cancel has to be WQ_MEM_RECLAIM to > >> prevent a priority inversion. > > > > But why do you have WQ_MEM_RECLAIM in xprtiod? > > Because RPC is under a filesystem (NFS). Therefore it has to handle > writeback demanded by direct reclaim. All of the storage ULPs have > this constraint, in fact. I don't know, this ib_addr workqueue is used when connection is created. Jason, what do you think? Thanks