Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     "trondmy@kernel.org" <trondmy@kernel.org>
CC:     Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] NFSv4: Turn off open-by-filehandle and NFS re-export for
 NFSv4.0
Thread-Topic: [PATCH] NFSv4: Turn off open-by-filehandle and NFS re-export for
 NFSv4.0
Thread-Index: AQHYuLXU4u2NltMva0KSnHRxawuveK2//jGA
Date:   Thu, 25 Aug 2022 19:21:00 +0000
Message-ID: <CCFDB682-99B1-42A1-BB2E-69D1459B320F@oracle.com>
References: <20220825190013.578922-1-trondmy@kernel.org>
In-Reply-To: <20220825190013.578922-1-trondmy@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?RENOfZVJ92RgpGILy3w/45nZviE/sRwFEneu7w+tg9ELiOgs9n9pQh9ItDoj?=
 =?us-ascii?Q?+StfKvPJthqTr2AWkLXDu8Nwva915dkgSXDQ35EZWje/RX8Ta3uRT9IoW9u+?=
 =?us-ascii?Q?0mxSnXhQgXECl9cmjmIwb74/yzcMfV8pcsYVheligedogWVQ/25PT73NFdXb?=
 =?us-ascii?Q?VcoicTT4XW21knNEaZ0Kov4VPzqsUptjUy7FsiDjGzzw/BkmQQW96ks1Z+is?=
 =?us-ascii?Q?PJz/V2o6wpVgpf88owXg/cMcNgNSmV9SKeEItBdO+2Om6rmR12pD7fwgPPQ0?=
 =?us-ascii?Q?qVAFG1Ox9PJNhYYK6thsgylWI7Pm+v0nhShJuhs7KTm97+5zg5ta9O1c9FN0?=
 =?us-ascii?Q?zu8yrFssBnPXbkbuJGJfyRTUnRN+PqynMnJYb5TzVnoxLlOtzk7udyyDgDf5?=
 =?us-ascii?Q?L7RdlYErOAxzwcLsNW9QwcO73AKgYm5ClImNftxO3M0uvo/7ooMk9YrqTR0y?=
 =?us-ascii?Q?a/rE9dvwI2Fahjg3W4NcDGCyOtSLdOxa8Oqsr7eLXGUhht9UBGyk/aozUwPL?=
 =?us-ascii?Q?gxvSuqZGG2k+jG8TzoTh+mY6nWWNbFJlEaVMNzl23dqHCaoMF8dwm6O7paSS?=
 =?us-ascii?Q?hUBrAS9sVRTpxZrUz54nzZ4X0TgMXuDMx3wuKDX1BtTbJrPilZQFLc7WusS+?=
 =?us-ascii?Q?8eGSuivfKj0q8Fj5NLXUtt9sXz42X+YrSyAtUREQJSVOwGGF1+6PWKZnhxKd?=
 =?us-ascii?Q?Ei+mB9SnFSTg9xZXx18+jC/w66RGLH5HE5rnln6ql+YBYyzBeE3KJ9QWvh23?=
 =?us-ascii?Q?lZRBZUkoWxzV6sR2M5jc1+alz6++AC+w97c5rLuA61SR6Vy0u9S4HtWcx2yo?=
 =?us-ascii?Q?vzYuJbmt52l8bL0zbO1/cSagiIAWjvGrutU6drURpraJF4gUYvg7EftL3QVu?=
 =?us-ascii?Q?EUOlAEzk+ASXYlZ2MN2ty82H+mxG5AM3j0QnjvWOMxL4JfUkEtmr42ebLhnD?=
 =?us-ascii?Q?cQxe8XmOVz+RKH1oVpUNbNYwbNPwONHJYqRtMETG1uUUCW4ewpgTsJiHXthu?=
 =?us-ascii?Q?0zxjzQ1bk5zzDKWRMvncofC1phiW5ESNeSzQ23gyb6rzsmXeYtGcodptB39R?=
 =?us-ascii?Q?3qBaSUWiH/P7DVHKa9FFZTaGSl7KGc3NURR0Mt4eO4sEgQ4nIf0frDCaD4QH?=
 =?us-ascii?Q?NuTxxBiImL+Otq9PrmEJwgWzpyiF/LKqRy03AHsA3RBKoE4PsGHiJuERQPMn?=
 =?us-ascii?Q?w4lEavIzSQ4uMCM7ilC8XdpoQ+wTJ8yDFvQwLSlhEN5XDNMgEkhZwS+efQfP?=
 =?us-ascii?Q?RECuUO80vkacj2f0/kA+v2/LgStUcVMTE9qUIYXAd+GGxdIv7xKfVYk5tjaQ?=
 =?us-ascii?Q?e5cMESVMs8BFXK0AEy3TXPejh/1mm79AlQ33ZGfPAkgO1AXzVjGZrKfvnT1B?=
 =?us-ascii?Q?rfglPOWtz6V/WjJ0NkjKOXbjo8UdD7d2dclEpANXbTqTMvmhJmn8b2wIyr0s?=
 =?us-ascii?Q?oT0CbMXma/M8jNBA10wJ/mEUJ0lrm9RidxuTWxS7KHiIfWnCjAHKQxLgXasn?=
 =?us-ascii?Q?pwPpHFs6qfmKV1I+hpb95eZkwaMtFUQlBEev1Ct9wqEs8T5RI50DNw+mt6SU?=
 =?us-ascii?Q?BpoxBZnxZP0fy1pjp1lRN53q9buO+xcsum4I4f1/r8IFqmSMoMbT6y6KMSw5?=
 =?us-ascii?Q?4g=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <F956F6F23E63C84C8EBD3196251ED5B0@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 72535b77-28c3-42e4-eacf-08da86cef1ed
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Aug 2022 19:21:00.6476
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: TIWRKBeSK6A6LgVpOfk65yDmRuhUrQhpxqpQ5MnLBWkW93YdycaTUuYQuWyH6RyLqq5FqgFBsrVtbsjdjqYyUw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3592
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-25_09,2022-08-25_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxscore=0 phishscore=0
 spamscore=0 malwarescore=0 mlxlogscore=999 suspectscore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000
 definitions=main-2208250074
X-Proofpoint-ORIG-GUID: udi5ykI_CDZWh2aL36xTXb48-LzXp7wL
X-Proofpoint-GUID: udi5ykI_CDZWh2aL36xTXb48-LzXp7wL
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Aug 25, 2022, at 3:00 PM, trondmy@kernel.org wrote:
>=20
> From: Trond Myklebust <trond.myklebust@hammerspace.com>
>=20
> The NFSv4.0 protocol only supports open() by name. It cannot therefore
> be used with open_by_handle() and friends, nor can it be re-exported by
> knfsd.
>=20
> Reported-by: Chuck Lever III <chuck.lever@oracle.com>
> Fixes: 20fa19027286 ("nfs: add export operations")
> Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>

No objection to this approach. You can run generic/426 as easily
as I can to test it...

Bonus points: the use of switch() here makes the code easier to
understand and modify.


> ---
> fs/nfs/super.c | 27 ++++++++++++++++++---------
> 1 file changed, 18 insertions(+), 9 deletions(-)
>=20
> diff --git a/fs/nfs/super.c b/fs/nfs/super.c
> index 6ab5eeb000dc..5e4bacb77bfc 100644
> --- a/fs/nfs/super.c
> +++ b/fs/nfs/super.c
> @@ -1051,22 +1051,31 @@ static void nfs_fill_super(struct super_block *sb=
, struct nfs_fs_context *ctx)
> 	if (ctx->bsize)
> 		sb->s_blocksize =3D nfs_block_size(ctx->bsize, &sb->s_blocksize_bits);
>=20
> -	if (server->nfs_client->rpc_ops->version !=3D 2) {
> -		/* The VFS shouldn't apply the umask to mode bits. We will do
> -		 * so ourselves when necessary.
> +	switch (server->nfs_client->rpc_ops->version) {
> +	case 2:
> +		sb->s_time_gran =3D 1000;
> +		sb->s_time_min =3D 0;
> +		sb->s_time_max =3D U32_MAX;
> +		break;
> +	case 3:
> +		/*
> +		 * The VFS shouldn't apply the umask to mode bits.
> +		 * We will do so ourselves when necessary.
> 		 */
> 		sb->s_flags |=3D SB_POSIXACL;
> 		sb->s_time_gran =3D 1;
> -		sb->s_export_op =3D &nfs_export_ops;
> -	} else
> -		sb->s_time_gran =3D 1000;
> -
> -	if (server->nfs_client->rpc_ops->version !=3D 4) {
> 		sb->s_time_min =3D 0;
> 		sb->s_time_max =3D U32_MAX;
> -	} else {
> +		sb->s_export_op =3D &nfs_export_ops;
> +		break;
> +	case 4:
> +		sb->s_flags |=3D SB_POSIXACL;
> +		sb->s_time_gran =3D 1;
> 		sb->s_time_min =3D S64_MIN;
> 		sb->s_time_max =3D S64_MAX;
> +		if (server->caps & NFS_CAP_ATOMIC_OPEN_V1)
> +			sb->s_export_op =3D &nfs_export_ops;
> +		break;
> 	}
>=20
> 	sb->s_magic =3D NFS_SUPER_MAGIC;
> --=20
> 2.37.2
>=20

--
Chuck Lever