Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 26 Aug 2022 11:08:55 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Chuck Lever III <chuck.lever@oracle.com>
Cc:     Leon Romanovsky <leon@kernel.org>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH v1] RDMA/core: Fix check_flush_dependency splat on addr_wq
Message-ID: <YwjT9yz8reC1HDR/@nvidia.com>
References: <166118222093.3250511.11454048195824271658.stgit@morisot.1015granger.net>
 <YwSLOxyEtV4l2Frc@unreal>
 <584E7212-BC09-48E1-A27E-725E54FA075E@oracle.com>
 <YwXtePKW+sn/89M6@unreal>
 <591D1B3D-B04A-4625-8DD0-CA0C2E986345@oracle.com>
 <YwjKpoVbd1WygWwF@nvidia.com>
 <08F23441-1532-4F40-9C2A-5DBD61B11483@oracle.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <08F23441-1532-4F40-9C2A-5DBD61B11483@oracle.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?keebmw9qgHiL8+2i7/nYxn+lycnNEYmK/qJRXe6CxDR7XLbHUaXgBNXDFITj?=
 =?us-ascii?Q?ZvoqKlkSxQ+zs7FSh34EglSwN8Bkxt3RY601AM0uyYtuH92uZ/ylnU/RewV4?=
 =?us-ascii?Q?I1+fPjBadsMg9ysQFwU26gw4DfUK5wa6eWJgeMkNikSSeFSmOSCwVxmHg347?=
 =?us-ascii?Q?QHgCQrAO8NtBW1uBtgRj+XRhIWUPiCBWmaXu43ksMNFeXWYroDjR1IO9bhBm?=
 =?us-ascii?Q?EL4kBcF5Q2HT7kUcBFjjYNh5Tadhy7Qy76X3oTN0xxWbFGHY33Qpd/zGn/Kn?=
 =?us-ascii?Q?QF+KAanOsOsN1We464IzWqsmSCKNbdGeKoShIHpdzzu2i9Zynww5wI4SnQsk?=
 =?us-ascii?Q?bqSPRdzMQ5Xisf1U5cFhhwFHe9WUK7qpRuYaXR9zJ1kB90YtdQygVT4tjacY?=
 =?us-ascii?Q?7GIGHP0kpA/2PrRlstMbvXnTAWntVqVpvXS0VJsYAVGSu+quSRE4uOkP7r4a?=
 =?us-ascii?Q?CDuNK75vB6Qxq4tIGeoyxKIe45qttQqyd2eR2sRp2iEDRpLIU4qfo752L+p6?=
 =?us-ascii?Q?+CVwnucVLmzhRHcIVGe+xYU0VcuOYsw5thuoEovOP1NjhLzdFvl9fnbTDk9j?=
 =?us-ascii?Q?5du0eHLDbQYT8oJ7Ww1oW/aoIiJUTQHrMRslpQykE43RmHLp6TZoSUv4rL0i?=
 =?us-ascii?Q?Ug+I2kiuZX65aIxLocpitaK9sUFzvatxuvlwE6vtCAq7MCRdgoceNw26yzW6?=
 =?us-ascii?Q?a9m8OompGamugmeXQNwyW269ivyC9qPw7W7aXb/g+QN2vhGN+h6n/6PjNqLZ?=
 =?us-ascii?Q?zeJ071swPtzAgk9G7TUQNBFLi44bCkoiNgi3hAmnV7xczN5+FjapvLn/O8EB?=
 =?us-ascii?Q?kVDfPlT1PfzxLyP5dygYHkOPRREiHOK33n1J15RhTds/81/51BalURV/Mwal?=
 =?us-ascii?Q?kakI/Lf8se1gXInPffZ1M1U0sT4Cwv15DauISLuKizYPiTFTRd75zVSI7YRy?=
 =?us-ascii?Q?qZv0mkkaGTi7W08/Xf5/aU5El5yJXZVmtXONTOwSwFJUPBqtqoeIVVe/busp?=
 =?us-ascii?Q?TG98eiZvwdXXVkBHT+CGLjDbuO2bcgGyjACVe29ejQdnceC4KeBKmrT7DIEV?=
 =?us-ascii?Q?xJpG3Kroc/zB6LwdnWRnnE1Ob8xBTYvfmzA8SmaEFJvN8w6USisU+DVlOzdV?=
 =?us-ascii?Q?Do1Yt8GmU/0+VKTuXk9rhC9oCHX8xNmYnLbBSGU8g6sJ8karf0FlEwVnauu1?=
 =?us-ascii?Q?kWw7+jbR1vLFPAXx+eUKvsY2wWj0e3JuLGjDXsIAL/ro3Mg6m/TLOXDGkSn8?=
 =?us-ascii?Q?1uMww6wi69O6gVhmW5uPpoe4B93amY+7mQ1/8OohuOA7RSCzEafkzUHiDfZ3?=
 =?us-ascii?Q?Q3CM/XAf5sIxzXjXjT7rdZxaQJF3tJPk3g5jizFGxozGhSbSfdMCLZ48nbgt?=
 =?us-ascii?Q?HA7Wwo4NEUc9dcBiGxe++c/I+zf/vcyXEqTS0XxGoCF50qecJW4io0Yy5R+r?=
 =?us-ascii?Q?nkXomSsjedvxodUpmjOq4l7daM16oVgSUVD8aJhhPw+EUj+t18l/JZH6YYHW?=
 =?us-ascii?Q?N6Y6Pc1uFmtll8l1cmKfz4bm2AR48FQX4pgGdkm/Z+tbd2VZEABY+P7B8ncw?=
 =?us-ascii?Q?osbo833d4cg0tdNyPQygMI8PSdLZezsxsIu8AWB5?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7d4a49d5-b6fd-4c73-b2dd-08da876c83d1
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Aug 2022 14:08:56.5840
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: P8mlPQqBpsSXigrJRLMymFULPMfGWFc+B1oz0zkOspL7XlJjnxiCZKdhvyte9bo2
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5142
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org

On Fri, Aug 26, 2022 at 02:02:55PM +0000, Chuck Lever III wrote:
 
> I see recent commits that do exactly what I've done for the reason I've done it.
> 
> 4c4b1996b5db ("IB/hfi1: Fix WQ_MEM_RECLAIM warning")

No, this one says:

    The hfi1_wq does not allocate memory with GFP_KERNEL or otherwise become
    entangled with memory reclaim, so this flag is appropriate.
    
So it is OK, it is not the same thing as adding WQ_MEM_RECLAIM to a WQ
that allocates memory.

> I accept that this might be a long chain to pull, but we need a plan
> to resolve this. 

It is not just a long chain, it is something that was never designed
to even work or thought about. People put storage ULPs on top of this
and just ignored the problem.

If someone wants to tackle this then we need a comprehensive patch
series identifying what functions are safe to call under memory
reclaim contexts and then fully auditing them that they are actually
safe.

Right now I don't even know the basic information what functions the
storage community need to be reclaim safe.

Jason