Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0fde3d40-d20f-6650-c3e4-79f1a2424ffc@nvidia.com>
Date:   Sat, 27 Aug 2022 15:48:19 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH 3/6] iov_iter: new iov_iter_pin_pages*() routines
Content-Language: en-US
To:     Al Viro <viro@zeniv.linux.org.uk>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Jens Axboe <axboe@kernel.dk>,
        Miklos Szeredi <miklos@szeredi.hu>,
        Christoph Hellwig <hch@infradead.org>,
        "Darrick J . Wong" <djwong@kernel.org>,
        Trond Myklebust <trond.myklebust@hammerspace.com>,
        Anna Schumaker <anna@kernel.org>, Jan Kara <jack@suse.cz>,
        Logan Gunthorpe <logang@deltatee.com>,
        linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org,
        linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
References: <20220827083607.2345453-1-jhubbard@nvidia.com>
 <20220827083607.2345453-4-jhubbard@nvidia.com> <YwqexJOL9GcOKRg1@ZenIV>
From:   John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <YwqexJOL9GcOKRg1@ZenIV>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dTkwM1NqeUNwSUNKSlN3TTV1UUsxQVNvbHZyL0s0bGtBRy9CbVRMZjJ0dHNF?=
 =?utf-8?B?MWRvWWk3MC8vL3BENFM2R3h0M0xGcHc0ZC9teWRFRzFBUlVXR0theVJ1MVFh?=
 =?utf-8?B?Y3lNdXg5LzlCdEYzNkNlTGxYWFN5Z0ZjeHFxZ0twS3dmMUhqZGdzSU4zdkgr?=
 =?utf-8?B?K2pxSzRZQUJTRDFSNFJmYWdpK2c5NFcvajRaT041UUE3aXhpUE9uak5zcGgr?=
 =?utf-8?B?NG5oZ1FiZzg3WE5EVlVyRTE2Vlc5WEtlcStxLzl3RmlkeXU4SUxvazdZVFZT?=
 =?utf-8?B?b2x3ZWpOYXJpVlFnWU1UYW9RdUsvQXhYU09PNHRkNC9TeEEwa1lRQnU5OHk4?=
 =?utf-8?B?dThPTDZhNGtKWUJTb2FSU2VielFVU3JRTFA4YVNZN1hhUXJRalQ2TUN2RXZn?=
 =?utf-8?B?TERVS3NrNy81aVA0eExRTWdicVZkLzZ1dnhCTW0rZmJnRjByc21lSHRVcTlp?=
 =?utf-8?B?MEVza3pwSzVrdnRmV3ZMR0hJb1RHYjV6NVN2TlVRN1NVSXdwcy9qL0FZdHhX?=
 =?utf-8?B?KzVaMWd2eit3Tmdna3B6Z0NGeVZzYm9oYkJsL3ROZVoyNkZrK0d4Y0x6Yzh5?=
 =?utf-8?B?dW84aWdkZGVVYnNQSHBMc09IVnd3TnFtcnIxR2ZMQk81WUc2dndOVGxKSVhG?=
 =?utf-8?B?V3h5Qlp6R2R2MkhLcVh2TzRxU1NwcjhUUWh6N2xZWmNpOFQ4U0RFQXFuY2pS?=
 =?utf-8?B?a0FZNXNTa29INlNIejNQbGZrRis5Sm1CVHlXR2xpUS9pUnU5b2RaQkRGUHZG?=
 =?utf-8?B?UzNaWUI5QzN1eGZOZlhnYkkxT3JoMTByVUJqWFVwaDBQSkZSZFZVOXAwSkdP?=
 =?utf-8?B?cFpTTXlvdnBuZnZvRFZWM29FQVYwV1h0RGFQU3BQSXZJZVN0dm9sK3dpdzZs?=
 =?utf-8?B?M0FLa201WFUwOUNDdkZlb1FjbkZScVpLSTJrNDQvOVByc3BESzFDQUoyU2lh?=
 =?utf-8?B?MytRdGZaWkJsSnpVcjVTN082cEZLcGVOakY3dmg4Z2dOVWtYTUFoQ2ZaaHZM?=
 =?utf-8?B?eDRJRnZ1MkgyUlJKQnZCczBWbmlrWlhOUitQRlFXZ2lXRk5MOGNJSTE2WUx5?=
 =?utf-8?B?RlpPUFJUTExaUlY5dkFmeUZGcE52ekJ0b2haU0w1cHF6K0NibkFXUjFwUWl4?=
 =?utf-8?B?QjF6SzUzL0ovQkNzaGlFL0NuV1E0aWNUU0Mxci9FTWlaMEFKNFZlbDBaK25r?=
 =?utf-8?B?eDUvOUNPTDlobExJTk1lc3pNNkpuekQrYkFubkI5aC9sY0M1cGFPeG9wZHJi?=
 =?utf-8?B?em1UU2tIdTlvTnJRV3NzUTFhOHZQOWg4VHAvUXF4MkxRSGNLSGpZSmRSZ0Zo?=
 =?utf-8?B?T0ltMTY5QnQ3N2RhajZyTkkycDFxem82QWYxd2h0NGowdzZyU0psNTByL2lG?=
 =?utf-8?B?NFBuZmc4UlpiczJaTXIrbEdacGI1dlhkWmM0QmlyaEVIempsaHRneXFyZ3dy?=
 =?utf-8?B?b0NvSXNEaW5neVBlS2NQemRhVjMrU3dObVlxbkllRGpiOG1JOVFsUjJ2UWgv?=
 =?utf-8?B?NS9DcloyYWZ1VU42RXcxYzUvUXVMRGlKUHhpenRaZytqQmx5Y1Vxa1JBaEd5?=
 =?utf-8?B?TVcwaUJhRWt1QXd4ai9aM1RYRmRNOWdQL25YclZZYTYzSitGOGZod2VmMWxD?=
 =?utf-8?B?OWcySEVRanNCQURQU1NBZkFRVTkySFhvMDk5N0dVckU1ejJ4M0E1NFVFd1E1?=
 =?utf-8?B?SVlTR1BNTGR4OFFZRnR1M2hIR1Q5azRCSXcyd2JWTUVRRVRJMmYyZmJLdzhm?=
 =?utf-8?B?SnJXZ1c4ZGg5RlhuQkFqdnJDN29qMDlOSW94OW1xWThjRFljNnNkcWx6YTJR?=
 =?utf-8?B?bHRIS2VhSzR2RGIvNy9FNVN4b1J3S0k1Vkc2MjB6UzRiWU90U2Z2aEZCb1BZ?=
 =?utf-8?B?QUFiNy9OblMwbUJSeThxK1EwbDZNTHdsQjFhWmg0Vm1iTE1pbGI2di8yYU9M?=
 =?utf-8?B?OFBBWjdQdnpDUGVzRm8vK1VKbFp0clJ4VElBVDlsU1pzNDBMdUZNUUFDMVVx?=
 =?utf-8?B?clh3MEs0L0dQVVlNOVpMZVZLUW5GRGhNRk4rckVOL0UxeFYyTmFIaEVkbFUx?=
 =?utf-8?B?UUVFeUxsQWwvWnhsKzMyYUJqVFdGc090ZS9HQjdxK0dkWWxGa256S3B6SVlH?=
 =?utf-8?Q?fPVRXHxfXGZXEZpXd5h+z84/j?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: edb93626-e8b7-4f6d-0afe-08da887e3f28
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4140.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Aug 2022 22:48:23.5847
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: K8TtZCZeqCyEc7d1+979yMq2LuA49tozzcE4cUYRn6agFnlxv3+XGpkbNT6xPJRAQLi+CGBhME3Qu9+Ug9lSiA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7227
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org

On 8/27/22 15:46, Al Viro wrote:
> On Sat, Aug 27, 2022 at 01:36:04AM -0700, John Hubbard wrote:
>> Provide two new wrapper routines that are intended for user space pages
>> only:
>>
>>     iov_iter_pin_pages()
>>     iov_iter_pin_pages_alloc()
>>
>> Internally, these routines call pin_user_pages_fast(), instead of
>> get_user_pages_fast().
>>
>> As always, callers must use unpin_user_pages() or a suitable FOLL_PIN
>> variant, to release the pages, if they actually were acquired via
>> pin_user_pages_fast().
>>
>> This is a prerequisite to converting bio/block layers over to use
>> pin_user_pages_fast().
> 
> You do realize that O_DIRECT on ITER_BVEC is possible, right?

I do now. But I didn't until you wrote this!

Any advice or ideas would be welcome here.


thanks,

-- 
John Hubbard
NVIDIA