Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <353f18ac-0792-2cb7-6675-868d0bd41d3d@nvidia.com>
Date:   Sat, 27 Aug 2022 16:55:18 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH 5/6] NFS: direct-io: convert to FOLL_PIN pages
Content-Language: en-US
To:     Al Viro <viro@zeniv.linux.org.uk>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Jens Axboe <axboe@kernel.dk>,
        Miklos Szeredi <miklos@szeredi.hu>,
        Christoph Hellwig <hch@infradead.org>,
        "Darrick J . Wong" <djwong@kernel.org>,
        Trond Myklebust <trond.myklebust@hammerspace.com>,
        Anna Schumaker <anna@kernel.org>, Jan Kara <jack@suse.cz>,
        Logan Gunthorpe <logang@deltatee.com>,
        linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org,
        linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
References: <20220827083607.2345453-1-jhubbard@nvidia.com>
 <20220827083607.2345453-6-jhubbard@nvidia.com> <YwqfWoAE2Awp4YvT@ZenIV>
From:   John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <YwqfWoAE2Awp4YvT@ZenIV>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SVJyck5RNm9Mdm9sWnlFNjRmdXZoLzdHZENMQ1h1Vit5RjJZeHJaVjM1WEx2?=
 =?utf-8?B?MFcwSTVueTdwOCtjb3kvRkkxRlZWRnkzbUlEaE1Xa0I2bDF5ZXZ3YnIzbGwx?=
 =?utf-8?B?NWhYWXpNMWREOWFVVm16Ly9SVEpmSnBiZVRRZWQwWWdXL3NFOFFLRVcwZ0VF?=
 =?utf-8?B?OTlySU14SmtlS1ZGWThxM0NhWHluK0tNZFR0NXdRYVlVbFg4MzlBQWV5dWdq?=
 =?utf-8?B?bzU3SG5adk14SUNPMk5aa3p6bi9uajZVakc1VGF3QVNYVFZyUjcvcGVWcEc3?=
 =?utf-8?B?ckU4dkJrNHl1MTgzVzFXQlQzRWw2RnlhY2ZrWUIvc3RHSUlSYUVFTngvOGM0?=
 =?utf-8?B?RUJBMnJCakgyaEpmeUp6WWh0aFp5MkxGa3JmUHgrK2g1U29qdjNVWFErMHow?=
 =?utf-8?B?Q240NklBYkZLRzlIckhqWkxaa1dMRmVualdJK0tjUncwV0FRUHZMN0oyV0VZ?=
 =?utf-8?B?dFpLRm4ybEpYQTVSUjN2UXRCd2pnT0p2QTc4TDBWUTZvNlJCRzNSa0VKQXZR?=
 =?utf-8?B?ODhkYUVIcFdVTGM5U2NQdmZMYVFwTFlJcGloVXhGcDhSNEFBa0JtNE8zSko5?=
 =?utf-8?B?RElzTlN3WElwWnhTSU1qWnFRZXRGZmlWMnNFSlJMV1ZSU25kR1R5YlJFM29U?=
 =?utf-8?B?elRkbjRnNE1OYjJiR0pHK2VzN3hOZjU5bkx2Uy9KRGlrM3cvZE9CdmdaaGdM?=
 =?utf-8?B?WTl5VndtSGRCZHVhd0lrc0hBNnl0NllLVjFTNnNXSW1URDFhd0MxMGF3VlA4?=
 =?utf-8?B?NzA4UHBEaE9ZUjJESE9pTTZPdlkxa0lFNEJzNGZMR2Y0QVJnbGFYa0dKVmYv?=
 =?utf-8?B?RmhnMHo5bnJHdmcvZ0pqNzBmN2ZOT3Q1ZkhIMzBMMlNBb2tPT0pWOGYzWkRl?=
 =?utf-8?B?TEtub2RINlBGRXgvZnRKdk1aWWUxRThaMzRJaUJnakR0SWMxbnFkeUtqY2dD?=
 =?utf-8?B?RDdKOVVvMFdVMFdaUUN5cnZrUVI1RHZtaHJiaE1zYjh4akpvSmxnQlpwWVJI?=
 =?utf-8?B?cXE1Wm1kR2cyc2NFVkNTNlhXcnhaUXFpRUpkSmlKT1RZYXAyYUFvaFY3QjRD?=
 =?utf-8?B?RUsxeTlGMFMvMmZKUE03L2VLNlVuZ09ZTEUwY1RzL1czM28rTzIvVzlBSlRa?=
 =?utf-8?B?VjJXKzBxaitINjhEVXU3bnluenFnSXA5aHAvb3BkSjBnWTdKdTFseFd4dEY1?=
 =?utf-8?B?UCs3azRDcG9uaEY3QnBTc3pLUGc1WUQxZkhPTXV0R2t1ZnE4WCt2cUx2TVVH?=
 =?utf-8?B?UXNrQ3JMUFJHZTdnWTcwY2lhSzlrOWJGNnVFSEJpbkx0VDZYWVczWGg1L1Bv?=
 =?utf-8?B?dWVlalZJWldaQnVIYUdyL2prcVowTUJOV0RBQWFscXBST2FrS2RhWFZoV3Ir?=
 =?utf-8?B?MzMrZXdaSEhHdFA3UllyWDRzUGFOQnEwL2pFVXhtbVB6OTgrOVpQMDZVY3NN?=
 =?utf-8?B?NC8zMEtnQUZtcUQxS3RsSE1GNWVCV1dYbjF3MEJ2bncxc3NKa1lVdVBrTFZx?=
 =?utf-8?B?QVRHTGRvUnpCRWg1b3V3T2UzTk1WcDBSZ1gya2VTRXo2aVg3cDAydVNjQmNh?=
 =?utf-8?B?OU9kbEM2UHh1NmtPLzkyRnhSN2xXZnFIYXBERW01Yk00SEtVc2Jla0hPVlZK?=
 =?utf-8?B?L2hQakQ3cUFpRXBmbW9iZ0pjZnhsc3k1YWhwUGxuQ2IyS1REMGFpYnBiTFlI?=
 =?utf-8?B?ZjlNYWw5b0Mrcm5zdjZYeFUxOEE1Y2gwMWRGR3docGhDc2VYamxpaHZPMmcy?=
 =?utf-8?B?bmNsdXpsam56OFQ2NU5KZDA1OWtXWmcwcE5udGNyVG5acXp5clBGZFlncE5z?=
 =?utf-8?B?ZDJBblUrN0MyMTQ3MzIvdjJpZGxEM3B2cTJPSlFBNys1NlZ1NGRHMmh1c0w2?=
 =?utf-8?B?SE5JNHk2NHdEcjM5S2owby9LL0NWVVlDUEZEcmR6N1FZWENGb3pUTXhPcDZv?=
 =?utf-8?B?eTNFWmR0U2xEaHEyemtiV200cWZmWDk1MnVFQWhOUmc3eklIRUtZbERwbzhP?=
 =?utf-8?B?VHVkandCZC82T0w2d3JnQVZVSkNvblBnc1hVU1poSkRHTENocmJ0Y0doOEMx?=
 =?utf-8?B?SWxYRE41a2FKZ2wxOWljeTlRSmVzR3pWVTdETnlFTDZxakFIbzU4OVIwd3Yy?=
 =?utf-8?Q?C4DEZxWb23ampuR6SenapifSy?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 44385745-3554-401a-102e-08da88879a0c
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Aug 2022 23:55:21.6239
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: apsHO4zqpZhGZRr6lGRbhwtUgOTTvjO+qeTS6+QnoBNSW1SORCrePMWV1tnUeBN/s2qw4CZ0UCA+KCntncPoGA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1201MB2555
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org

On 8/27/22 15:48, Al Viro wrote:
> On Sat, Aug 27, 2022 at 01:36:06AM -0700, John Hubbard wrote:
>> Convert the NFS Direct IO layer to use pin_user_pages_fast() and
>> unpin_user_page(), instead of get_user_pages_fast() and put_page().
> 
> Again, this stuff can be hit with ITER_BVEC iterators
> 
>> -		result = iov_iter_get_pages_alloc2(iter, &pagevec,
>> +		result = dio_w_iov_iter_pin_pages_alloc(iter, &pagevec,
>>  						  rsize, &pgbase);
> 
> and this will break on those.

If anyone has an example handy, of a user space program that leads
to this situation (O_DIRECT with ITER_BVEC), it would really help
me reach enlightenment a lot quicker in this area. :)

thanks,

-- 
John Hubbard
NVIDIA