Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d89943aa-5528-a424-099f-4b1a2151b893@nvidia.com>
Date:   Sat, 27 Aug 2022 17:31:32 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH 2/6] block: add dio_w_*() wrappers for pin, unpin user
 pages
Content-Language: en-US
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     Jens Axboe <axboe@kernel.dk>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Miklos Szeredi <miklos@szeredi.hu>,
        Christoph Hellwig <hch@infradead.org>,
        "Darrick J . Wong" <djwong@kernel.org>,
        Trond Myklebust <trond.myklebust@hammerspace.com>,
        Anna Schumaker <anna@kernel.org>, Jan Kara <jack@suse.cz>,
        Logan Gunthorpe <logang@deltatee.com>,
        linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org,
        linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
References: <20220827083607.2345453-1-jhubbard@nvidia.com>
 <20220827083607.2345453-3-jhubbard@nvidia.com>
 <20220827152745.3dcd05e98b3a4383af650a72@linux-foundation.org>
 <4c6903d4-0612-5097-0005-4a9420890826@nvidia.com>
 <20220827171220.fa2f21f6b22c6d3047857381@linux-foundation.org>
From:   John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <20220827171220.fa2f21f6b22c6d3047857381@linux-foundation.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QVFJRVliWW1TK3BoR1FyNWZvOGVlOU11TGJOblhXVlJrV1VIdXhHVFZHbUhq?=
 =?utf-8?B?OWplSThVYkdoWUFXOW1uQXRlQjlFcytWajJRTXR4YlNaRjdvQ1RmV0g1Vm1p?=
 =?utf-8?B?MGtraFVnZEhSY2ROcE41azg4dzdkbVIrVDBiU3BMVk5DVnVXTWVobjlrc09B?=
 =?utf-8?B?dDJtVkxNVzVjbllHOGZRM2QxRW5heWpZZkZFeFVOT2t4Z09wS0NZVGRHL0dn?=
 =?utf-8?B?NjZCd0ZDYXYrdkJJQTE2MHVFOGxZZjUrdnA3N2JkOHNXUnB5TkRROTgvY3Zr?=
 =?utf-8?B?THdmVDY4NWxoSGhaMWNyWWEzdU1wTWdTZU5XMUxEUjZyYjJlNTF0WUxyb0V2?=
 =?utf-8?B?Q1QwRmpLVmpkS0N2TWVLM0pEYk9BWlZkNUdLVGVCYTZDUjJjSURsd0dTT2s2?=
 =?utf-8?B?TEwzZEJ3bGlCZCtQanNPVk8xSERjWWw5VkpxV3ZuVXJ4eExSbzgrUXZZbWNh?=
 =?utf-8?B?ai9ZRnZyWUVlT2I0T0R2ZFRVWllZNmxHTEZUb3FVQ1lpMG9KNEtrM1NtT3lJ?=
 =?utf-8?B?M2FnbXJocW1heDZVaTBMejZuaWdTQTVWTWhyb0V5ekdDMWNqRm9lNGthMi90?=
 =?utf-8?B?ekNxU1pMRnFUaFJYZ1J1OE1ObWdkWGU2SXBFNG5IUC90RldPbVloeVFMSCt4?=
 =?utf-8?B?U2ExUVpNaE10SVpYTmIxRU1zK0pwYU5kYjZRbmZCVUJwQU9mMmtTb0hJS20y?=
 =?utf-8?B?ZUE2TTBFcFljcVlORTdyQnd5a2o3c0E2ZWt4TXVWekJiMHNwRUJZVVh1Q3F3?=
 =?utf-8?B?bEdPS0ZHQ3hXcjZLbHEzSWxvZk12MmozVFlQUXhjWCtickNHZTI0NkF4dkk0?=
 =?utf-8?B?MFlaSWpzZVFVR1VGaDl1UlUvMW91cndQTERHMm1lUGpYSmtIWDgvWVljK3pD?=
 =?utf-8?B?ci9tOWk3WnZNYUxud2x3KzRCRWZXUVc4dHd1VWFzeDBJMnFyVkZUZC9lZGFu?=
 =?utf-8?B?aGgvdWt0UnR4ZHQ3ZjZ0c2tkc1h1dlB3T0V4ak11OTg4N0pWdFkzak84WWhM?=
 =?utf-8?B?dWVUMFBEdE9qTG5zUjNUU3ZJYUZFcDJwcmVtVlVKblpiak5LakZjWEpUTHI2?=
 =?utf-8?B?WVQyTHROSHR3OExqM1VqVittaEltRjA0alBnbHB5OVJnODBwQzVadWtObWxr?=
 =?utf-8?B?NG5OM2VPdTc2T1lhUTkwSDQvQzM3cDMxbXowWmYzMUtqeEdVM2ptaDBuWUdo?=
 =?utf-8?B?WW9kbHFzNFBVcTFRdmFHa0U2Mmc4Uzh3VWFqKy9TZks0WUhVay81UWt3Nnht?=
 =?utf-8?B?MVVlNC9JbGdOck9DR1RQSEJxc1pac2hjWXpKOXFWRDJEV28zS0NnU0t6NXEv?=
 =?utf-8?B?NWt0TGs5bC85bVpFVTdDNWxIUFdwcmZBckxHcUFxemcyS3lFa2xqcjlLNURB?=
 =?utf-8?B?TDY3ZFZsU3AzUW9ESnFtei9wbXQ4QzA4bnVCNGhVNkpqVm1TSjJXakZ4Q0N6?=
 =?utf-8?B?dzFtLytmNEdNcDEwcEs2UnNuNnF6MC9QbmlhcjViOEJrUCtyLzRXcVJNTTF5?=
 =?utf-8?B?a1RTSFQ2dVU0Zmc3UHZVNmpLMFFCNXlWTXhjWGt0aGdYWGUxZC9xY1FiSjJZ?=
 =?utf-8?B?cW1zU1J5U1RLQ2lFUWlBV2dacTFQYXFUL1pkL09WSFZROE0zWjcrblZNQjdS?=
 =?utf-8?B?eE1YZTJIaDRvenZZNnBHOUNpRmVVcGNhbVo4c1hrMm9tbkh5Y2ZuOGl3Q0FL?=
 =?utf-8?B?Z0F2TXAxZlZRMm1hNEdyeWhWTTVwT2svVGpqbDV5YTd3QmJjTVJudHJqdGlt?=
 =?utf-8?B?aVZLNFlHdkVKMENCNVZ6UG1OYStGWEtjemNqTmlyRlU2QjNkOEJPRUhSZWVz?=
 =?utf-8?B?NEo2dXFjRlREMjBxWGhDSXBXd21QM3p3Z051Y2czVmtSdmk1UEYwc1k5YUZM?=
 =?utf-8?B?SXBvd3pGSHU3NHdMQ25aQlRzSStWRmNQRTNHR3dKSEdFR2tzSlVrZUcvWktw?=
 =?utf-8?B?c0NlMEpabmh3a1AzQjZ1VlEvTmEzVHBOdkx5VU5pVkdacVVQcFFQTSs0c094?=
 =?utf-8?B?Zld4Q0x6dWthajdGdnMvUmNoQ0xlL0xTSi9idW9sbFIzV3R6MmhScGh6NVkz?=
 =?utf-8?B?NG9DRE4zb2hoTnhVY1NzTDYvZXFyTkRlNUhGSGpiNVdDd3hZMWpkYlYrZCt2?=
 =?utf-8?Q?hC67OYox7NnYOKf30LQ79zrUY?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e4304a4f-a4c9-4812-91b4-08da888ca9a7
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Aug 2022 00:31:35.0726
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EHSRQoP8IJoBhdwKwptL2qvi0K6O1U4THmdQDZwr5lHToK/YiKldBIkNLoVkvhes0R0whLX1MCHhgawq53FBWg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6653
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org

On 8/27/22 17:12, Andrew Morton wrote:
> On Sat, 27 Aug 2022 16:59:32 -0700 John Hubbard <jhubbard@nvidia.com> wrote:
> 
>> Anyway, I'll change my patch locally for now, to this:
>>
>> static inline void dio_w_unpin_user_pages(struct page **pages,
>> 					  unsigned long npages)
>> {
>> 	/* Careful, release_pages() uses a smaller integer type for npages: */
>> 	if (WARN_ON_ONCE(npages > (unsigned long)INT_MAX))
>> 		return;
>>
>> 	release_pages(pages, (int)npages);
>> }
> 
> Well, it might be slower.  release_pages() has a ton of fluff.
> 
> As mentioned, the above might be faster if the pages tend
> to have page_count()==1??
> 

I don't think we can know the answer to that. This code is called
in all kinds of situations, and it seems to me that whatever
tradeoffs are best for release_pages(), are probably also reasonable
for this code.

Even with all the fluff in release_pages(), it at least batches
the pages, as opposed to the simple put_page() in a loop. Most of 
the callers do have more than one page to release in non-error cases,
so release_pages() does seem better.


thanks,

-- 
John Hubbard
NVIDIA