Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2c30c786-acad-238d-327e-2669e7ebcfcc@nvidia.com>
Date:   Sat, 27 Aug 2022 17:46:25 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH 5/6] NFS: direct-io: convert to FOLL_PIN pages
Content-Language: en-US
To:     Al Viro <viro@zeniv.linux.org.uk>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Jens Axboe <axboe@kernel.dk>,
        Miklos Szeredi <miklos@szeredi.hu>,
        Christoph Hellwig <hch@infradead.org>,
        "Darrick J . Wong" <djwong@kernel.org>,
        Trond Myklebust <trond.myklebust@hammerspace.com>,
        Anna Schumaker <anna@kernel.org>, Jan Kara <jack@suse.cz>,
        Logan Gunthorpe <logang@deltatee.com>,
        linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org,
        linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
References: <20220827083607.2345453-1-jhubbard@nvidia.com>
 <20220827083607.2345453-6-jhubbard@nvidia.com> <YwqfWoAE2Awp4YvT@ZenIV>
 <353f18ac-0792-2cb7-6675-868d0bd41d3d@nvidia.com> <Ywq5ILRNxsbWvFQe@ZenIV>
 <Ywq5VrSrY341UVpL@ZenIV>
From:   John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <Ywq5VrSrY341UVpL@ZenIV>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cURlZUJ5NkwrSit5OTVjY1gzeU1hTGhGaFZSRWVNdkdIeWtRVkxiVnRiV29h?=
 =?utf-8?B?ZllHQnBuYjk4bW1iMEtCdG45bTZNUDdoZ2ZLeVZWQmVTNElRSW1ydTA4eHdE?=
 =?utf-8?B?S2hlNzJhZ1VaelFXN2hmbEcyVW42TlkwNkEzT05GQmZXMmdQakJwVWhURlVG?=
 =?utf-8?B?WU5lRzY0cUl5cnpOQVlnTjBpczBKNDlNb0gwSElWdG5pV21hclRoWWh0VkNW?=
 =?utf-8?B?alVNMXhZNUFKZ3E2NElmK2hLWGQ0dEw5cUtCTWVIcE9mdjVhb3lZY1B5ODhT?=
 =?utf-8?B?c2xUU3U2b1BoRjJyaldLQnVOdkRkT0pldlgrWGFVM1JWNXN3K2FuZ1dINWRL?=
 =?utf-8?B?WEhmR1NBQWZHd3l3emt4SU1LVzQwWFE2N1R5d1lGWnRJdW11Ym1aYng0cW9V?=
 =?utf-8?B?bzBta1pTMHNlbWozVExnRHptZG5qaWJSS0NUMm1oY0FYRi9idFdjeDJLeUFv?=
 =?utf-8?B?d2M5Vmd0YTB4R2Q5RE9paTZhRzhIbDVMbEswajFoTmxuN0I5TkVXck1UNzFP?=
 =?utf-8?B?dW1PSGhCQytBdW1zck4wZXFYcGczOFFsR1JreG9xcTBKb3Y1M2xkcWZidWg5?=
 =?utf-8?B?OUpGd0RRK1pXb0hoUVJYWkJUZFVlUDNablc5NjZrMzRLY0RscHVzS2ZiaG9l?=
 =?utf-8?B?QkQ1N3ZFaVFlcVByRmVVbWpLQjVlVElPbzVpZi9ZeU91NjA0L3FGK2ZwZFp0?=
 =?utf-8?B?NUVic001THRLZU5TaE9FcVZTb3dGWUptOWpBdUlQQWE1eFh2Rm81N1c0dzdx?=
 =?utf-8?B?RG1WUzcvU2V6Z1Y0YjNHVVJGVGlHNER0eU1nS0dKWXJCRmk2cWdDcEFkalYr?=
 =?utf-8?B?U1grME5pOER3bEF3OWxha21qVXF4VHl0UVVEWmFHQXZtS1MxdGx5aFoyaE9q?=
 =?utf-8?B?YXpZMzNjWGx6a0wzSW51dFJWaUp3THRLOG9CUnlMNDY4MEthZVJlWFpxSG4z?=
 =?utf-8?B?VTlKU1VUbkNudk9oaHc0UUUzUG5wYkdUZFBIRWcwVndtMHVET2JGd2FNWVVN?=
 =?utf-8?B?SEhKL3ozZ2k0V0t3Q0s5Nk5pSWJlejFYL1ZRZHgrVmpvV0VBNldQMEhZMTM2?=
 =?utf-8?B?eXpjUGF4ajlDZFNJdFBKSGhUcnZmb1RNQlZrR0Z3YmQzcnNPS01jZjF5dGlS?=
 =?utf-8?B?MEYzY0twL3MzTjd4TzMrcTQxY0VSSFZIYXI3dHlJQkh4RUx1SDdreWR3WWUx?=
 =?utf-8?B?eWl3QXhNL25iZlI0MWpMdi8vSTVYNCtISkduQ3AyTTVjK2xwbU5QTEFwSnp4?=
 =?utf-8?B?dEtweEJUaEQ0MG9aSUZGUWxqOUorUDBCRXhVSmNCMUY5d0pPSG9xb3FUenY4?=
 =?utf-8?B?Umlibi9TSHp5c0xzc3BxL3JVRUp2L0NaalRjQU9XT3ZSN2kyQTJMTUVpL1Rm?=
 =?utf-8?B?UUM3c28zY0ppSTkvb0htbXc2Y2JUeDFUVGFzUU50ZVJ5UHpWbnVnaG1yRVlx?=
 =?utf-8?B?R0VPRzNVK1VKbnpraEVwdGw2VUxZQlUzZGpnUDVTNHFjQWExY00wOUppQmhI?=
 =?utf-8?B?NlZJWnVIdVRTNFRVRWNaNUNVM0xDa09hbFpsQjFTOEFCVGRGTkRBTGxXRVpm?=
 =?utf-8?B?RmU3L2tQNm4zMkxxYXA3RUFzM01vbWJ2bG5CS25XT0FJME9KdXBjWUtwc2xC?=
 =?utf-8?B?bDZheEVDWlYzYkNsUzI1NGpsT0xkZzNhOHk3Mkdhb2VDV3dqTzA2UTBOSCt3?=
 =?utf-8?B?UUFBNUtpNkszYzVhTkx3NVhNVHhvaTlEazYxUjAvVkh3OXRwZlc1SkVTRHQw?=
 =?utf-8?B?N3RyUmt4RE11OFZESkY2eWxhVnBkSGdKVkZuU2RlcTVBRXBLYm5sT0JXclJZ?=
 =?utf-8?B?bVVId0xDSzVyS25aU29yUUFLb1lQb3NKNDQxdjhMYVdhOUhJcW4xa0R4Nmlm?=
 =?utf-8?B?M0M4dXhXeU5XZzRLTzZma0pOcVdDM2FTT3l1L2o2UE1yQWZLSWt6WG4xaW5F?=
 =?utf-8?B?V3NCVEt6a3psM0RZb056VnBCZlZFcGdLSkkwZ1NHeExkcjNqSFBZa3IxK2VM?=
 =?utf-8?B?bzZPcXhtWjBVU0xQV0tkY3M0MHZFYlFvUUpVb3Vqa1VCbzk1OWxPZjgyTXQy?=
 =?utf-8?B?ZVlGUjlUUGlhVnZzanhxcnBPR01SRWl3dHRDZk92cTFNSHJhNjBLdWJMOWpt?=
 =?utf-8?Q?opjdSvKnxd2ZHS2XAEcSHsrXC?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a623983f-6156-469e-ae52-08da888ebe0b
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Aug 2022 00:46:28.2609
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: U/Nq9SNjF3yH5zZJmY2cH6Accvi1dAw0/vXBFLFFshDkNMCO7dt+F91l2uER9YC0SHIjhNVJblWks3N3D/T+KA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6933
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org

On 8/27/22 17:39, Al Viro wrote:
> On Sun, Aug 28, 2022 at 01:38:57AM +0100, Al Viro wrote:
>> On Sat, Aug 27, 2022 at 04:55:18PM -0700, John Hubbard wrote:
>>> On 8/27/22 15:48, Al Viro wrote:
>>>> On Sat, Aug 27, 2022 at 01:36:06AM -0700, John Hubbard wrote:
>>>>> Convert the NFS Direct IO layer to use pin_user_pages_fast() and
>>>>> unpin_user_page(), instead of get_user_pages_fast() and put_page().
>>>>
>>>> Again, this stuff can be hit with ITER_BVEC iterators
>>>>
>>>>> -		result = iov_iter_get_pages_alloc2(iter, &pagevec,
>>>>> +		result = dio_w_iov_iter_pin_pages_alloc(iter, &pagevec,
>>>>>  						  rsize, &pgbase);
>>>>
>>>> and this will break on those.
>>>
>>> If anyone has an example handy, of a user space program that leads
>>> to this situation (O_DIRECT with ITER_BVEC), it would really help
>>> me reach enlightenment a lot quicker in this area. :)
>>
>> Er...  splice(2) to O_DIRECT-opened file on e.g. ext4?  Or
>> sendfile(2) to the same, for that matter...
> 
> s/ext4/nfs/ to hit this particular codepath, obviously.

aha, thanks. I do remember that you alerted me earlier to splice(2)
problems, and I thought I'd neatly sidestepped those this time, by
staying with user_backed_iter(i) cases. 

But I see that it's going to take something more, after all.


thanks,

-- 
John Hubbard
NVIDIA