Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <345f3293-51fd-1f2c-9d6a-7e6e8950102d@nvidia.com>
Date:   Sat, 27 Aug 2022 18:07:48 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH 2/6] block: add dio_w_*() wrappers for pin, unpin user
 pages
Content-Language: en-US
From:   John Hubbard <jhubbard@nvidia.com>
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     Jens Axboe <axboe@kernel.dk>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Miklos Szeredi <miklos@szeredi.hu>,
        Christoph Hellwig <hch@infradead.org>,
        "Darrick J . Wong" <djwong@kernel.org>,
        Trond Myklebust <trond.myklebust@hammerspace.com>,
        Anna Schumaker <anna@kernel.org>, Jan Kara <jack@suse.cz>,
        Logan Gunthorpe <logang@deltatee.com>,
        linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org,
        linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
References: <20220827083607.2345453-1-jhubbard@nvidia.com>
 <20220827083607.2345453-3-jhubbard@nvidia.com>
 <20220827152745.3dcd05e98b3a4383af650a72@linux-foundation.org>
 <4c6903d4-0612-5097-0005-4a9420890826@nvidia.com>
 <20220827171220.fa2f21f6b22c6d3047857381@linux-foundation.org>
 <d89943aa-5528-a424-099f-4b1a2151b893@nvidia.com>
In-Reply-To: <d89943aa-5528-a424-099f-4b1a2151b893@nvidia.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NjBHQmpSb1ExWkx0VkdRRENabG9VekZnVVlodnhyc0pxem16cXAwdXRoNjMw?=
 =?utf-8?B?L090aVI3MWdGQ2JtaDFPOEtRVXcxejZlb2hhRXJpVEp1ZEFvanpIRklSeVIv?=
 =?utf-8?B?bDVsc3EwS1ZyaXRRaW93dFhSVlQycWZ3NjdUa2VLUEZrWVR1UXl3RmY3Zkg0?=
 =?utf-8?B?ZmkwQUFYbHE2OVVlc3ltUXBRdllSYkRRNDR4bnArNmN5R0dDekNiWDJhY1Qx?=
 =?utf-8?B?SE15SlZaUmxwWjVzRFZIVGNmTUptY0E1a21SU05iMFFreHErelJXRzlHM0xp?=
 =?utf-8?B?VVRuV3haM0tEZk9UOWkzRFB1TEFMRmo5aVA0OHc5cmtvcDJESFNhT0ZOdnNj?=
 =?utf-8?B?NDF1SXJDbHVmMi9EVlVXbG02Wm5sQnBGQXJkbzIxQkVjR0JQRWJMYldXRGJO?=
 =?utf-8?B?cnRVaFROUWRoSk1vTnNacmM0MTk2d2tQWXRwQzNmNlVKNVFXWFRQTTBmcWsy?=
 =?utf-8?B?YU96d0hvT3NEdFJSOTV2SUdoWTRKNHJ5ckFrWmhtYUJPS0N3OWFKTVVlTUZZ?=
 =?utf-8?B?MlpvekdCS3BlMVR0MS9oUmp1V01IMm9FTnVWa2xwWkVsQm1Kd012aVhycHFI?=
 =?utf-8?B?VTVhczdqK0d0a3hTZ0hNNU1jVUZSME9paElmYllCRkZCWEhEOFVVVTJNOWFl?=
 =?utf-8?B?M0xsRURsMkVsRUR0S3Y5WFEzcU1vV29tY0liOWRBeTFiK1B0TzZ2dnREbW9J?=
 =?utf-8?B?a0grM2VOVnlaTU9EeEN1RmxmZ0VhS2lRUUhMTExreURjRjBqL2x5d2Q0aUhD?=
 =?utf-8?B?OE44d3RXTUx3dGZmbU4wWVliZkFiY255VktsRTE0dTk0UWxqRHQxVEN1Y0U2?=
 =?utf-8?B?UkJSTXR3eHpPYXZuYm9qZ3ZVTjZxZlloYmNJVmExWU1pdmZySGxmQk5wZW9W?=
 =?utf-8?B?cEZaTE4wQkRqZjJFSnZramNPd0lsWVJvcWJOSUJYdEZZR0xablFhOXE4S3JD?=
 =?utf-8?B?eVR5a3I4aldROTVCeXZBRTZnZjFaUzIyYVhwVTNoRGdXUC95eDVGWWgwYi9V?=
 =?utf-8?B?ZmZCN0c0MTE3bzNaVVMxYWM3NlJ5QU9TSDM2VlgwQ1c1YkRPUm54d0F1dUd4?=
 =?utf-8?B?MGlMNURnMjJVU0FMMEMxeTFkT3BCZmhpT0x0empnZTdhRFZRa3VKUW53MXZn?=
 =?utf-8?B?cmU5M1J3c09OUW5PWnQxYWxERGRWZWJtUkpGbUNUR0ZRbXA2T2VuUXRVUTBL?=
 =?utf-8?B?WUJUVUZnUkhqZDdTa2ppNFErT0FPUGs1aDhsYjdNMW5uRDM1c0l0enhKM21k?=
 =?utf-8?B?VzRBS1Q3c2QwMkk4cUtMKzgvY0lhQ2o3RE5RUHYvaHNCMFNadDhPalVmYk1J?=
 =?utf-8?B?WWRoNnlCQkpGZzV2RC9HU015RGxPTXpEZFJWQ0ZDY1JKSVQ3ZEZYeEtGK1I5?=
 =?utf-8?B?aXRSZ0hWOFdQTUUvUUpuSjZ3REk5Qmpic1VNZzkvZWRkVHMyWUovaFNoOVds?=
 =?utf-8?B?V1BNdGdRZHRpbEQvOGx1OGQ4Rk9YUWhmaW1ZZ3JWcUdjcTNWbUlHTE1wQzZ6?=
 =?utf-8?B?SS9nUmZrN04vOFZtaW5TdEpwWTJCZDI3VFB0WnM0L0ljSTBCWHo4MzdMVEJF?=
 =?utf-8?B?N3VlN2lDQzcwc3R3Uk1jM01paGtEN25lVXFmTFh6cWl2U3dvbE5ua0hpZGNj?=
 =?utf-8?B?SmkvNjFud1p5eHNTR0pqQnpSYVRNbFh2cDF2dTJjNnZNTzdrU0g4cWNnbDhN?=
 =?utf-8?B?MkRxOERVdzRrUVViRGZzMVlSaWJqdStTd3dGYmxHUVlIRkt0TmNvN0ltZ09G?=
 =?utf-8?B?MXhEUzBJMlhBbTcyYVZrRTFhcnh2S0tLOGtDMnNHZVF2R2VRUXRWMmVmT0xk?=
 =?utf-8?B?eDVxVWhPYnZKeGx3QW1PTTdsVVorMDFWVnFRNDFPeWRZMERCYkhOUmw2L0ZL?=
 =?utf-8?B?eWx3K2F5c0tHblJXU0NibGVCeDZLb25QamhPM3k5UC8xU25zdDkydU5vbXNv?=
 =?utf-8?B?cGxxalZRbnVQLzYwMWlKTlhFZ3BxcUtZWnR2aGgvazExbWZGb3JpYlZuaFFj?=
 =?utf-8?B?OUhxT05sTFlPK2NRTHN0RG5mc0V1bmlKc3N5a1daUlRCdWZyeEZQTTk0VTN0?=
 =?utf-8?B?UHdsNWdCeFZneUlpaElMa0w5SnN4amRPeVNuTzFUUWlrTkhNTC90ZUdiRUw2?=
 =?utf-8?Q?uv3zBsq5sDOtAuKRzkXpU5BuA?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1507fa3d-c5fc-49ff-41e0-08da8891bada
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Aug 2022 01:07:51.4097
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8pSUopkVYVUGWDefwj8jBPnQR7aQaL0ZsnQpAiwL5O7IhITgUHPipP8vBjnPg+vZ1WldfJ3KHWKglDrfjK+O/g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4779
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org

On 8/27/22 17:31, John Hubbard wrote:
> On 8/27/22 17:12, Andrew Morton wrote:
>> On Sat, 27 Aug 2022 16:59:32 -0700 John Hubbard <jhubbard@nvidia.com> wrote:
>>
>>> Anyway, I'll change my patch locally for now, to this:
>>>
>>> static inline void dio_w_unpin_user_pages(struct page **pages,
>>> 					  unsigned long npages)
>>> {
>>> 	/* Careful, release_pages() uses a smaller integer type for npages: */
>>> 	if (WARN_ON_ONCE(npages > (unsigned long)INT_MAX))
>>> 		return;
>>>
>>> 	release_pages(pages, (int)npages);
>>> }
>>
>> Well, it might be slower.  release_pages() has a ton of fluff.
>>
>> As mentioned, the above might be faster if the pages tend
>> to have page_count()==1??
>>
> 
> I don't think we can know the answer to that. This code is called

To clarify: I mean, I don't think we can know whether or not these pages 
usually have page_count()==1.


thanks,

-- 
John Hubbard
NVIDIA