Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a1790685fd8967838243ced5fe54d7acca43df88.camel@kernel.org>
Subject: Re: [PATCH v2 5/7] NFSD: Clean up WRITE arg decoders
From:   Jeff Layton <jlayton@kernel.org>
To:     Chuck Lever <chuck.lever@oracle.com>, linux-nfs@vger.kernel.org
Date:   Mon, 29 Aug 2022 09:49:12 -0400
In-Reply-To: <166171264742.21449.12798598095676580927.stgit@manet.1015granger.net>
References: <166171174172.21449.5036120183381273656.stgit@manet.1015granger.net>
         <166171264742.21449.12798598095676580927.stgit@manet.1015granger.net>
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-1.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Sun, 2022-08-28 at 14:50 -0400, Chuck Lever wrote:
> xdr_stream_subsegment() already returns a boolean value.
>=20
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---
>  fs/nfsd/nfs3xdr.c |    4 +---
>  fs/nfsd/nfsxdr.c  |    4 +---
>  2 files changed, 2 insertions(+), 6 deletions(-)
>=20
> diff --git a/fs/nfsd/nfs3xdr.c b/fs/nfsd/nfs3xdr.c
> index 71e32cf28885..3308dd671ef0 100644
> --- a/fs/nfsd/nfs3xdr.c
> +++ b/fs/nfsd/nfs3xdr.c
> @@ -571,10 +571,8 @@ nfs3svc_decode_writeargs(struct svc_rqst *rqstp, str=
uct xdr_stream *xdr)
>  		args->count =3D max_blocksize;
>  		args->len =3D max_blocksize;
>  	}
> -	if (!xdr_stream_subsegment(xdr, &args->payload, args->count))
> -		return false;
> =20
> -	return true;
> +	return xdr_stream_subsegment(xdr, &args->payload, args->count);
>  }
> =20
>  bool
> diff --git a/fs/nfsd/nfsxdr.c b/fs/nfsd/nfsxdr.c
> index aba8520b4b8b..caf6355b18fa 100644
> --- a/fs/nfsd/nfsxdr.c
> +++ b/fs/nfsd/nfsxdr.c
> @@ -338,10 +338,8 @@ nfssvc_decode_writeargs(struct svc_rqst *rqstp, stru=
ct xdr_stream *xdr)
>  		return false;
>  	if (args->len > NFSSVC_MAXBLKSIZE_V2)
>  		return false;
> -	if (!xdr_stream_subsegment(xdr, &args->payload, args->len))
> -		return false;
> =20
> -	return true;
> +	return xdr_stream_subsegment(xdr, &args->payload, args->len);
>  }
> =20
>  bool
>=20
>=20

Reviewed-by: Jeff Layton <jlayton@kernel.org>