Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6a8523552dba647518fd8590349d64d25d1b6fe4.camel@kernel.org>
Subject: Re: [PATCH v3 1/3] NFS: Rename readpage_async_filler to
 nfs_pageio_add_page
From:   Jeff Layton <jlayton@kernel.org>
To:     Dave Wysochanski <dwysocha@redhat.com>,
        Anna Schumaker <anna.schumaker@netapp.com>,
        Trond Myklebust <trond.myklebust@hammerspace.com>,
        David Howells <dhowells@redhat.com>
Cc:     linux-nfs@vger.kernel.org, linux-cachefs@redhat.com,
        Benjamin Maynard <benmaynard@google.com>,
        Daire Byrne <daire.byrne@gmail.com>
Date:   Wed, 31 Aug 2022 12:31:41 -0400
In-Reply-To: <20220831005053.1287363-2-dwysocha@redhat.com>
References: <20220831005053.1287363-1-dwysocha@redhat.com>
         <20220831005053.1287363-2-dwysocha@redhat.com>
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-1.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Tue, 2022-08-30 at 20:50 -0400, Dave Wysochanski wrote:
> Rename readpage_async_filler to nfs_pageio_add_page to
> better reflect what this function does (add a page to
> the nfs_pageio_descriptor), and simplify arguments to
> this function by removing struct nfs_readdesc.
>=20
> Signed-off-by: Dave Wysochanski <dwysocha@redhat.com>
> ---
>  fs/nfs/read.c | 60 +++++++++++++++++++++++++--------------------------
>  1 file changed, 30 insertions(+), 30 deletions(-)
>=20
> diff --git a/fs/nfs/read.c b/fs/nfs/read.c
> index 8ae2c8d1219d..525e82ea9a9e 100644
> --- a/fs/nfs/read.c
> +++ b/fs/nfs/read.c
> @@ -127,11 +127,6 @@ static void nfs_readpage_release(struct nfs_page *re=
q, int error)
>  	nfs_release_request(req);
>  }
> =20
> -struct nfs_readdesc {
> -	struct nfs_pageio_descriptor pgio;
> -	struct nfs_open_context *ctx;
> -};
> -
>  static void nfs_page_group_set_uptodate(struct nfs_page *req)
>  {
>  	if (nfs_page_group_sync_on_bit(req, PG_UPTODATE))
> @@ -153,7 +148,8 @@ static void nfs_read_completion(struct nfs_pgio_heade=
r *hdr)
> =20
>  		if (test_bit(NFS_IOHDR_EOF, &hdr->flags)) {
>  			/* note: regions of the page not covered by a
> -			 * request are zeroed in readpage_async_filler */
> +			 * request are zeroed in nfs_pageio_add_page
> +			 */
>  			if (bytes > hdr->good_bytes) {
>  				/* nothing in this request was good, so zero
>  				 * the full extent of the request */
> @@ -281,8 +277,10 @@ static void nfs_readpage_result(struct rpc_task *tas=
k,
>  		nfs_readpage_retry(task, hdr);
>  }
> =20
> -static int
> -readpage_async_filler(struct nfs_readdesc *desc, struct page *page)
> +int
> +nfs_pageio_add_page(struct nfs_pageio_descriptor *pgio,
> +		    struct nfs_open_context *ctx,
> +		    struct page *page)
>  {
>  	struct inode *inode =3D page_file_mapping(page)->host;
>  	unsigned int rsize =3D NFS_SERVER(inode)->rsize;
> @@ -302,15 +300,15 @@ readpage_async_filler(struct nfs_readdesc *desc, st=
ruct page *page)
>  			goto out_unlock;
>  	}
> =20
> -	new =3D nfs_create_request(desc->ctx, page, 0, aligned_len);
> +	new =3D nfs_create_request(ctx, page, 0, aligned_len);
>  	if (IS_ERR(new))
>  		goto out_error;
> =20
>  	if (len < PAGE_SIZE)
>  		zero_user_segment(page, len, PAGE_SIZE);
> -	if (!nfs_pageio_add_request(&desc->pgio, new)) {
> +	if (!nfs_pageio_add_request(pgio, new)) {
>  		nfs_list_remove_request(new);
> -		error =3D desc->pgio.pg_error;
> +		error =3D pgio->pg_error;
>  		nfs_readpage_release(new, error);
>  		goto out;
>  	}
> @@ -332,7 +330,8 @@ readpage_async_filler(struct nfs_readdesc *desc, stru=
ct page *page)
>  int nfs_read_folio(struct file *file, struct folio *folio)
>  {
>  	struct page *page =3D &folio->page;
> -	struct nfs_readdesc desc;
> +	struct nfs_pageio_descriptor pgio;
> +	struct nfs_open_context *ctx;
>  	struct inode *inode =3D page_file_mapping(page)->host;
>  	int ret;
> =20
> @@ -358,29 +357,29 @@ int nfs_read_folio(struct file *file, struct folio =
*folio)
> =20
>  	if (file =3D=3D NULL) {
>  		ret =3D -EBADF;
> -		desc.ctx =3D nfs_find_open_context(inode, NULL, FMODE_READ);
> -		if (desc.ctx =3D=3D NULL)
> +		ctx =3D nfs_find_open_context(inode, NULL, FMODE_READ);
> +		if (ctx =3D=3D NULL)
>  			goto out_unlock;
>  	} else
> -		desc.ctx =3D get_nfs_open_context(nfs_file_open_context(file));
> +		ctx =3D get_nfs_open_context(nfs_file_open_context(file));
> =20
> -	xchg(&desc.ctx->error, 0);
> -	nfs_pageio_init_read(&desc.pgio, inode, false,
> +	xchg(&ctx->error, 0);
> +	nfs_pageio_init_read(&pgio, inode, false,
>  			     &nfs_async_read_completion_ops);
> =20
> -	ret =3D readpage_async_filler(&desc, page);
> +	ret =3D nfs_pageio_add_page(&pgio, ctx, page);
>  	if (ret)
>  		goto out;
> =20
> -	nfs_pageio_complete_read(&desc.pgio);
> -	ret =3D desc.pgio.pg_error < 0 ? desc.pgio.pg_error : 0;
> +	nfs_pageio_complete_read(&pgio);
> +	ret =3D pgio.pg_error < 0 ? pgio.pg_error : 0;
>  	if (!ret) {
>  		ret =3D wait_on_page_locked_killable(page);
>  		if (!PageUptodate(page) && !ret)
> -			ret =3D xchg(&desc.ctx->error, 0);
> +			ret =3D xchg(&ctx->error, 0);
>  	}
>  out:
> -	put_nfs_open_context(desc.ctx);
> +	put_nfs_open_context(ctx);
>  	trace_nfs_aop_readpage_done(inode, page, ret);
>  	return ret;
>  out_unlock:
> @@ -391,9 +390,10 @@ int nfs_read_folio(struct file *file, struct folio *=
folio)
> =20
>  void nfs_readahead(struct readahead_control *ractl)
>  {
> +	struct nfs_pageio_descriptor pgio;
> +	struct nfs_open_context *ctx;
>  	unsigned int nr_pages =3D readahead_count(ractl);
>  	struct file *file =3D ractl->file;
> -	struct nfs_readdesc desc;
>  	struct inode *inode =3D ractl->mapping->host;
>  	struct page *page;
>  	int ret;
> @@ -407,25 +407,25 @@ void nfs_readahead(struct readahead_control *ractl)
> =20
>  	if (file =3D=3D NULL) {
>  		ret =3D -EBADF;
> -		desc.ctx =3D nfs_find_open_context(inode, NULL, FMODE_READ);
> -		if (desc.ctx =3D=3D NULL)
> +		ctx =3D nfs_find_open_context(inode, NULL, FMODE_READ);
> +		if (ctx =3D=3D NULL)
>  			goto out;
>  	} else
> -		desc.ctx =3D get_nfs_open_context(nfs_file_open_context(file));
> +		ctx =3D get_nfs_open_context(nfs_file_open_context(file));
> =20
> -	nfs_pageio_init_read(&desc.pgio, inode, false,
> +	nfs_pageio_init_read(&pgio, inode, false,
>  			     &nfs_async_read_completion_ops);
> =20
>  	while ((page =3D readahead_page(ractl)) !=3D NULL) {
> -		ret =3D readpage_async_filler(&desc, page);
> +		ret =3D nfs_pageio_add_page(&pgio, ctx, page);
>  		put_page(page);
>  		if (ret)
>  			break;
>  	}
> =20
> -	nfs_pageio_complete_read(&desc.pgio);
> +	nfs_pageio_complete_read(&pgio);
> =20
> -	put_nfs_open_context(desc.ctx);
> +	put_nfs_open_context(ctx);
>  out:
>  	trace_nfs_aop_readahead_done(inode, nr_pages, ret);
>  }

Yeah, a special args struct only with 2 fields in it does seem sort of
pointless:

Reviewed-by: Jeff Layton <jlayton@kernel.org>