Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <85a8a0e1-72dd-e37c-85c5-77fab21acde4@nvidia.com>
Date:   Wed, 31 Aug 2022 18:48:59 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.0
Subject: Re: [PATCH v2 4/7] iov_iter: new iov_iter_pin_pages*() routines
Content-Language: en-US
To:     Al Viro <viro@zeniv.linux.org.uk>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Jens Axboe <axboe@kernel.dk>,
        Miklos Szeredi <miklos@szeredi.hu>,
        Christoph Hellwig <hch@infradead.org>,
        "Darrick J . Wong" <djwong@kernel.org>,
        Trond Myklebust <trond.myklebust@hammerspace.com>,
        Anna Schumaker <anna@kernel.org>, Jan Kara <jack@suse.cz>,
        David Hildenbrand <david@redhat.com>,
        Logan Gunthorpe <logang@deltatee.com>,
        linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org,
        linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
References: <20220831041843.973026-1-jhubbard@nvidia.com>
 <20220831041843.973026-5-jhubbard@nvidia.com> <YxAABm0BljO0aP2h@ZenIV>
From:   John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <YxAABm0BljO0aP2h@ZenIV>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N2ZOekZ0dXczOFcrWVdLdlFqVmdlbjYrNjRuRzFPK2dSK0RPUWdDS1RzSXBM?=
 =?utf-8?B?MHh6bUNFZmFHUFdYOHF2UkJXek5GOWgycEx1K214S2ZYM0JkbWUzekYwSWtK?=
 =?utf-8?B?a2JaaERUbXJ5TkJSQzBwL0xHcmlYbjVlV09jZldaakI4RkUrR3ZVZElOTWxm?=
 =?utf-8?B?SGZqTFZmcVpDTzcrL1FXWmVuM29VOHg1NmJzem9XTGcvNzZQYmM0MmdjcVB5?=
 =?utf-8?B?S1ladjVyYjR0Y25pR2RKVFVObzBIdlBFVVpSUEpObGkzeU5leTJYbkNWbmw2?=
 =?utf-8?B?SVpsc2liUnlsZ3EvbjhzNGxCUjdqVWhxWk1xRkxVL0tYL3JqTHRrTUVvMnlt?=
 =?utf-8?B?ek5PUXVoNmdqUmxRenIzWndOdGtjbVAzKzVtU1dZWHpYWmxxd2lKZ3d6VVoy?=
 =?utf-8?B?V1NsMkNYQjhHbytISElEOEh3REV5NGRVNVNIUU01bkpRdTVCcTdTRitFZ3Np?=
 =?utf-8?B?cmg2T0NTNzNFSmlxRndlQWxXSVd2M0JTVlhnRWdROXVjK3A5bGtoOC9iUmNy?=
 =?utf-8?B?UlM1VGJ6QWpIRFJOZlExZllMK1pTeEVxSVo4ZWFpYUZBR0p4TXNDZkoxS1M2?=
 =?utf-8?B?d1JaMjI0cTY2QmJHeWtzN2IzL1pXTU5IOCsxSFdvSXBxdVhob2lXUTF0VnRK?=
 =?utf-8?B?WEhlSEU3NW1iQVNTcTNibXFIUnhnMHRNQU1JaHhwV2wrSUkzcGZZOTljdDZX?=
 =?utf-8?B?OXRPV0QwRWp1dENPZjdwem1VMjRZWnpQOGoyRlpkVW9qMWhyNFhZTm0xeUxM?=
 =?utf-8?B?bHRVZVpQUkxCaXluczFkRmp4OFFVNmxLaVczMkE3MFhlU1F5UXdVaFh5TXoy?=
 =?utf-8?B?Q00vOTJHeDZSZFpIYzFua2pCZC9FZWhmOUUrSHBTbjMzajNaY2dGK3ViQVdh?=
 =?utf-8?B?SXNtNTdZWlVCMmVJNHlKTUpnZmNXMk56OExsMGg1N2xzOGhtdklpaXZZT1BH?=
 =?utf-8?B?OHhkWFk4ZTg1RUdOWjZtTW40eEZvY3B4OVdlY3c3K3hhaGVsdUtkK3dWVmkz?=
 =?utf-8?B?Yk5ReVE3eXVyVytlQVJ4Y0VDNGlxQkVlc3FERE9ha0xYckZZcWQ4ejNWY015?=
 =?utf-8?B?NjRSeERBSmNQYzliS0dQeTRYNVg1R2RMSjZ4NlltbS9PQUJZMSsrTU9iVGxU?=
 =?utf-8?B?NWhDVGw0VE9IWHR3QjU5dFZjSjNzZzNRYWJMSzFKZGZVNXFXemZNV0ZDdzdG?=
 =?utf-8?B?ZjBmVzh2Q01JcGN6QXowai9sSDhuanlTdG9oZTRsYmpuK1IvODB4NFNJR1F3?=
 =?utf-8?B?MW5tdG5Ua0VvcjcrUHJKRExRYWIwMmR4QTR4VEhZcHVEQ2hGWVF0bDd1OGI5?=
 =?utf-8?B?SmZVSndRbm51UnhRVXppTThGUG5LWFZYZm9JK2Q0d2dFN0x4RllPK3FodTBP?=
 =?utf-8?B?MTF6ZXU2NEdWVVVXdEl1bXNvSXF5UmZhbzJIdnQvQ1lKM3RaMlp1aXk5NWZn?=
 =?utf-8?B?MjF5Vi96Z0c1Y292S2ZNNFBwM2thUG5YL3E4eE5qbUFHYXRqTndCZGJnU2hI?=
 =?utf-8?B?RVFpeVpsR2hiRXU2a3Bma1YzQzNMeVlhbDM4Nk1hR3ZTQ3YzQXU2bUlPQ1li?=
 =?utf-8?B?VjVrRWpoOFZSNHluSkhROG8yODhjNHR3bEkrNkdxbjVscklPMC9Pdkd5Y0FB?=
 =?utf-8?B?RTk3WmsrOGg0cDhOanVEUFJ6UUhyMU9YelBibTU4MVBhY0N1UTk2ZkkyNlBS?=
 =?utf-8?B?eVBCYnJZelVqMm1ZTXl6ZDc2bGlTRTVkdlluaTFPSEdYUG1sN28xUnA2SzhQ?=
 =?utf-8?B?YXZ5WVhwRnlSVE1JZEt2RjlpYkZ2QzBOeUtURTlXRkg5b3RreGFuWXVQaE5y?=
 =?utf-8?B?R0o4NDBXWUN6TmFSeXgyVkJpVERTdEpFNElFOHFybTZqOXZqc3psMzBTOEVz?=
 =?utf-8?B?My9jNndpaTZPV2dvdXlNY2Y1VW1tbWtuZklFalBHVWtuOUhpbm9YdElXUGxh?=
 =?utf-8?B?aDNBRkVKWnhIWWp6dVV1eTFEQWdjTkhCSGhtSlRZbG1yMjFTQ2ZqR21jWGJC?=
 =?utf-8?B?aHZIYnVlTDByaGdyUjJycmFOQnAva29MNzhYL0VBS0VNMlc0bnVnM0ZCWk9P?=
 =?utf-8?B?L29DMGxXY01VS1djL1hlQjZhbnpTMGZqOHN0YjNESEJ3OFIvWFdaVXhUaEVv?=
 =?utf-8?Q?GXvn4gCO7GGPo/t9MsjhEcO+c?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 37c7fd94-afc1-4672-e5bf-08da8bbc247f
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2022 01:49:00.9601
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UgKRqKy0uFpHxP461Q/qDdhM/DcNYhnPaHk5s93j89I/G5UW47vkbNWV/RlDehWyL+88NXFZ6Ec3VRSoBTiDsw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4376
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org

On 8/31/22 17:42, Al Viro wrote:
> On Tue, Aug 30, 2022 at 09:18:40PM -0700, John Hubbard wrote:
>> Provide two new wrapper routines that are intended for user space pages
>> only:
>>
>>     iov_iter_pin_pages()
>>     iov_iter_pin_pages_alloc()
>>
>> Internally, these routines call pin_user_pages_fast(), instead of
>> get_user_pages_fast(), for user_backed_iter(i) and iov_iter_bvec(i)
>> cases.
>>
>> As always, callers must use unpin_user_pages() or a suitable FOLL_PIN
>> variant, to release the pages, if they actually were acquired via
>> pin_user_pages_fast().
>>
>> This is a prerequisite to converting bio/block layers over to use
>> pin_user_pages_fast().
> 
> What of ITER_PIPE (splice from O_DIRECT fd to a to pipe, for filesystem
> that uses generic_file_splice_read())?

Yes. And it turns out that I sent this v2 just a little too early: it
does not include Jan Kara's latest idea [1] of including ITER_PIPE and
ITER_XARRAY. That should fix this up.


[1] https://lore.kernel.org/r/20220831094349.boln4jjajkdtykx3@quack3

thanks,

-- 
John Hubbard
NVIDIA