Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2df6f1fe-c8eb-d5a1-0a11-2fd965555a33@oracle.com>
Date:   Thu, 1 Sep 2022 18:56:12 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.13.0
Subject: Re: [PATCH v4 2/2] NFSD: add shrinker to reap courtesy clients on low
 memory condition
Content-Language: en-US
To:     Chuck Lever III <chuck.lever@oracle.com>
Cc:     Jeff Layton <jlayton@kernel.org>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>
References: <1661896113-8013-1-git-send-email-dai.ngo@oracle.com>
 <1661896113-8013-3-git-send-email-dai.ngo@oracle.com>
 <FA83E721-C874-4A47-87BA-54B13E0B12A3@oracle.com>
From:   dai.ngo@oracle.com
In-Reply-To: <FA83E721-C874-4A47-87BA-54B13E0B12A3@oracle.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SnZ3bGkvRi82SUdiZWYvQTBDUXkzZFVhVEowOXF0RkNnLzNWSzVhcGo0a25H?=
 =?utf-8?B?UFhLTy91RkxNcTQ5V2NtK0toZTdLay9KclhROXFWdURxbGxOdVhualJUeG93?=
 =?utf-8?B?M0RRamg2amlvZ0hFZHBqS0w3NmlvTXdzbzF0RERqck9lbUFLZlZDTjRDeVlq?=
 =?utf-8?B?RE5iTENDa1dQZTFtMmtNQVJudEk4MUROazNqdjI5OUtDYnhyUHBJRzNuODhl?=
 =?utf-8?B?R25CTG9UZmRQbGtsUU4zVUFpSTVpVjNuek5CSFYralp6T2NHa3duTjJ2dWZk?=
 =?utf-8?B?aGhwWDAzWnVnVXpQc20xRTdmWkNZVitZVGJxNzNkaGVxa2hsbU92L3E1TlRy?=
 =?utf-8?B?SklYZVErbWVtYzFGTnpEZHBEQmJRQ09udmFGRXBhYytocXpGeVFyODlkOUg5?=
 =?utf-8?B?cGFuM0EwcXFKQVlpQ0JyR1ovd3JqM3RtTnIxK2RTTU4vMXl2UGttb1dUakk5?=
 =?utf-8?B?T3BwTi9CbExscTZPV2oyTkNBRmVRUnJVRmdjbWx0cC9RdXNBaXk0ZkpUeVE1?=
 =?utf-8?B?NjhRNzVjK1hsazBuVURYMXFQMDMvTjdUV1VTWWdWTWdKcUIwaXZxc2lsUWtk?=
 =?utf-8?B?Wjg2Vno0WDJ4MTZJN2xiWWdzL2c5S0NPQ1JycHRNN2ZXZHBuV242aEx3bUZp?=
 =?utf-8?B?aHA3WTFhOXpYbGFvRnhwcUhaQzBsZEJDa1VHb1lMRmMyMWZaL1dGUXR4TWVx?=
 =?utf-8?B?NnlCV3dqa1ZOUHZ0eHZwV3FHWnozYms1UzhUaSs3VTFCeGw1djl5bXBUTnA3?=
 =?utf-8?B?RWhpZnBBSzZZaUNFSTZCb2NoMEp3T3ZuNlh6MGpPSk5EczZUUjVTNFhGMVVx?=
 =?utf-8?B?OXN3Wkdqdlo1N0U4cFF0bVRQTGZwWEs2dlQvWkREVHo2YTZKQXp3V0lhMXFJ?=
 =?utf-8?B?ZStxSzNQNUlkZjJBVm1kSlZGNS9IVEQ5TXdLUktZM25vc0h2ZnQyK1o5K3Ro?=
 =?utf-8?B?cENvc1dqRWhqTy9vUlJlWk4xUUtYS09PRE1xREF0YWkxMXRwK3hFYnVqMXc4?=
 =?utf-8?B?U1BJMGJuaGk0QVBYVFdHSWJxenRsMmswUEhYNGhiU2hqWmxMcENIZUZVVEZm?=
 =?utf-8?B?cXNOV1ExUE8xTkxkM1RCcmVzVTA0eXQ1UWNjOHZIcmZiUHdaOXhFSmFwaTln?=
 =?utf-8?B?VkVJUmhZcWhGYmhQdnEraERoa0xINDVzYVZMNVhmSUdDWFdOcWJFSmZPbzFS?=
 =?utf-8?B?QzdSYTUwaE1QTWNVNzJHU0VGbGVSZVNXa0F3VHhRUTFQNDBESk9tWDZFOXZ6?=
 =?utf-8?B?Tk1qNldQcW9oeUp1V2dmT1dnOGo2dGtZcGtmM2p4SnhaN2Y5UTAvekE4OGgw?=
 =?utf-8?B?UjliTzk5SnBrd2pnQmJpTThoTVlzWFhIK2E4OTBRVEQxQ2N3cXhaeHJvbk5M?=
 =?utf-8?B?SG9RcHM5MFpKT3licDNQd3BpRjhjY1Exa3FzM1c0R1U1dXJGeDdCYWppaGdG?=
 =?utf-8?B?WlY2ZFN3RmxrSjVRaHVxL0JKVE1vOHVXTWdVbnREVmJ3M3MrbE9xbVhIeEtk?=
 =?utf-8?B?SEFPVytNRldvY1lNVUZhbWo2bUN5ZEs5TVlHQU54QnNwdDEvaktjTFRPdEsx?=
 =?utf-8?B?RzVNOGdPWWNXZTNHaWlnbGZtOWEwUWUvRmN5ZzI4bFJWZmEzY1hOcHdYdE8w?=
 =?utf-8?B?OFJtdGlNRyt5TnNibDlsZ2FyUFZMQVV4czh4QTUwTW9VMW0vNGpscTNXQVpT?=
 =?utf-8?B?MkdWNEV5dlltbUVtaUFFWHZrWUJPQVRIbDNPbUdiREdRa3ZGTzUvQithR2U3?=
 =?utf-8?B?enRzV0lSSmZmMnM2M1JDQ2hwdDVXTE5QenJpVmRiMVE4bS9RODlQMzVXV2M2?=
 =?utf-8?B?WEc4eDkvcUxPYWFUQkZVNWh6akg5dVpsWlh0MG5kMm15VnR3KzVWZytiQ3g3?=
 =?utf-8?B?K0ZGRVlNRk94MkphMVVFYjlvVlR4VzF5N04wVGcrS2gybzgzcFhQYmJmbzVO?=
 =?utf-8?B?YjFMZURRSk84SnVpTTJvTVN2NnlJcHVnQnlDSE9UZTYwRXpJTTVpYjBaWUNI?=
 =?utf-8?B?NHcvZTBUNFp2VVc4c3l0dm94YmpqRWNHeDh0Y3BoVnd0NWlhZVh3QlpwUTNX?=
 =?utf-8?B?bEdtNll3d3ZYR1E0TlRGYmpPR3pnVEdFUGxpZ1V0YXJxU216am1hdERUY1Fp?=
 =?utf-8?Q?a3qfIdEYOFRBxSGLKNxTTbWgK?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3eb06967-d6ac-4c69-ea59-08da8c86520e
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4257.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2022 01:56:15.7811
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cUffodk2ZEQfiE1hL00t2WZnVIqLPOKAAxYOTmbPanZLkFIjrfCWhScm9bT0dkiC3tSCrqHHxOZymqKxp7nKZg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4585
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-09-01_12,2022-08-31_03,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxscore=0 malwarescore=0
 suspectscore=0 spamscore=0 adultscore=0 mlxlogscore=999 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000
 definitions=main-2209020007
X-Proofpoint-ORIG-GUID: Gey5WWugZ8uSZC4I4EPQ96eFoSXRL5yg
X-Proofpoint-GUID: Gey5WWugZ8uSZC4I4EPQ96eFoSXRL5yg
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org

Hi Chuck,

On 8/31/22 7:30 AM, Chuck Lever III wrote:
>> 	struct list_head *pos, *next;
>> 	struct nfs4_client *clp;
>>
>> -	maxreap = (atomic_read(&nn->nfs4_client_count) >= nn->nfs4_max_clients) ?
>> -			NFSD_CLIENT_MAX_TRIM_PER_RUN : 0;
>> +	cb_cnt = atomic_read(&nn->nfsd_client_shrinker_cb_count);
>> +	if (atomic_read(&nn->nfs4_client_count) >= nn->nfs4_max_clients ||
>> +							cb_cnt) {
>> +		maxreap = NFSD_CLIENT_MAX_TRIM_PER_RUN;
>> +		atomic_set(&nn->nfsd_client_shrinker_cb_count, 0);
>> +	}
> I'm not terribly happy with this, but I don't have a better suggestion
> at the moment. Let me think about it.

Do you have any suggestion to improve this, I want to incorporate it
before sending out v5?

Thanks,
-Dai