Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1636a540-2115-0cdc-aeb3-236fabd78ccb@infradead.org>
Date:   Mon, 5 Sep 2022 18:56:19 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.1
Subject: Re: [PATCH] fs/nfs/pnfs_nfs.c: fix spelling typo and syntax error in
 comment
To:     Jiangshan Yi <13667453960@163.com>,
        trond.myklebust@hammerspace.com, anna@kernel.org
Cc:     linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
        Jiangshan Yi <yijiangshan@kylinos.cn>,
        k2ci <kernel-bot@kylinos.cn>
References: <20220906015027.3963386-1-13667453960@163.com>
Content-Language: en-US
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20220906015027.3963386-1-13667453960@163.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 9/5/22 18:50, Jiangshan Yi wrote:
> From: Jiangshan Yi <yijiangshan@kylinos.cn>
> 
> Fix spelling typo and syntax error in comment.
> 
> Reported-by: k2ci <kernel-bot@kylinos.cn>
> Signed-off-by: Jiangshan Yi <yijiangshan@kylinos.cn>
> ---
>  fs/nfs/pnfs_nfs.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/nfs/pnfs_nfs.c b/fs/nfs/pnfs_nfs.c
> index 657c242a18ff..45a5a66a2e3e 100644
> --- a/fs/nfs/pnfs_nfs.c
> +++ b/fs/nfs/pnfs_nfs.c
> @@ -374,12 +374,12 @@ pnfs_bucket_search_commit_reqs(struct pnfs_commit_bucket *buckets,
>  	return NULL;
>  }
>  
> -/* pnfs_generic_search_commit_reqs - Search lists in @cinfo for the head reqest
> +/* pnfs_generic_search_commit_reqs - Search lists in @cinfo for the head request
>   *				   for @page
>   * @cinfo - commit info for current inode
>   * @page - page to search for matching head request
>   *

Since you are changing the Returns line anyway, please use the documented
kernel-doc syntax for it:

> - * Returns a the head request if one is found, otherwise returns NULL.
> + * Returns the head request if one is found, otherwise returns NULL.

 * Return: the head request if one is found, otherwise %NULL.

>   */
>  struct nfs_page *
>  pnfs_generic_search_commit_reqs(struct nfs_commit_info *cinfo, struct page *page)

Thanks.
-- 
~Randy