Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2a0dbe25-f2a6-1aaa-8741-1956d06cde60@nvidia.com>
Date:   Tue, 6 Sep 2022 00:12:29 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.0
Subject: Re: [PATCH v2 2/7] mm/gup: introduce pin_user_page()
Content-Language: en-US
To:     Christoph Hellwig <hch@infradead.org>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Jens Axboe <axboe@kernel.dk>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Miklos Szeredi <miklos@szeredi.hu>,
        "Darrick J . Wong" <djwong@kernel.org>,
        Trond Myklebust <trond.myklebust@hammerspace.com>,
        Anna Schumaker <anna@kernel.org>, Jan Kara <jack@suse.cz>,
        David Hildenbrand <david@redhat.com>,
        Logan Gunthorpe <logang@deltatee.com>,
        linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org,
        linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
References: <20220831041843.973026-1-jhubbard@nvidia.com>
 <20220831041843.973026-3-jhubbard@nvidia.com>
 <YxbquGs0QN3BRw4I@infradead.org>
From:   John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <YxbquGs0QN3BRw4I@infradead.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VnVmT2VjeFRuVXBtNGhSekJUKzB3TGxaTjVRK2I2VjVMU3RsMS84cVAvVjE5?=
 =?utf-8?B?TjE5amNJK2NGdDJNNTI0MitXTUVRQURJNmdDOStoNUFNSHV5Q0xwRXl3RHls?=
 =?utf-8?B?c0FRME1FdmljT1BpUWtsQXRjeE5BNmxDM0lUelRtb2cyaEFaRlhmTXQ5VnVw?=
 =?utf-8?B?aHZoUVVHaDBtdXRmdUFMM2JFaWJhZVVoVDhRdjdxbDNSbGFFdS9xYWNKYTR3?=
 =?utf-8?B?TllLU0s4Wlp2MmE2OGF5bldPRHlRZzBaUm9Vb0RXOGtManptMTBiTDVRVjRH?=
 =?utf-8?B?ZmtRdTJkRnRWcTBhbFRQWERtRk9pTzZSUHh0eXFISkZrckhPVVIyOS9wYW4r?=
 =?utf-8?B?emlPTE5RK1VLMzloWHNPMk5xOEg2Zk5BeFVqYVZDZWYzV01yZXU0NlhvdGZj?=
 =?utf-8?B?RDZMRW95c2ZVaytRVXR2YW5vWkdwKzlpdC8yTVlGdm55ZjI0ZFFYeUxReE5i?=
 =?utf-8?B?ZHVmcmFjZHVjMEsyYm8xZDJ1NVdVYnowOGdYM2pnaGJIM25rVVNtYUs2YWNQ?=
 =?utf-8?B?Z2NnWlJSTVhBSGQ2ZmJVR2hsMDE4WEZGcUR1c0grR0U4c3F4QWgxWVVqaTRW?=
 =?utf-8?B?QTdreThwRHlMY0pYTjlTZ3pLUGpFeW1jaCtUNXdpVE5Gb1RSSW9qKy8yWUdq?=
 =?utf-8?B?MHA2Q25kdElXVXFpMjA0M3l3ZWhXQkRqejgwdDdHRVFiUnVhZjk2Q21qaTg0?=
 =?utf-8?B?UmpyVkZUSnh2L3Vuem1yN2RyNFBSbHptMGNTUXZjWGdneHVKaDdMM2VodWV5?=
 =?utf-8?B?dFY5SUJUTCsxTG16V3EyWm1rMVA1eWtDTjFjcE95dUJxck1HWE1zeEpIQzJ6?=
 =?utf-8?B?dEYrTjdGTEsyQ1V5eG00RUpJRnVjdlJCd2NNL3BzK0J0Y0Qrb01yMDkzeStp?=
 =?utf-8?B?dWtkYWR6dmhNL0NVUkg0SVIrZk1QNWdlWVUzZGRvN2g2YzJEVDVnSkp6SU92?=
 =?utf-8?B?Rml1NmJaRkFrOTFmQ3AzQVdwOGFGZExWcnFzUENzRmIvUmF3MG1DTlpvMlh4?=
 =?utf-8?B?MElISkFISXhQMkdZcXhiZnVYRDMyVlRsZzBTdVRSS2lMZ1hNODdtTGVBSnk3?=
 =?utf-8?B?eFNDSVFoWHM5d25ONTJDcDlNanBCblp1ZnpHaDVWcHlFdHNnYkFqUzVQb3ln?=
 =?utf-8?B?YnpDT1lmaGNObThaOU1HaVVBUGtWQ01tYW1WNXJBT08vTHR1djBudHV4TGNx?=
 =?utf-8?B?SUJqbWk2N0pmNU0rYkxWOGZsbklFRzZNTyt0QnBjY2d2V0pKQnZhQ1JhVnEx?=
 =?utf-8?B?Y1RrL3N1V2pRWEk3OEJqSERxZ1JaMjluYWFVRXpNU21xNi9QUzhSQzR1ZHlO?=
 =?utf-8?B?S2hQbEdsem9POXVSN2QrY2Irc0pTZ0RDa1hJSlV1eU9BYm52VjZhcTd2amww?=
 =?utf-8?B?aElKTFB5M1I3WVZiQ1p6eUNoZzBZaTdLdVFtM2Y2YTRCeUxzZUVFSUQ0WDUz?=
 =?utf-8?B?djFpSGlMVGxqSmNFbkNiN2FxclNqTE1lamNCMktycHBQY2tEVWVXSlFXanhk?=
 =?utf-8?B?MGFUM3hDUmpBRFduTlhnblZyOEl1cVd4c0UrZzZDZzVPWkliYk1iMURDMFBP?=
 =?utf-8?B?Mk1GaTJBdlZ2S2RZdTQrWEkyL25vNFBYd2FZUDliRk12TVp5M01kemZtWE90?=
 =?utf-8?B?ZE0xTDdzeWpwcTRDRHZOMHlMRWppTkdTeFNFQ0VhaG4zVS9ic09DR0pkNkxs?=
 =?utf-8?B?RUlNdFRqZTgwK2tybHJrczEzQkl3S20veGxtVnFFSGxkYzY0OHZwV0dzMUxG?=
 =?utf-8?B?R3U3OEZzbEZWVHhIMG9CT1h6eDR5OHF3MDAvRVRUOVNNcHZRbUNNZG5rQ0Qy?=
 =?utf-8?B?eEhWUGJ1b1RqRERTZVMxNDlyRmwzRFZCNDAyNjg1azhhalBHVzc2KzNSY3ZN?=
 =?utf-8?B?NTE0U0R0WnhMNjhndy9xVUFwVlVIMUdQU1VoNjk3TUJOKytpNis5TjZES1JL?=
 =?utf-8?B?MUxWcnNEaiswVWRNdjRLTWdDeTk4NndsQmdWVDVwYkVSZWNtbVVZc3pKZ2JQ?=
 =?utf-8?B?aHdxSWhKTFpLQXh0SkN6S3J1akFtSytvR1UrOUp6bGdMY0plSjk3WHBzNUhj?=
 =?utf-8?B?emdZMnBHWWl6MjJFSnVWSi9zTllWNURZN1pMbDBoOXJjRkMveHZEMWVPdDcx?=
 =?utf-8?B?MEt4RFlTblpzbytmRVVpcXJLaWZabTJyUVo2MFNZaG10RG5vSTljVHZ6dFNk?=
 =?utf-8?B?VHc9PQ==?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d8f41250-2fdb-4886-fbd2-08da8fd72b1d
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4140.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 07:12:33.2034
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hdr23n6G6hcMTBPdV6gD3BecIl1WTmtnf6uVphHwzLuGo38ImxGwit3QyIp7cZ2DygAXwSqITgp+GQKYyEONxw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6124
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org

On 9/5/22 23:37, Christoph Hellwig wrote:
> No need to export this, it really is an internal helper for
> the iov_iter code.

Agreed. I'd fallen into a bit of a habit, for gup APIs. But this
one has a much more limited and special role, yes.


thanks,

-- 
John Hubbard
NVIDIA