Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ebdbc31d-68a3-e168-7344-6b1e3aa86e28@nvidia.com>
Date:   Tue, 6 Sep 2022 00:37:00 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.0
Subject: Re: [PATCH v2 0/7] convert most filesystems to pin_user_pages_fast()
Content-Language: en-US
To:     Christoph Hellwig <hch@infradead.org>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Jens Axboe <axboe@kernel.dk>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Miklos Szeredi <miklos@szeredi.hu>,
        "Darrick J . Wong" <djwong@kernel.org>,
        Trond Myklebust <trond.myklebust@hammerspace.com>,
        Anna Schumaker <anna@kernel.org>, Jan Kara <jack@suse.cz>,
        David Hildenbrand <david@redhat.com>,
        Logan Gunthorpe <logang@deltatee.com>,
        linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org,
        linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
References: <20220831041843.973026-1-jhubbard@nvidia.com>
 <YxbqUvDJ/rJsLMPZ@infradead.org>
 <50d1d649-cb41-3031-c459-bbd38295c619@nvidia.com>
 <Yxb1GKaiVkz7Bn2K@infradead.org>
From:   John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <Yxb1GKaiVkz7Bn2K@infradead.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N0Z6TlVPVkdvYllJbVZGa0JKaHlBYitsZlVwclZEYm5NTmhZR0QxMEYrRm5W?=
 =?utf-8?B?YkczVkVMSzlaV3BCVmdudFFCWVg5c3Byb0JnTzRkaFd3a041NWNPRG44Nm42?=
 =?utf-8?B?RDE1Yzg0d2hDNWFKdjUwY1RwUDFQcHhzWmZNVjU0c1p1L0N2d1ZRdklncUZv?=
 =?utf-8?B?NUVQUTlNa3NGRDBETWdsYlNpdkxPRUd3RDdmOGUzUE1zaE9YekpGS0E3RzVY?=
 =?utf-8?B?TEg1aTVsa1NydmExZTd2NEp2b0lEa3NXVlR0RUx3Zk1CbG9FOUJuZE1XU0Vl?=
 =?utf-8?B?TzRoR2x3U3FTVFlaR1dWeURZaG1iOXl0ZXJ1RFZyb2xWa0FIdWJQWXp2SzY2?=
 =?utf-8?B?RENnWGlyNGpwd0ZzNFZiN3hJbE9pSjJ2TWlJUUJlb0QwblgwbFVLbnVGU0hM?=
 =?utf-8?B?T0h4TmJONGs5S1hBQnlOQXRINERzRkZ5bUw5OTcvb0JQRDg5d2E2SHN0blhi?=
 =?utf-8?B?WVlkWDh2YmZTZGQyNHY2S29ycFBWNVZNNEpBc3NuY3pvUGJxY3Rxekx5STFq?=
 =?utf-8?B?RTczSGs4enNpc0l2bFk2UlJGUlRBdWZ0Z09uUFllTVA3NWZXSHR5MjA5Snlh?=
 =?utf-8?B?ZzZkRWQ1QW1GWlVySmtkYTJMcHJmanVsN2NNUmR1bGRUT0IrdzdHN3AvUElu?=
 =?utf-8?B?dXJzSVd2cTY1MUxRU2psVnBjZ0kveXdhSHJJZWlvdjEybnliQm1qc0NLTHNn?=
 =?utf-8?B?YTYrcmJPcHZnek1vTXNad25NZWlyS0FmRjRxaG80aDVoOGt4R3h3UGZEck03?=
 =?utf-8?B?d2psWUJPdU5ZelMxVnpzdlJjTW54ZTludmthaHZxRHhlZWQycHdSRlJobXJZ?=
 =?utf-8?B?bUZOSHh2MUtaSzZPTXc3c3pjOUF5RkkzaHNDY1V1VWpWOCs4RTNvNkZVcWVp?=
 =?utf-8?B?TkxmQ09DaVBGNkF5N1NadExOTnJJTkVEQ3NrNStsVGptVDk5Z3lqY1lGa2FJ?=
 =?utf-8?B?WXgwYmRtQnBaRW5WY2J0SUxOUkRvSDZOWlYwQXV1bStxNkM4dXpnNWZqNWlh?=
 =?utf-8?B?WStJVVFBMjRhZVFQM0tMRXIyWU1zVWpyTkJPY0lQc2JQSVJzS3NXRkZZRzJD?=
 =?utf-8?B?UFZzNVRyLzRQQ3NvUzBlb2lteHVsNVNiRlYyanh0eVpUM210MHRyVlc4U1Fa?=
 =?utf-8?B?UkxkWGNUUEhYeUtINHhRYVVGYjJQRnJtRFFYbWx1ZlZCS1BaazhDYjRlNW1v?=
 =?utf-8?B?amF0ZHBySU1EMlFCc3lObFZHUCtKZWx2b3pzdUNMcHY2eGpqR0JIUjlWd2U3?=
 =?utf-8?B?NGJIWmZwNmh0bU1tTG9aWXRwSE42YTdRWjBiZmQzMzFMR0cxM0FPdzRGNksw?=
 =?utf-8?B?L2x3VVR1YkpZdXR2TXNyL1IzWS9XNGZJeStEdTBtSUN6RUh1UzJKd3NLbXJR?=
 =?utf-8?B?TTExQkF0cjlVYjA4cWZIZFM1Y3BmSUNQWnJ2ZVl3aTh2WW1tczJUbzA2cnl5?=
 =?utf-8?B?TStqTnNIUm5IUXFiMmMrbUdqVkVnaXdPcTZrMnFrcUplY0EycWdiaDZycm1J?=
 =?utf-8?B?U0lYOGMzQXJKSXkya3h0RXlzN1B6K3MxTGxUYkVNcTNQRzByREZZam5TaHBp?=
 =?utf-8?B?VHBHc3hvSzVjclAzdVgweW5DRDZhSHp4UE1HaDJkZ1Jtc2J0YXJHTldBUC9s?=
 =?utf-8?B?WkRMSDVmWVdTSUVKUzZQaFRWazZMd05HZHhsMFpLeTFUVUFiM01GUGppeVN1?=
 =?utf-8?B?aWdqUkhHaEswNUtVUzRmYzQwQ3BOS25UdThkdVdnY2dENUFBZHV6RElKRnFi?=
 =?utf-8?B?MTRzemwrSEY3dlpVaGdXYzJ5MnhnTTFRdE1IbnkvR3kwSDl3SXNIMHFEWXNn?=
 =?utf-8?B?U0x5bStodHJSVHF0dDV3QjBsVk4rc09FN3BQamdiQ1NpcTVTY0ZFMHB4cXo5?=
 =?utf-8?B?dFdQWW1ncUREa0NlRVBqK29VUVNSRXdYYkoxeEcrUmFhbnorWmIyT0s1aHpR?=
 =?utf-8?B?T3RrNGV5TEVaNytVRVZyaGZRdlI4bUxZRGFNaWdSbEVGWjFSUnNraFBIekg0?=
 =?utf-8?B?Sy9jLzk2TlZlSG1LV2pvcmlQK0tGc0l1RnFENm1YamVvM1BQTzVwM1NHTmZD?=
 =?utf-8?B?aG84Z3NKVjg0UmJNazFQaHExT2pPdXI1bzdiOVEyVjA3VFp5b00yWjZ5TmtG?=
 =?utf-8?Q?Sh+uuVbSrIjZuCyYz3aqJNxKd?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e4cfde54-9b18-4fc6-3dbc-08da8fda97ac
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4140.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 07:37:03.8199
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qi9QjPN6NZsEzMSsdY/k335XkAEXnmeJ02G7Cmr7fBq/GMWXHMOsh6zXsv93KtTOXp8KDxuC2yUirQjCzDFzYA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5995
X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org

On 9/6/22 00:22, Christoph Hellwig wrote:
> On Tue, Sep 06, 2022 at 12:10:54AM -0700, John Hubbard wrote:
>> I would be delighted if that were somehow possible. Every time I think
>> it's possible, it has fallen apart. The fact that bio_release_pages()
>> will need to switch over from put_page() to unpin_user_page(), combined
>> with the fact that there are a lot of callers that submit bios, has
>> led me to the current approach.
> 
> We can (temporarily) pass the gup flag to bio_release_pages or even
> better add a new bio_unpin_pages helper that undoes the pin side.
> That is: don't try to reuse the old APIs, but ad new ones, just like
> we do on the lower layers.

OK...so, to confirm: the idea is to convert these callsites (below) to
call a new bio_unpin_pages() routine that does unpin_user_page().

$ git grep -nw bio_release_pages
block/bio.c:1474:               bio_release_pages(bio, true);
block/bio.c:1490:       bio_release_pages(bio, false);
block/blk-map.c:308:    bio_release_pages(bio, false);
block/blk-map.c:610:                    bio_release_pages(bio, bio_data_dir(bio) == READ);
block/fops.c:99:        bio_release_pages(&bio, should_dirty);
block/fops.c:165:               bio_release_pages(bio, false);
block/fops.c:289:               bio_release_pages(bio, false);
fs/direct-io.c:510:             bio_release_pages(bio, should_dirty);
fs/iomap/direct-io.c:185:               bio_release_pages(bio, false);
fs/zonefs/super.c:793:  bio_release_pages(bio, false);


And these can probably be done in groups, not as one big patch--your
other email also asked to break them up into block, iomap, and legacy.

That would be nice, I really hate the ugly dio_w*() wrappers, thanks
for this help. :)

thanks,

-- 
John Hubbard
NVIDIA