Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp95187rwn; Wed, 7 Sep 2022 13:04:26 -0700 (PDT) X-Google-Smtp-Source: AA6agR6yB8Vq7BE4U3IcpSAsjHmuF8n/G9vBLEI8nQEBq1JDSrx+oMAP1yqVuDgM5MPktWS2PUX4 X-Received: by 2002:a17:907:6ea7:b0:731:7ef9:dbfa with SMTP id sh39-20020a1709076ea700b007317ef9dbfamr3635179ejc.146.1662581066209; Wed, 07 Sep 2022 13:04:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662581066; cv=none; d=google.com; s=arc-20160816; b=fgtGOoPSk2urLwjnoaj+L3HG7kvYhw87lHYVnWXLB2oixCmoIqT1FF1z0SWJBpyAHF yOYXROqPH4JU8zp8JZsLT6wLRDYFA0f5hZBg+p2jQlgjMtZ1rPZSsrbmkUzuXm3mvxO8 mNxRK61nzAx/1B1tocPY1f/Quz0m1QsePwMTihQ2frfF7dZ5GBAHmOGcO+YYAbdbXGDU TxDL2OJRdTk6ms2dfG/gNcp7s1juc+PYBwVSHBK+S79emedqLysxaKkY69/OPAN3VGWC F6xTkEfvHs2SihP2mHk415s0CJIJiLIeejwBeBamuDiHZQh1ufWeoeYbJpzaoaiFzFqa SQfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=78Zyr5MiT7L8tJdukrJguBqw48w2c4ZSIubjcLcmGvU=; b=de6TgccvZVPocyqLh12w8rotKM0ROYt7iIG6UOZOzk4Il5bxutCymKZjw7tOKtYuno 7qWHXycQKo4CSm7Jr+rAELX9zfeXxpOXxEtE/qAXTI7PTa6idBQIb130/R+6d8FfnUyY YMTLfpundVVRGpshLI0pCF83bJVp8XHM04w8KWnoUCb9vpitggOHtRawHbtND9zPG9mQ WF7UCbBY637yVOofvLR8fFhQhRX5sOox/ha0CkreMG0/8vS+0q/IsB6foxcMCTgIGSfA d89EK9djOcG/IEFLoH+LidX3wuMLHXG0QFap2mdmCyCmBtyoVjDKuH9Fj/aupefRMp0G PgxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RPAlfFqt; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qb14-20020a1709077e8e00b0074171cca40bsi254803ejc.962.2022.09.07.13.03.51; Wed, 07 Sep 2022 13:04:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RPAlfFqt; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229616AbiIGTxD (ORCPT + 99 others); Wed, 7 Sep 2022 15:53:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229484AbiIGTxC (ORCPT ); Wed, 7 Sep 2022 15:53:02 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1917EA0275 for ; Wed, 7 Sep 2022 12:53:02 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A090A61A47 for ; Wed, 7 Sep 2022 19:53:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A403EC433C1; Wed, 7 Sep 2022 19:53:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662580381; bh=V4yv7dijgNzhXkL1MIX2F7iHRKG9A+VoeBZjdiMkQqk=; h=From:To:Cc:Subject:Date:From; b=RPAlfFqtXRyBOYh+0JaOQdB6qYywW4C4WVX3uBlCo5tX1awTYSfsBiO71X9jIByR5 Q38t2pDgLa5dqAWH+uIif1bVerlS2c+GJE9SfFAZlXOdgx3700vHlGTamUDO1WZ2sl +ureamk0xkCsp+ZwW7Jk10Zqlj/nQp9DK27k3jZJhxkcT4JKCETq1qiMRKniXQHecC Pg/mPhzE49EH919l6BwPJiEqMgrd5Z78uWUuzupWUK6UF+Q013RvqydHJQFg3T3IUR nRzy0Mv7t4nN+vcSfMvApBQEjM1J4TAHSda/nHh7/9UB02Xux41hPuYp8+HeysS06/ NzbdYSeoGBPDQ== From: Anna Schumaker To: linux-nfs@vger.kernel.org, chuck.lever@oracle.com Cc: anna@kernel.org Subject: [PATCH v2 0/1] NFSD: Simplify READ_PLUS Date: Wed, 7 Sep 2022 15:52:58 -0400 Message-Id: <20220907195259.926736-1-anna@kernel.org> X-Mailer: git-send-email 2.37.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org From: Anna Schumaker When we left off with READ_PLUS, Chuck had suggested reverting the server to reply with a single NFS4_CONTENT_DATA segment essentially mimicing how the READ operation behaves. Then, a future sparse read function can be added and the server modified to support it without needing to rip out the old READ_PLUS code at the same time. This patch takes that first step. I was even able to re-use the nfsd4_encode_readv() and nfsd4_encode_splice_read() functions to remove some duuplicate code. - v2: - Add splice read support - Address Chuck's style comments - Reword the commit message Thanks, Anna Anna Schumaker (1): NFSD: Simplify READ_PLUS fs/nfsd/nfs4xdr.c | 139 +++++++++++----------------------------------- 1 file changed, 32 insertions(+), 107 deletions(-) -- 2.37.2