Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
        Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
        Kingdom.
        Registered in England and Wales under Company Registration No. 3798903
From:   David Howells <dhowells@redhat.com>
In-Reply-To: <CAFX2JfmoovJHUBRy6U=yKJt_pAEF0tLadSK+CFqabPcatXe6EQ@mail.gmail.com>
References: <CAFX2JfmoovJHUBRy6U=yKJt_pAEF0tLadSK+CFqabPcatXe6EQ@mail.gmail.com> <166133579016.3678898.6283195019480567275.stgit@warthog.procyon.org.uk>
To:     Anna Schumaker <anna@kernel.org>
Cc:     dhowells@redhat.com, Al Viro <viro@zeniv.linux.org.uk>,
        Jeff Layton <jlayton@kernel.org>,
        Trond Myklebust <trond.myklebust@hammerspace.com>,
        Scott Mayhew <smayhew@redhat.com>,
        Paul Moore <paul@paul-moore.com>,
        Casey Schaufler <casey@schaufler-ca.com>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        SElinux list <selinux@vger.kernel.org>,
        Linux Security Module list 
        <linux-security-module@vger.kernel.org>,
        linux-fsdevel <linux-fsdevel@vger.kernel.org>,
        David Wysochanski <dwysocha@redhat.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4] vfs, security: Fix automount superblock LSM init problem, preventing NFS sb sharing
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3658627.1662669081.1@warthog.procyon.org.uk>
Date:   Thu, 08 Sep 2022 21:31:21 +0100
Message-ID: <3658630.1662669081@warthog.procyon.org.uk>
Precedence: bulk

Anna Schumaker <anna@kernel.org> wrote:

> > +       fc->lsm_set = true;
> 
> I was wondering if there is any way to have security_sb_set_mnt_opts()
> or security_sb_clone_mnt_opts() set this value automatically?  A quick
> "git-grep" for security_sb_set_mnt_opts() shows that it's also called
> by btrfs at some point, so having this done automatically feels less
> fragile to me than requiring individual filesystems to set it
> manually.

Hmmm... I wonder if cifs and afs should be calling
security_sb_clone_mnt_opts() also.

David