Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp1944897rwn; Fri, 9 Sep 2022 06:30:37 -0700 (PDT) X-Google-Smtp-Source: AA6agR5CYPQFzESqYVR3VUY95hTVxaQFYHjJhbUzQdxeUOVnIeIjLLsoYPfT3Lc44WQy928RtDex X-Received: by 2002:a17:903:32d2:b0:172:66e4:ba68 with SMTP id i18-20020a17090332d200b0017266e4ba68mr14370738plr.116.1662730237620; Fri, 09 Sep 2022 06:30:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662730237; cv=none; d=google.com; s=arc-20160816; b=N1MF9MYhH5+qiQRaUEcqqp2K/oh3FwJkEq/uwx0UD5Xbn1rBBT+Zek2KYWVKCw5dlj fBTnp5A5nrY287SwH1pJENS3i5RYbWOvbqluxg6B1xwdOmwf7VJ6SxrvpXkO7ZbZJBxA xx8+YGN4asFjsJfWLWt+bfJTk48B7J/uvL9W5QDjNburt2jMdxWvp/qaY+gq+LCIk+0T N/M/bBXsunEU0MtYb27px5hLmo71vYSflHbi+DmpNt6t21BKVk5oeTO9dotkCPFN8L6i RjKUrBkdWisuUJtzJbzpEfrxDa2vVosjhyNFOtZxR992URHct+ZMVpvM2A1F895tpd8M qdGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=IEnyzP6QTHsSqExzVUdTq57V2BNxCpUBqDnnf0HInY4=; b=CMxr+7ef3WfKUm1H9ziX7Fnm/gTxfyKTm467L7uTpFLopa58qFTeTHVMR3JfHpUdNM b3tp45xeqG5F93x/q2XUDNq2j0oxX7W8MQfYcgkrEaW7AJJm4NkHkR5RAVX4o/YPnh2f 9KfDdyg+725d1R6Kzd1wPGVIHDksqT6gkaLdk/07z/QGtWOhW5I1L0MlYxO4ujorTsNb 3yURjG0SJUBdmknvGy+dC2jfHJzLY12JFvRWv7Whn6/xz+k4Y8f7yonwX5nPI25WP9uZ EFzKVoRc8DuljVOWtnRAomVBxnCH+Yy8ZkuK/t6hUeVQAEboaatsqtQ8vyvmNmVDmzXB r3Eg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=1oJXTIET; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 187-20020a6305c4000000b0043520c52fbcsi594549pgf.229.2022.09.09.06.30.23; Fri, 09 Sep 2022 06:30:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=1oJXTIET; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231219AbiIIN2N (ORCPT + 99 others); Fri, 9 Sep 2022 09:28:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231226AbiIIN2L (ORCPT ); Fri, 9 Sep 2022 09:28:11 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 092561398A0 for ; Fri, 9 Sep 2022 06:28:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=IEnyzP6QTHsSqExzVUdTq57V2BNxCpUBqDnnf0HInY4=; b=1oJXTIETXtfNCKfGGbg+V7CpUg SQARvrvbmOwOuKAmdj2VqQ9Wdo3VNTuToDm7tnjAZVySSfiVxn9xKUhlIlhgZ1E0MG40IVk7ZZses XKCuqfzxOEERqEhVVp0fX1tGwjwayj7qkdp2JXJ8ellfh5gIdR8gclpfWbkP+vBSnvBrpIiBQJQZH HMIQU/PA3bCofjcKV+6xsBhIUxd1ICWOK1vhOD7orcTgxx8DbdAlaE5i+9FX5lfFJSDvAjBcTEdfG rFO7qPKViE4FGDDEJy9ZfTGxHK9sKTRK5+40yeQsL0ojfv8wXydcNOoKWeROMisdmKhkeZOVxd12I Mq1W/wnA==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oWe34-00GK84-AP; Fri, 09 Sep 2022 13:27:58 +0000 Date: Fri, 9 Sep 2022 06:27:58 -0700 From: Christoph Hellwig To: zhanchengbin Cc: steved@redhat.com, linux-nfs@vger.kernel.org, liuzhiqiang26@huawei.com, linfeilong Subject: Re: [PATCH] nfs-blkmapd: Fix the error status when nfs-blkmapd stops Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Thu, Sep 01, 2022 at 09:44:08PM +0800, zhanchengbin wrote: > The systemctl stop nfs-blkmap.service will sends the SIGTERM signal > to the nfs-blkmap.service first.If the process fails to be stopped, > it sends the SIGKILL signal again to kill the process. > However, exit(1) is executed in the SIGTERM processing function of > nfs-blkmap.service. As a result, systemd receives an error message > indicating that nfs-blkmap.service failed. > "Active: failed" is displayed when the systemctl status > nfs-blkmap.service command is executed. Looks good: Reviewed-by: Christoph Hellwig