Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Gaosheng Cui <cuigaosheng1@huawei.com>
CC:     Jeff Layton <jlayton@kernel.org>, Christoph Hellwig <hch@lst.de>,
        Bruce Fields <bfields@redhat.com>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] nfsd: remove nfsd4_prepare_cb_recall() declaration
Thread-Topic: [PATCH] nfsd: remove nfsd4_prepare_cb_recall() declaration
Thread-Index: AQHYxBmuud+etxCPsUCTUhGQnt4ZPq3XOoCA
Date:   Fri, 9 Sep 2022 15:32:22 +0000
Message-ID: <D2116287-4A49-4CED-87C4-AC447901385F@oracle.com>
References: <20220909065910.1157954-1-cuigaosheng1@huawei.com>
In-Reply-To: <20220909065910.1157954-1-cuigaosheng1@huawei.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?q0UtBaS3DXNK5Hi9jUg+J1hp/lEwvjTqXOjXGzIEEoGYYUtARstH9FsaBTtj?=
 =?us-ascii?Q?t/leVNp3nDTifDw2x3B7uAOHGFKkOYyQENvLcfM9OeCMIkCy4NpuPq/k1Bpw?=
 =?us-ascii?Q?7568ncAGJAOwBjPkX5tTjV9bkcjJJu84m4/qH0QjZc/5mwA4ISmC3dSOXlbA?=
 =?us-ascii?Q?2YgTD9wPFoBLmrj+ZOEnpHRMn+F1DKTAweb/T7uPAkxmsdDQUUbrEhbaVvdR?=
 =?us-ascii?Q?Zrm6xVScWor31BwlCfLG+JK9VFB7wfNJQDSnEc+j6eYiWn3JgZSBAZ6OOM46?=
 =?us-ascii?Q?+O9ES3hvrjqdxr4dBoBms/PbSlSz7WGq4E50oef8e3N+xtY+6xuRQQnITnj/?=
 =?us-ascii?Q?fc3KLq4iXL7+fO/Tq4VoQEFx6AFK47Unm8YZguXvmbB5Y+QAbDThOgUWx1X5?=
 =?us-ascii?Q?shSmH9mhR9Md++Dgr60iUdgRUY7rjwRipNQnZvpIucyJxsidcNCo9mi4M4eZ?=
 =?us-ascii?Q?jbGwJcfDnC87I9T0myU/j62fJTGVsVwC9wLFW28LS1GztPd2LUdPfK3J7Yd/?=
 =?us-ascii?Q?uaGdA9K4laD5FtNa6ltXbQmpuo6GjzNFePcY77u5jOBSsExNg9WowgdWIpHs?=
 =?us-ascii?Q?65lc1VqSf9pYfNQFs18v0Gii4qnmk3OZkIv6bUG1BOS6g0mfRY2sol64zKhl?=
 =?us-ascii?Q?O/OxFcjkSOjqQ+/C5nSirLm8ZkMbSkOTzLkC9rJEcHJrxvmSgP2F3q+XMQMg?=
 =?us-ascii?Q?+fYBLVFB6d1i1ObOerMrQGuVwclYArK7+AT5lkJmuuzwHVgZMaz65VWjMTkR?=
 =?us-ascii?Q?ah0NU+3/dTwLbHpvQCAWVW7t7ywDrrebku3BLY5kzU1dOdG1LoNCza2WjfbK?=
 =?us-ascii?Q?L25rjtvO+IuBsBR4mLJhiQ0+iAccNM3tMQ1687wiMzGy5HU635czQfKNxIOs?=
 =?us-ascii?Q?9JEjFJ17Jqdbl7vgVRexp3mQ7VvKmUVZyNO/XpFveHrJlBERTFQ0x5bbRFI1?=
 =?us-ascii?Q?LHyNtnu6nKTAAiodX+CjReqHnLUJOH+mZbqkYmb+4vGkBEeRryO4CvgLihfa?=
 =?us-ascii?Q?YtOJEQlWJkLt3vqBOrmjIxMSN16gUT0xZP4PtcRopsbA8sYMHFDM7/G6sncP?=
 =?us-ascii?Q?GEnHV/Q852QDsDeydV88RiCArCNQ35/wADyHSxQFB/2X60SdjKOd5x6+90Pc?=
 =?us-ascii?Q?DhWisidrFiUyh5CjPt8NRTyMKzd15/hhT4mqNVrqQeA4GC8cD6+0pVU89YpS?=
 =?us-ascii?Q?rDDGlvBFCAqhJcPvMX+J2uwEuq/bjfEE5ret8zOBYZVOFwfeVGGwQ0Zs50iU?=
 =?us-ascii?Q?PiDthKFyJegKInfuOK4ZQBQELpnWshyjmZJC0DofV0CtO13uP/YdawJfZtxm?=
 =?us-ascii?Q?pBXUfp+aa9xyXhC3lCQsQ1VVyDj5HiEDyLdovQQAUI1GCtArFVn5Qg1AcAcz?=
 =?us-ascii?Q?NXrHSeybC0i1IaLm0KaLm03Ds/oXW7NaQeElC24LoLgGMGxwy+md1rnYtOII?=
 =?us-ascii?Q?DoJHvacWXYXaW0Mi6ml4QJgnOoFXUjmgvbt4ONNb53X20dNRY0Z23iRNYkia?=
 =?us-ascii?Q?Q/7frLMy4T/eG9Iszwr09x8ffja9ZGy8KtdTDeYfFxZJttp/jr0TeCdwuNMV?=
 =?us-ascii?Q?raZtAvM7EGzB+h6sy5UTPWgSL1kZuh8xDzBztfJG40ZbHYVq3mHxYusuTs7A?=
 =?us-ascii?Q?nw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <63DA7646BAC68E468841F49B2A006A81@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 87115e0e-e2dc-4b1f-a0a0-08da92787d9b
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Sep 2022 15:32:22.6803
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: xN0UQfbRUSRz1IfjgjzFOZAr4uFR9Zoqz/XUd53rag+epEoDaa8Y6PDlblBkmMoCtVEARcjfE0FzSZbx8Hyp5g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4405
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-09-09_08,2022-09-09_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxlogscore=999
 phishscore=0 mlxscore=0 spamscore=0 malwarescore=0 suspectscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2207270000 definitions=main-2209090054
X-Proofpoint-GUID: J8qaCJpEPWRlLe9xzcffsmxDujA2JJ0g
X-Proofpoint-ORIG-GUID: J8qaCJpEPWRlLe9xzcffsmxDujA2JJ0g
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Sep 9, 2022, at 2:59 AM, Gaosheng Cui <cuigaosheng1@huawei.com> wrote:
>=20
> nfsd4_prepare_cb_recall() has been removed since
> commit 0162ac2b978e ("nfsd: introduce nfsd4_callback_ops"),
> so remove it.
>=20
> Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>

Applied to for-next (6.1). Thanks!


> ---
> fs/nfsd/state.h | 1 -
> 1 file changed, 1 deletion(-)
>=20
> diff --git a/fs/nfsd/state.h b/fs/nfsd/state.h
> index 5d28beb290fe..4155be65d806 100644
> --- a/fs/nfsd/state.h
> +++ b/fs/nfsd/state.h
> @@ -697,7 +697,6 @@ extern int nfsd4_create_callback_queue(void);
> extern void nfsd4_destroy_callback_queue(void);
> extern void nfsd4_shutdown_callback(struct nfs4_client *);
> extern void nfsd4_shutdown_copy(struct nfs4_client *clp);
> -extern void nfsd4_prepare_cb_recall(struct nfs4_delegation *dp);
> extern struct nfs4_client_reclaim *nfs4_client_to_reclaim(struct xdr_neto=
bj name,
> 				struct xdr_netobj princhash, struct nfsd_net *nn);
> extern bool nfs4_has_reclaimed_state(struct xdr_netobj name, struct nfsd_=
net *nn);
> --=20
> 2.25.1
>=20

--
Chuck Lever