Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220811194834.470072-1-kdsouza@redhat.com>
In-Reply-To: <20220811194834.470072-1-kdsouza@redhat.com>
From:   Kenneth Dsouza <kdsouza@redhat.com>
Date:   Mon, 12 Sep 2022 23:54:48 +0530
Message-ID: <CAA_-hQKTjLzm6vzdna-3kSas8BZ=0Ug2axLm-T20bNQMG1iR+w@mail.gmail.com>
Subject: Re: [PATCH v2] libnfs4acl: Check file mode before getxattr call
To:     linux-nfs@vger.kernel.org
Cc:     steved@redhat.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

ping

On Fri, Aug 12, 2022 at 1:19 AM Kenneth D'souza <kdsouza@redhat.com> wrote:
>
> Currently we are checking file mode after getxattr call.
> Due to this the return value would be 0, which would change the getxattr return value.
> As xattr_size will be 0, nfs4_getfacl will fail with error EINVAL.
> This patch fixes this issue by moving the file mode check before
> getxattr call.
>
> Signed-off-by: Kenneth D'souza <kdsouza@redhat.com>
> ---
>  libnfs4acl/nfs4_getacl.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/libnfs4acl/nfs4_getacl.c b/libnfs4acl/nfs4_getacl.c
> index 7821da3..aace5cd 100644
> --- a/libnfs4acl/nfs4_getacl.c
> +++ b/libnfs4acl/nfs4_getacl.c
> @@ -39,6 +39,13 @@ static struct nfs4_acl *nfs4_getacl_byname(const char *path,
>                 return NULL;
>         }
>
> +       ret = stat(path, &st);
> +       if (ret == -1)
> +               goto err;
> +
> +       if (S_ISDIR(st.st_mode))
> +               iflags = NFS4_ACL_ISDIR;
> +
>         /* find necessary buffer size */
>         ret = getxattr(path, xattr_name, NULL, 0);
>         if (ret == -1)
> @@ -53,13 +60,6 @@ static struct nfs4_acl *nfs4_getacl_byname(const char *path,
>         if (ret == -1)
>                 goto err_free;
>
> -       ret = stat(path, &st);
> -       if (ret == -1)
> -               goto err_free;
> -
> -       if (S_ISDIR(st.st_mode))
> -               iflags = NFS4_ACL_ISDIR;
> -
>         acl = acl_nfs41_xattr_load(buf, ret, iflags, type);
>
>         free(buf);
> --
> 2.31.1
>