Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Benjamin Coddington" <bcodding@redhat.com>
To:     "Al Viro" <viro@zeniv.linux.org.uk>
Cc:     "Chuck Lever III" <chuck.lever@oracle.com>,
        "Olga Kornievskaia" <aglo@umich.edu>,
        "Jeff Layton" <jlayton@kernel.org>,
        "Linux NFS Mailing List" <linux-nfs@vger.kernel.org>
Subject: Re: Is this nfsd kernel oops known?
Date:   Mon, 12 Sep 2022 14:45:48 -0400
Message-ID: <2F22D90A-3B64-43F0-899D-E41001DF3021@redhat.com>
In-Reply-To: <Yx45clPaZODzYV+z@ZenIV>
References: <5c423fdf25e6cedb2dcdbb9c8665d6a9ab4ad4b1.camel@kernel.org>
 <CAN-5tyEOTVDhR6FgP7nPVon76qhKkexaWB8AJ_iBVTp6iYOk1g@mail.gmail.com>
 <11BEA7FE-4CBC-4E5C-9B68-A0310CF1F3BE@oracle.com>
 <CAN-5tyHOugPeTsu+gBJ1tkqawyQDkfHXrO=vQ6vZTTzWJWTqGA@mail.gmail.com>
 <D0A6E504-F2C2-4A5F-BC51-FD3D88A790F0@redhat.com>
 <CAN-5tyHYH7ODzmTK=Maa3NZOSxfcE0mfaWY11+n2htQpya869g@mail.gmail.com>
 <EE9C1D1C-AA5B-48BC-9E3A-8A4523456AEE@oracle.com>
 <25AF9743-A2A2-4AFE-9123-BAD3C8F17655@redhat.com> <Yxz+GhK7nWKcBLcI@ZenIV>
 <8B4DBE66-960F-473C-8636-8159B397FFC0@oracle.com> <Yx45clPaZODzYV+z@ZenIV>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

On 11 Sep 2022, at 15:39, Al Viro wrote:
>>
>>> +	for (int i = sd->len; i > 0; i -= PAGE_SIZE)
>>> +		svc_rqst_replace_page(rqstp, page++);
>>> +	if (rqstp->rq_res.page_len == 0)	// first call
>>> +		rqstp->rq_res.page_base = offset % PAGE_SIZE;
>>> 	rqstp->rq_res.page_len += sd->len;
>>> 	return sd->len;
>>> }
>>
>> I could take this through the nfsd for-rc tree, but that's based
>> on 5.19-rc7 so it doesn't have f0f6b614f83d. I don't think will
>> break functionality, but I'm wondering if it would be better for
>> you to take this through your tree to improve bisect-ability.
>>
>> If you agree and Ben reports a Tested-by:, then here's my
>>
>>   Acked-by: Chuck Lever <chuck.lever@oracle.com>
>
> OK, I'll wait for Tested-by and send it to Linus.

No new crashes or corruption after several passes through xfstests.  I've
also tested the RDMA transport on soft iwarp.  Thanks for the fix here.

Tested-by: Benjamin Coddington <bcodding@redhat.com>

Ben