Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <326de41f-e8da-d97a-9f0c-2d62a77c9773@redhat.com>
Date:   Tue, 13 Sep 2022 13:37:36 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.0
Subject: Re: [PATCH v2 2/2] Fix function prototypes
Content-Language: en-US
To:     Khem Raj <raj.khem@gmail.com>
Cc:     Linux NFS Mailing list <linux-nfs@vger.kernel.org>
References: <20220816024403.2694169-1-raj.khem@gmail.com>
 <20220816024403.2694169-2-raj.khem@gmail.com>
From:   Steve Dickson <steved@redhat.com>
In-Reply-To: <20220816024403.2694169-2-raj.khem@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 8/15/22 10:44 PM, Khem Raj wrote:
> Clang is now erroring out on functions with out parameter types
> 
> Fixes errors like
> error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
> 
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
Committed... (tag: nfs-utils-2-6-3-rc1)

steved.
> Cc: Steve Dickson <steved@redhat.com>
> ---
> v2: Add Steve to Cc list
> 
>   support/export/auth.c     | 2 +-
>   support/export/v4root.c   | 2 +-
>   support/export/xtab.c     | 2 +-
>   utils/exportfs/exportfs.c | 4 ++--
>   utils/mount/network.c     | 2 +-
>   5 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/support/export/auth.c b/support/export/auth.c
> index 03ce4b8..2d7960f 100644
> --- a/support/export/auth.c
> +++ b/support/export/auth.c
> @@ -82,7 +82,7 @@ check_useipaddr(void)
>   }
>   
>   unsigned int
> -auth_reload()
> +auth_reload(void)
>   {
>   	struct stat		stb;
>   	static ino_t		last_inode;
> diff --git a/support/export/v4root.c b/support/export/v4root.c
> index c12a7d8..fbb0ad5 100644
> --- a/support/export/v4root.c
> +++ b/support/export/v4root.c
> @@ -198,7 +198,7 @@ static int v4root_add_parents(nfs_export *exp)
>    * looking for components of the v4 mount.
>    */
>   void
> -v4root_set()
> +v4root_set(void)
>   {
>   	nfs_export	*exp;
>   	int	i;
> diff --git a/support/export/xtab.c b/support/export/xtab.c
> index c888a80..e210ca9 100644
> --- a/support/export/xtab.c
> +++ b/support/export/xtab.c
> @@ -135,7 +135,7 @@ xtab_write(char *xtab, char *xtabtmp, char *lockfn, int is_export)
>   }
>   
>   int
> -xtab_export_write()
> +xtab_export_write(void)
>   {
>   	return xtab_write(etab.statefn, etab.tmpfn, etab.lockfn, 1);
>   }
> diff --git a/utils/exportfs/exportfs.c b/utils/exportfs/exportfs.c
> index 6ba615d..0897b22 100644
> --- a/utils/exportfs/exportfs.c
> +++ b/utils/exportfs/exportfs.c
> @@ -69,14 +69,14 @@ static int _lockfd = -1;
>    * need these additional lockfile() routines.
>    */
>   static void
> -grab_lockfile()
> +grab_lockfile(void)
>   {
>   	_lockfd = open(lockfile, O_CREAT|O_RDWR, 0666);
>   	if (_lockfd != -1)
>   		lockf(_lockfd, F_LOCK, 0);
>   }
>   static void
> -release_lockfile()
> +release_lockfile(void)
>   {
>   	if (_lockfd != -1) {
>   		lockf(_lockfd, F_ULOCK, 0);
> diff --git a/utils/mount/network.c b/utils/mount/network.c
> index ed2f825..01ead49 100644
> --- a/utils/mount/network.c
> +++ b/utils/mount/network.c
> @@ -179,7 +179,7 @@ static const unsigned long probe_mnt3_only[] = {
>   
>   static const unsigned int *nfs_default_proto(void);
>   #ifdef MOUNT_CONFIG
> -static const unsigned int *nfs_default_proto()
> +static const unsigned int *nfs_default_proto(void)
>   {
>   	extern unsigned long config_default_proto;
>   	/*