Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4e29b6ba-1824-e6a7-0f68-9c0aa90453cd@redhat.com>
Date:   Tue, 13 Sep 2022 13:38:49 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.0
Subject: Re: [PATCH v3] nfsrahead: fix linking while static linking
Content-Language: en-US
To:     Giulio Benetti <giulio.benetti@benettiengineering.com>,
        linux-nfs@vger.kernel.org
References: <20220809223308.1421081-1-giulio.benetti@benettiengineering.com>
 <20220810214554.107094-1-giulio.benetti@benettiengineering.com>
From:   Steve Dickson <steved@redhat.com>
In-Reply-To: <20220810214554.107094-1-giulio.benetti@benettiengineering.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 8/10/22 5:45 PM, Giulio Benetti wrote:
> -lmount must preceed -lblkid and to obtain this let's add in configure.ac:
> PKG_CHECK_MODULES([LIBMOUNT], [mount])
> and in tools/nfsrahead/Makefile.am let's substitute explicit `-lmount`
> with:
> $(LIBMOUNT_LIBS)
> This way all the required libraries will be present and in the right order
> when static linking.
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
Committed... (tag: nfs-utils-2-6-3-rc1)

steved
> ---
> V1->V2:
> * modify pkg-conf to pkg-config
> V2->V3:
> * use the correct way for using pkg-config with Autotools
> ---
>   configure.ac                | 3 +++
>   tools/nfsrahead/Makefile.am | 2 +-
>   2 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/configure.ac b/configure.ac
> index f1c46c5c..ff85200b 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -273,6 +273,9 @@ AC_LIBCAP
>   dnl Check for -lxml2
>   AC_LIBXML2
>   
> +dnl Check for -lmount
> +PKG_CHECK_MODULES([LIBMOUNT], [mount])
> +
>   # Check whether user wants TCP wrappers support
>   AC_TCP_WRAPPERS
>   
> diff --git a/tools/nfsrahead/Makefile.am b/tools/nfsrahead/Makefile.am
> index 845ea0d5..7e08233a 100644
> --- a/tools/nfsrahead/Makefile.am
> +++ b/tools/nfsrahead/Makefile.am
> @@ -1,6 +1,6 @@
>   libexec_PROGRAMS = nfsrahead
>   nfsrahead_SOURCES = main.c
> -nfsrahead_LDFLAGS= -lmount
> +nfsrahead_LDFLAGS= $(LIBMOUNT_LIBS)
>   nfsrahead_LDADD = ../../support/nfs/libnfsconf.la
>   
>   man5_MANS = nfsrahead.man