Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f8e252f5-9a87-5f22-1c47-2fccd82091bf@redhat.com>
Date:   Tue, 13 Sep 2022 13:39:35 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.0
Subject: Re: [PATCH] nfs-blkmapd: Fix the error status when nfs-blkmapd stops
Content-Language: en-US
To:     zhanchengbin <zhanchengbin1@huawei.com>
Cc:     linux-nfs@vger.kernel.org, liuzhiqiang26@huawei.com,
        linfeilong <linfeilong@huawei.com>
References: <ae07856f-ef34-270e-91b2-9364fdcd6563@huawei.com>
From:   Steve Dickson <steved@redhat.com>
In-Reply-To: <ae07856f-ef34-270e-91b2-9364fdcd6563@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 9/1/22 9:44 AM, zhanchengbin wrote:
> The systemctl stop nfs-blkmap.service will sends the SIGTERM signal
> to the nfs-blkmap.service first.If the process fails to be stopped,
> it sends the SIGKILL signal again to kill the process.
> However, exit(1) is executed in the SIGTERM processing function of
> nfs-blkmap.service. As a result, systemd receives an error message
> indicating that nfs-blkmap.service failed.
> "Active: failed" is displayed when the systemctl status
> nfs-blkmap.service command is executed.
> 
> Signed-off-by: zhanchengbin <zhanchengbin1@huawei.com>
Committed... (tag: nfs-utils-2-6-3-rc1)

steved.
> ---
>   utils/blkmapd/device-discovery.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/utils/blkmapd/device-discovery.c 
> b/utils/blkmapd/device-discovery.c
> index 2736ac89..49935c2e 100644
> --- a/utils/blkmapd/device-discovery.c
> +++ b/utils/blkmapd/device-discovery.c
> @@ -462,7 +462,7 @@ static void sig_die(int signal)
>           unlink(PID_FILE);
>       }
>       BL_LOG_ERR("exit on signal(%d)\n", signal);
> -    exit(1);
> +    exit(0);
>   }
>   static void usage(void)
>   {