Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Jeff Layton <jlayton@kernel.org>
CC:     Anna Schumaker <anna@kernel.org>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH v4 1/2] NFSD: Return nfserr_serverfault if splice_ok but
 buf->pages have data
Thread-Topic: [PATCH v4 1/2] NFSD: Return nfserr_serverfault if splice_ok but
 buf->pages have data
Thread-Index: AQHYx5rr/lc8S5bVRUSZRf9utUmxSK3g7C6AgABplQA=
Date:   Fri, 16 Sep 2022 02:17:37 +0000
Message-ID: <394AE5EA-1F01-4071-860F-7BC113514423@oracle.com>
References: <20220913180151.1928363-1-anna@kernel.org>
 <20220913180151.1928363-2-anna@kernel.org>
 <9fe0c36d7d846a17aa65ace8df09f66fde96980b.camel@kernel.org>
In-Reply-To: <9fe0c36d7d846a17aa65ace8df09f66fde96980b.camel@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?o/KRH78fq9PpHKsXKgmwEC8cYzqod+GIgBvGCHv9Jtb92LDQWHBZcUdFmkTn?=
 =?us-ascii?Q?ikTugnAihnNLwOAmK8M9jasw5M5qX/WWwgOCWvuXfExTdxDxmuosmCCMvUqM?=
 =?us-ascii?Q?C+JxaOAwDxG8SyZZCgfZQBfNsRIQczKpORJlaHww7fkYM072ar5atAtoYqK4?=
 =?us-ascii?Q?Ln6u4EZ9C6VSc2ERacSe9m1vpLuNS7M0TBIEOCBLMWJZtZTssk3yTBQoEdRU?=
 =?us-ascii?Q?wHqzc7AlsiKdFn5G8F0ha/W5hLD4dS+vQzuznsCNvIWykVk3FXH0m/ZXKtKj?=
 =?us-ascii?Q?upzZyPBYpMjf63ayG95LK7ag8NFTC1zgukw2BQmK49p1CEA8Ytwv27TL3TF/?=
 =?us-ascii?Q?SFE5qqzTSo84WzGZCKaWuyAW723zCL3cQK9VLzGTBOeNsl7XXbJmoProecO9?=
 =?us-ascii?Q?W6Ix2t10miFt70PPaCmRaVFrISLIdhc1sa/09NMUBwh5iMKgKxcipqsf5Bk6?=
 =?us-ascii?Q?H2yoO5MnVaRDMYRIxhPKrvJ5+OQTMxMP9Pvprzc10bpyS1hzCCXxVAvA8kJ+?=
 =?us-ascii?Q?2XAR4W8IJsaNpDOvjHEVUZOhYje7T8mPHMgw5UuA32zaclMQfeDsAty7YK4Y?=
 =?us-ascii?Q?X8SWOmNEaa6u0F4YP5loNmRboeZzxEALqonrwE/9IdW/b/R+TXOsQiNE9PXd?=
 =?us-ascii?Q?S7rIvg0X+7FDhVNwBTZ9Cf9x+aLBjMG3ZKAbZ/FGJB3Sbertz02e7Y5DC8lb?=
 =?us-ascii?Q?BctinW2jZU+TBId4xRER43vQj3Sg4q1twQmAIIIj99hfHhCGSaIGo1lDez/2?=
 =?us-ascii?Q?Cd/vhF/N0oamoiBUeJRLkmw+jWqCswAYSrGK7X7ZdMJN0pxEvdM2+34v4RcJ?=
 =?us-ascii?Q?CAd2K/WKNU92UoFaX3pwA4X85vSMdnQHqM6R4uW09YaUM52LeJOZhBGK9OwF?=
 =?us-ascii?Q?uA3iXe1WZ8FsfUr5qtlkExmz9dNTHMgsppWsI18Nd0St8f/kPX+SvsRLz1Lq?=
 =?us-ascii?Q?a5XPFfoxQySphR4SjFfK74y60ucaMWgyQ5woKCuQHwbYGDOuTlVhx371Ndbv?=
 =?us-ascii?Q?EsYCuYDTYuK9XmpajMU5O1ekdEcZKCSxdT97Krqu15B0+d1oQ+qPa2BGoXJ4?=
 =?us-ascii?Q?ZP0tf9mFXHs1AxdZFAF1kExu8MblDLT4kF8FoDANPfJDgRFbJzkDgGYpgYPE?=
 =?us-ascii?Q?ZOXfA5CpWbFjCN3tXVBplW12PtB8x6Kox04/1nUzamL3fGUVN/3I9UpBwP/1?=
 =?us-ascii?Q?QUDP3b14keM9JDucs87GK11Iwq/P7V3EEf4BhC6hAv4cLDgJEaBOoFBOS0gC?=
 =?us-ascii?Q?IOlYysSeUWqlgahNRDYensCvMyt1Fz1kKDW2c4OzxaF7F5tsMHNhD3wU/FEw?=
 =?us-ascii?Q?r4MAnYxT8eUgxIMwUlE8p8wtPnCOh8UArT1gd8a3StsE1tanaErEW6BQsRe6?=
 =?us-ascii?Q?KD4x7ZX9jkhZ91drX7h3GF8NmGlPfi/GVyom2l+Z7U2Cjtyi6+rUHc1YD1Z+?=
 =?us-ascii?Q?bxb/+snmyQUSDX8/W5+xRK1IufPNZKDlOynqWYiUEoGbfqRukcA1H0dW1Yb5?=
 =?us-ascii?Q?uNrBi0EvUXbUpYrSsQJgq2NRkHaC3+jHT4Yeq/uXu4CJec+Giuy8YhRNZ+JC?=
 =?us-ascii?Q?O5kNuVyk6rxrdVbHdLa19OPESV5gfkEEGI7St0T+cf2uDgFVJoQz7Zd1dhki?=
 =?us-ascii?Q?kg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <0F1EE0FB6F898D488A786EB0C49E33D7@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 47de8c91-c91a-4176-d435-08da97899fa6
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Sep 2022 02:17:37.0858
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: hugc/NTl9/py2EVbxgXoOdrNmGH5tCMNWL+zVUfN09vZew+WdC4RFHbyfE2tJp+ZPVKBW7turNfVWkk5rFO6Dg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB4999
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-09-15_10,2022-09-14_04,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 phishscore=0
 malwarescore=0 mlxscore=0 spamscore=0 suspectscore=0 bulkscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2209160015
X-Proofpoint-GUID: 5KuxA1Jg76O34xGOf-B6Zq468VRV4IoL
X-Proofpoint-ORIG-GUID: 5KuxA1Jg76O34xGOf-B6Zq468VRV4IoL
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Sep 15, 2022, at 12:59 PM, Jeff Layton <jlayton@kernel.org> wrote:
>=20
> On Tue, 2022-09-13 at 14:01 -0400, Anna Schumaker wrote:
>> From: Anna Schumaker <Anna.Schumaker@Netapp.com>
>>=20
>> This was discussed with Chuck as part of this patch set. Returning
>> nfserr_resource was decided to not be the best error message here, and
>> he suggested changing to nfserr_serverfault instead.
>>=20
>> Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
>> ---
>> fs/nfsd/nfs4xdr.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>=20
>> diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
>> index 1e9690a061ec..01dd73ed5720 100644
>> --- a/fs/nfsd/nfs4xdr.c
>> +++ b/fs/nfsd/nfs4xdr.c
>> @@ -3994,7 +3994,7 @@ nfsd4_encode_read(struct nfsd4_compoundres *resp, =
__be32 nfserr,
>> 	}
>> 	if (resp->xdr->buf->page_len && splice_ok) {
>> 		WARN_ON_ONCE(1);
>> -		return nfserr_resource;
>> +		return nfserr_serverfault;
>> 	}
>> 	xdr_commit_encode(xdr);
>>=20
>=20
> IIRC the problem is that nfserr_resource is not valid in v4.1+. Do we
> also need to change the nfserr_resource return in the if block above
> this one?

I discovered that nfsd4_encode_operation() converts nfserr_resource
to the status code that is proper for the minor version that is in
use. We're good to go there.

--
Chuck Lever