Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c9521a3b-a83d-765d-6e0b-1bb7c12dc540@redhat.com>
Date:   Tue, 20 Sep 2022 14:49:02 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.0
Subject: Re: [PATCH v2 2/2] nfs4_setfacl: update man page about new option
 index
Content-Language: en-US
To:     Pierguido Lambri <plambri@redhat.com>,
        Linux NFS Mailing list <linux-nfs@vger.kernel.org>
References: <20220914173115.296058-1-plambri@redhat.com>
 <20220914173115.296058-2-plambri@redhat.com>
From:   Steve Dickson <steved@redhat.com>
In-Reply-To: <20220914173115.296058-2-plambri@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 9/14/22 1:31 PM, Pierguido Lambri wrote:
> The man page now reflects the newly added syntax to handle indexes.
> 
> Signed-off-by: Pierguido Lambri <plambri@redhat.com>
Committed (tag: nfs4-acl-tools-0.4.1-rc3)

steved.
> ---
>   man/man1/nfs4_setfacl.1 | 26 ++++++++++++++------------
>   1 file changed, 14 insertions(+), 12 deletions(-)
> 
> diff --git a/man/man1/nfs4_setfacl.1 b/man/man1/nfs4_setfacl.1
> index 47ab517..61699ae 100644
> --- a/man/man1/nfs4_setfacl.1
> +++ b/man/man1/nfs4_setfacl.1
> @@ -30,27 +30,21 @@ Refer to the
>   manpage for information about NFSv4 ACL terminology and syntax.
>   .SS COMMANDS
>   .TP
> -.BR "-a " "\fIacl_spec\fP [\fIindex\fP]"
> +.BR "-a " "\fIacl_spec\fP"
>   .RI "add the ACEs from " acl_spec " to " file "'s ACL."
> -ACEs are inserted starting at the
> -.IR index th
> -position (DEFAULT: 1) of
> +ACEs are inserted starting at the default position 1 of
>   .IR file "'s ACL."
>   .\".ns
>   .TP
> -.BR "-A " "\fIacl_file\fP [\fIindex\fP]"
> +.BR "-A " "\fIacl_file\fP "
>   .RI "add the ACEs from the acl_spec in " acl_file " to " file "'s ACL."
> -ACEs are inserted starting at the
> -.IR index th
> -position (DEFAULT: 1) of
> +ACEs are inserted starting at the default position 1 of
>   .IR file "'s ACL."
>   .TP
> -.BI "-x " "acl_spec \fR|\fP index"
> +.BI "-x " "acl_spec \fR"
>   delete ACEs matched from
>   .I acl_spec
> -- or delete the
> -.IR index th
> -ACE - from
> +from
>   .IR file 's
>   ACL.  Note that the ordering of the ACEs in
>   .I acl_spec
> @@ -61,6 +55,10 @@ delete ACEs matched from the acl_spec in
>   .IR acl_file " from " file "'s ACL."
>   Note that the ordering of the ACEs in the acl_spec does not matter.
>   .TP
> +.BI "-i " "\fIindex\fP"
> +.RI "ACEs are inserted or deleted starting at the " index "th position (DEFAULT: 1) of file's ACL.
> +It can be used only with the add or delete action.
> +.TP
>   .BI "-s " acl_spec
>   .RI "set " file "'s ACL to " acl_spec .
>   .TP
> @@ -189,6 +187,10 @@ add the same ACE as above, but using aliases:
>   .br
>   	$ nfs4_setfacl -a A::alice@nfsdomain.org:RX foo
>   .IP - 2
> +add the same ACE as above, at index 2:
> +.br
> +	$ nfs4_setfacl -i 2 -a A::alice@nfsdomain.org:RX foo
> +.IP - 2
>   edit existing ACL in a text editor and set modified ACL on clean save/exit:
>   .br
>   	$ nfs4_setfacl -e foo