Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220919235954.14011-1-rosenp@gmail.com> <0d972685-d120-0b2c-c072-b8e9941e0baf@redhat.com>
In-Reply-To: <0d972685-d120-0b2c-c072-b8e9941e0baf@redhat.com>
From:   Rosen Penev <rosenp@gmail.com>
Date:   Tue, 20 Sep 2022 13:31:19 -0700
Message-ID: <CAKxU2N8azu-nfzocWZDCGVj3Yawqnc6HjzvzeFktAn-57PHzPA@mail.gmail.com>
Subject: Re: [PATCH] libtirpc: add missing extern
To:     Steve Dickson <steved@redhat.com>
Cc:     linux-nfs@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Sep 20, 2022 at 12:28 PM Steve Dickson <steved@redhat.com> wrote:
>
>
>
> On 9/19/22 7:59 PM, Rosen Penev wrote:
> > Fixes compilation warning.
> What was the warning? Plus AUTH_DES is no longer supported.
Implicit function declaration as it's not in a header file or anything.

I found the issue from doing a meson conversion for libtirpc:
https://github.com/mesonbuild/wrapdb/pull/644

I have no idea about AUTH_DES or what it's used for.
>
> steved.
> >
> > Signed-off-by: Rosen Penev <rosenp@gmail.com>
> > ---
> >   src/svc_auth.c | 3 +++
> >   1 file changed, 3 insertions(+)
> >
> > diff --git a/src/svc_auth.c b/src/svc_auth.c
> > index ce8bbd8..789d6af 100644
> > --- a/src/svc_auth.c
> > +++ b/src/svc_auth.c
> > @@ -66,6 +66,9 @@ static struct authsvc *Auths = NULL;
> >
> >   extern SVCAUTH svc_auth_none;
> >
> > +#ifdef AUTHDES_SUPPORT
> > +extern enum auth_stat _svcauth_des(struct svc_req *rqst, struct rpc_msg *msg);
> > +#endif
> >   /*
> >    * The call rpc message, msg has been obtained from the wire.  The msg contains
> >    * the raw form of credentials and verifiers.  authenticate returns AUTH_OK
>