Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c46b63f6-d222-36cb-ffb4-558df20edf24@nvidia.com>
Date:   Thu, 22 Sep 2022 21:34:26 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH v2 4/7] iov_iter: new iov_iter_pin_pages*() routines
Content-Language: en-US
To:     Jan Kara <jack@suse.cz>
Cc:     Al Viro <viro@zeniv.linux.org.uk>,
        Christoph Hellwig <hch@infradead.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Jens Axboe <axboe@kernel.dk>,
        Miklos Szeredi <miklos@szeredi.hu>,
        "Darrick J . Wong" <djwong@kernel.org>,
        Trond Myklebust <trond.myklebust@hammerspace.com>,
        Anna Schumaker <anna@kernel.org>,
        David Hildenbrand <david@redhat.com>,
        Logan Gunthorpe <logang@deltatee.com>,
        linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org,
        linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
References: <103fe662-3dc8-35cb-1a68-dda8af95c518@nvidia.com>
 <Yxb7YQWgjHkZet4u@infradead.org> <20220906102106.q23ovgyjyrsnbhkp@quack3>
 <YxhaJktqtHw3QTSG@infradead.org> <YyFPtTtxYozCuXvu@ZenIV>
 <20220914145233.cyeljaku4egeu4x2@quack3> <YyIEgD8ksSZTsUdJ@ZenIV>
 <20220915081625.6a72nza6yq4l5etp@quack3> <YyvG+Oih2A37Grcf@ZenIV>
 <a6f95605-c2d5-6ec5-b85c-d1f3f8664646@nvidia.com>
 <20220922112935.pep45vfqfw5766gq@quack3>
From:   John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <20220922112935.pep45vfqfw5766gq@quack3>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SzNtcGlFQlFzK0tCbkQxZUYrb3FHTWhFWE9QbkNSSFhrMzllQkdwa0ROQ01J?=
 =?utf-8?B?K25WMWp0RnVrTnVLTGdKTjUvb3hLaWlSTDlic2NlYzdmSjF3Rm5TckliTFNw?=
 =?utf-8?B?UllsQWxMNVFMY2Y0MlBOQk9OcnV1eExrRmNjYk9xYm5lTFhMNzhicXVLTkps?=
 =?utf-8?B?S2pudXFKdjdKNy9yem5YWHJ5b0JIejBXN053UE5mc0w2czdJRmFQbWVNaWRG?=
 =?utf-8?B?RGt6WnU3ZHNuSDVabStFbWl5RThLWEJvZFU2Z1dsN0Q1eG5EQVQ1UGVxZE9h?=
 =?utf-8?B?NzBaTDkweGZjaFpVL2dlak1HREFPWG5GT3VnUG5CNERodkRnMlNYeW1mMGFI?=
 =?utf-8?B?VnhuYWtsMlhDd0FFSjJEUU1RcGFOdEFhR0xVc202SXZ2OHRrK0trVXVjMkpH?=
 =?utf-8?B?b2ljb3ZRNGVVL2xvVlJEYjREOGQ2TFMrSG8vbjcwdU5sZHFzc1JOQzV2enFj?=
 =?utf-8?B?RFRrTlFhd20xR2dKWjhGY0M1a21rMGZ6Tld5VlRhZlFPVW9WUWRxMmJtNHZQ?=
 =?utf-8?B?M1IwQkQ4OERDN3VobTdDblhCMWhuUDVsY081dWsxcWtSckRTZDhic1ZhMTJ3?=
 =?utf-8?B?NEhUbWwrYnFBTEtVandhSTVQbXlZTDh4bVpJSE5lNnEwYkt1Q0g5RFJBT2Fm?=
 =?utf-8?B?S1hQYmlWanBLN2N3djNvR2F2aW5NSlo2WE84emVlQmpVZmhlalpxd25yNEtE?=
 =?utf-8?B?aXJkZmxpeCtXaFc2dGpVNFFpdDFVM0VzK2xXUUJISmY3UHZJNHJaWVJqZDRv?=
 =?utf-8?B?WCtZaXdENHYvWGh6dVZHS1dwZFlhSzJGR2xsd2ZnUTZFdmdyWFFzR3FxSEVm?=
 =?utf-8?B?bkhpUG9iMm1uT2RmdXpYeUQzS1pZUXZid21kdmkrTHU3bWFEU3RXN1A2b0Nm?=
 =?utf-8?B?V1duWkhuOFF1c0liZk4vSWZTS2Myd0w1MmFQVENucGczSHFLeWN6SWJEdE54?=
 =?utf-8?B?SGxpNnFzOGVEdk5qOW5zSlNaZGE3M1F0VFM1SFZEOUxMNG1PMVIvaFI0cWc1?=
 =?utf-8?B?S20vVDVDY0IzZCtib3FOaEpySjFuMkMveVRpZkZHTzQxbXJudkp4QytxK0tW?=
 =?utf-8?B?SkZYRmlMOUhySWhoSXpWZHhDbW04UWpYcjJ3bHJ0YmtQL3JYcGFBYjBEdjhM?=
 =?utf-8?B?NVF3OVFhSjlObVhBeHF0RmF5SHNRK2ZiSXh0S1NjUXFYZnBaRjhCK2FtQ0dw?=
 =?utf-8?B?WDBHMjFZcjQ3QkxOMUo0akg3MUlVVGpEdGUwQzZscFJuUnVJUU9ldUZob2N2?=
 =?utf-8?B?RmdpSTlRclJNcFUvd0JUMWtoNTQrWFNTSTlhMWYrYXJCZHY5OEFzL1diYVhX?=
 =?utf-8?B?ZmE0L21ud1hpTGVrYi9JN0cycmZXWXBxbmFtSlFnNUY4RVh0dXZQTXhuZHUw?=
 =?utf-8?B?U0pHNHlOcmVBekFKYTBGWDZTZlA3VytRUDVaQXhKT1JzaVpocW4vWDJvOU9u?=
 =?utf-8?B?VXR5ZzR5WGpmSGxYeUtEbGo2SVJLVlVsaHlRZnY2bkNGQ0NMTUd6QjdVbktY?=
 =?utf-8?B?SFVSQVFXc2l1amJKTEtYTjlyOWxsaVMray9HRjJOVFlVekF1V29JZHNzYkFZ?=
 =?utf-8?B?UEEwWnNyU3dsQmdmTXJvMFMyQWdUeURqL21HaXJyZVhEMUhjQ2RwdFFQM2xO?=
 =?utf-8?B?SUNlbzZkQ1FKR2ZEMHQ5UjlmVTlvbTJqcnhJeUhNdVpqUDNUV01lNkpDVVVO?=
 =?utf-8?B?endQcmdNdzRXVlhtbTU5ZU5vdkdHenpsT0pvYWtUazZpajFyU3h3MzQxZXRj?=
 =?utf-8?B?MWR5cXBDWHpvb29MTzJmYnIzRGdRSFNCeXRxNTBaNmJNUGtRbk8rbURXVUF6?=
 =?utf-8?B?UjFaZ0NJaitGZ21vSWRxcDFJRHdkTy9ZbFFZWEZaMEFjL01oOG1aMTkzZy90?=
 =?utf-8?B?Mmkwcnp6Y2I5cGg1N1NBNTk4NjRuTGE2eGV3V3hoMWMwRTJKeHVvNklMMHpO?=
 =?utf-8?B?by9oWERZMVo2Ykx0aXJNWGtnQ1p4REh3WjZMN2JnZEFRNG56U1VxaVJ6aDN4?=
 =?utf-8?B?OE43S2FYQXlPVTQrS2s2RnVoczM3SjNGdHkzWXFxZUM3NEY0dkFTZVNVcllq?=
 =?utf-8?B?Mk45WmdreHFYQUlYU0FENXB5WCt2NVJKSjJJZk1oekFkTFhVNDR0ejZQT3hl?=
 =?utf-8?B?Rm5CN1g4K1FQc0lYd0JIbzg2Zk9nTTJLdkJGTDBqZjl1SnpKeTN1dWNMOXYw?=
 =?utf-8?B?OVE9PQ==?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0ca31e1c-2fc0-4674-6195-08da9d1ce7b3
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Sep 2022 04:34:29.9690
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KW2N3yXvFat5zJQzIXBT/rCemUAbZQunKdHDKX/HD2W5zKd9IF5a4l3VxrA2fFjPFzVY2pjiImv/RDkhhQPecA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6605
X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org

On 9/22/22 04:29, Jan Kara wrote:
> I don't think this will work. The pin nfs_direct_read_schedule_iovec()
> obtains needs to be released once the IO is completed. Not once the IO is
> submitted. Notice how nfs_create_request()->__nfs_create_request() gets
> another page reference which is released on completion
> (nfs_direct_read_completion->nfs_release_request->nfs_page_group_destroy->
> nfs_free_request->nfs_clear_request). And we need to stop releasing the
> obtained pin in nfs_direct_read_schedule_iovec() (and acquiring another
> reference in __nfs_create_request()) and instead propagate it to
> nfs_clear_request() where it can get released.
> 
> 								Honza

OK, now I see how that is supposed to work, thanks for explaining!


thanks,

-- 
John Hubbard
NVIDIA