Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp166243rwb; Mon, 26 Sep 2022 10:37:16 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4acpUB3Nk1MyCkmlbzcsZ1rlMAxAvFtC2CdwPVTsrYqleAciEXTJ+mJxFfmPbMMQKOsPCC X-Received: by 2002:a62:6085:0:b0:53e:7874:5067 with SMTP id u127-20020a626085000000b0053e78745067mr25229142pfb.4.1664213835890; Mon, 26 Sep 2022 10:37:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664213835; cv=none; d=google.com; s=arc-20160816; b=I92mKORSiO+SJmWSZ/lczgd6h//4hvUOoca4WYhvzZr2sSd65RsGcwhUKAAt/tg0vh qSWFqvMBr9GaJOwAH6GPwRIN7FzD3NS3BUyvuU13IeglaufUD2w/HXOqYKzkJ6dICRuY 3zaVox+lPib9eUJqV5/0U9KzD1lXuL/OpqMmY4eYBAbQBJO2lvwUaVCuHYnhGRW1ZKQI XXegh3DFFarOkZ8XTyPC5289czIiuGZDi4Qm9HD6IZHeMpLm/xseZRVW4UA31fOqAqKL qUNr4LAypCeLI4sgFQq7NaiPhPHFvRBCEYelgdr5Cng8eaVoDn9/fbFFPiFwo+kvezvU lnOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=swtlBtmlMX+nopuaunmNyTHCR9lhaEFSrQ9drHsfzZs=; b=UZOHc/ucgWZAlH2ZXE++L5HGnFF1KrLC/7F2gV5Nm4UDU0cGB723ZPSDBdvUxeyXvA vTVngIgbCeZx8Jw2p2P1z1PFmQNsIFnfKdA8rdi5TRSO4RfyJSTeArESeGmvjphZT0uj yUqT+Up4OxtA+c1ROJC83n6ocgvjpmudIV5h7mmO9W5+YcFqW/IDP9UmhxpBnBQLZy1I xk04cxpnuT28d1q76JDYspyCSU9GrbrM014gXk9A2GavwHkGNHALxzy94Lad2Mc8Cx+G Z9C50TX/hnmNEfN5ZdP+gIqRA6cnFv3/uhG8raH890+K60DRZDWYAYtRW902K/bIlM+B 8t2g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=irO3GCst; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q21-20020a056a00089500b0052fac3954e9si1840825pfj.227.2022.09.26.10.36.59; Mon, 26 Sep 2022 10:37:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=irO3GCst; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230469AbiIZRYH (ORCPT + 99 others); Mon, 26 Sep 2022 13:24:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231172AbiIZRXq (ORCPT ); Mon, 26 Sep 2022 13:23:46 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ADDF112F744 for ; Mon, 26 Sep 2022 09:38:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3C03160FDA for ; Mon, 26 Sep 2022 16:38:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 55D70C433C1; Mon, 26 Sep 2022 16:38:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664210329; bh=x+jvZpAQD49OnAwK2gXuF648cs1JpNA51XaU06fHRko=; h=From:To:Cc:Subject:Date:From; b=irO3GCstSsAxexQjQ998Ak1sCvx9tc2h2pk/KWmgtqtgzSXTBv8/szsWAte8A7R8t ChJAWTssHhD01E0RkLPWZ4mvMr1X2Ar+9jAC2UipdjP6BIh+nSovudhAmQ1zLxKyl+ gN/4oYEQXa07kn2szA4cKsvw8YDxPrErnLRMuTYJ/bv1Bu7ynW5m8K8b7eapdLFm4l HR7dhb3+Iumc0LdBrJ8NknHQEN63ahmgqCFIn/lPVbny7NkkP4qq5q2eCMr4Ly/MNQ +Olzhrrds5nQA1rS/sILRQ2lqwbH7Pg5OqAauWlWdFEvPfpw4qbL/XyDtuOKV3MwlX ZuJsJkZthuuhA== From: Jeff Layton To: chuck.lever@oracle.com Cc: linux-nfs@vger.kernel.org Subject: [PATCH 0/4] nfsd: minor cleanup and sanity check patches for nfsd Date: Mon, 26 Sep 2022 12:38:43 -0400 Message-Id: <20220926163847.47558-1-jlayton@kernel.org> X-Mailer: git-send-email 2.37.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Chuck, While hunting for some bugs, I found some warts that the first two patches clean up. I also added some sanity checks when freeing delegations or queueing up a CB_RECALL. Your call on whether you want to accept those. These should apply cleanly to your for-next branch, but the last patch may need to be adjusted when Dai fixes up his patch. Cheers, Jeff Layton (4): nfsd: only fill out return pointer on success in nfsd4_lookup_stateid nfsd: fix comments about spinlock handling with delegations nfsd: make nfsd4_run_cb a bool return function nfsd: extra checks when freeing delegation stateids fs/nfsd/nfs4callback.c | 14 ++++++++++++-- fs/nfsd/nfs4state.c | 26 +++++++++++++++----------- fs/nfsd/state.h | 2 +- 3 files changed, 28 insertions(+), 14 deletions(-) -- 2.37.3