Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Dai Ngo <dai.ngo@oracle.com>
CC:     "jlayton@kernel.org" <jlayton@kernel.org>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH v3 0/1] NFSD: fix use-after-free on source server when
 doing inter-server copy
Thread-Topic: [PATCH v3 0/1] NFSD: fix use-after-free on source server when
 doing inter-server copy
Thread-Index: AQHY0dG1BPDkNSPzskKQxMgnv7vEhK3yDBmA
Date:   Mon, 26 Sep 2022 18:43:29 +0000
Message-ID: <A6371482-E1B0-4F93-B7DD-5EC5B468C67B@oracle.com>
References: <1664215156-9970-1-git-send-email-dai.ngo@oracle.com>
In-Reply-To: <1664215156-9970-1-git-send-email-dai.ngo@oracle.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?c4TtPlfLGirg2WnQekCU8oYwJ1Rb77wfz4x8oeYsyohJg3QGV/J9B20QjiGW?=
 =?us-ascii?Q?qnG0hRUFxKhYhvN3ITf3Qv4NPj+iVHOHnQtwTeI1zNwHUGc1hDCyL6INhLI+?=
 =?us-ascii?Q?a74l8IClQyewVi8+2qpC5bGrh9/lwqClvugj1wLPJOAWCJeoZKYXYlCt1wq0?=
 =?us-ascii?Q?lqR52FXiYYsnydEmpToKdXfAyI3IlgC/Kcbrf47i7jKHdg7XBbwCgDCdcTjo?=
 =?us-ascii?Q?c//ZBO7FN/bMHUx3VmUCnQGNoEgMX0uNDuBuW+SFp4xoEmvF3tBXYeekhVrS?=
 =?us-ascii?Q?OBC4aN7ZAekXra8p4Esy1mBTjiPzQq4r3R9p9WxYBmhLCfsdWzdOXfMTw2OD?=
 =?us-ascii?Q?ME+icdiW1T30UUX3aZndauuGqUQd/QD5b5g/ouQP8Juk98EzVEjal7ww/b/s?=
 =?us-ascii?Q?dbgtJkL5dwya/Iul2lAscNccf1z29VZIR1IwfBkSlBVEJM6fVe5oBCA8j8rB?=
 =?us-ascii?Q?IYsyYKdP777wpMGthQiU4trH22lzCozX1b1yGmLlNkn8CAAC0rblo65QmflP?=
 =?us-ascii?Q?C6H7+lukoNK8rZhIpETsPCQrG4AcNXXGFNDuOfTlWa2Na2Hhj3wPwUslah1x?=
 =?us-ascii?Q?vm8w/6WZJcrX1QNBWEAyQqefd8llNO49LLTNhF+yCgYVKJKQOL5ZKMVsOzZm?=
 =?us-ascii?Q?9/OeIcpkvbPIctAUEVlUsJzewOn9U2DsVtyeU8OamDXOYvydWlqHL+fXlSWU?=
 =?us-ascii?Q?/yFToQ3I2/OAw5nFXBjbM7K/39gEfJhMdJqzT+y850lmfjAs142JRVTLMcXH?=
 =?us-ascii?Q?YmKs+N1c71Snfn8/hZN1LTJK6WVoDGHmvfi9EP9XzT0LERhNA4w2bnUz3BNN?=
 =?us-ascii?Q?esJNO1qjQalAlX8rRZbDQRyaQO3ZONY3UCXs3OrJp0+TOp9xWdlZkm66DGQq?=
 =?us-ascii?Q?5sJloyfmglGpkmQGMJUdeyAAGku4Cg4KNntqGvc9TDRzpYMroJNVQGbzLnVa?=
 =?us-ascii?Q?OSNQxyA9IkKxu9CZ7UtMcI+owsKxxihvc4I7zvZMwM7rpjPC34NoMSXaLJy5?=
 =?us-ascii?Q?3y6ohex5oe1ZphJJ8rYUcFV1sILFkMocUywml/+7IXTKHFEyeCK1viYF5SKY?=
 =?us-ascii?Q?aMR2EofIB0tUYoDMhzcCxfwEHP4vuH3fqhPia7v5bpOrViFQmIV4T0e6Gu0I?=
 =?us-ascii?Q?LLZHgCSfVevt2A8SuP9JxTdxLjyIoagrKMGaOS/f6V2ESHRrxGC27dvQubDV?=
 =?us-ascii?Q?hpJ56jl4cXuEda4mb2WEm9smsUJ5ayUpWB1VS01ggEWZ+sgPclz+4CT6ezDT?=
 =?us-ascii?Q?6fLx7zp+kGhOF+i/JSVJMd+9cAEglDpJ7Rf+ZvgwInJVz2LQn0EPBdEiGelK?=
 =?us-ascii?Q?Ov4yj+PQL0nY2ZXoZATNswyX4fAud+moGWwzMGvLDovSsmy4OXkVKMqXmBaZ?=
 =?us-ascii?Q?mgabaoPfg/XU1zlzxEn3N68o1/be4sPohMfPsJ3WQfKdCByBXh/CSqj9d2x7?=
 =?us-ascii?Q?MO54LK082kjVqrmWIqkcBxisdAZV0hSx8NT/7gQCXug1nVMUjsFlI72lPmtX?=
 =?us-ascii?Q?7Pf1P3Kdg4DMMQKLNGGLW/loyP8ApVfWDKsO6BGt6DCU1Tpla2C0gQ4AgveT?=
 =?us-ascii?Q?qFdT+GppcoAawAB11SgV7pW0Ko04emUJcKL1kPgEHrgwf8x+KLTJhNY5iRkF?=
 =?us-ascii?Q?GA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <D0B8251359DF674891DEE7B4F14C2FC9@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4bb88895-14cb-4eb7-0fba-08da9fef017b
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Sep 2022 18:43:29.6563
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 1KyADEpl4OyO2wPLAe4AXAJeVe4aCHCK+plH2WI4ZncCzRli5uSbXo/AC/GlFYK7aPSRPIjIt5pJQBOe64sNDQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4446
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-09-26_09,2022-09-22_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 phishscore=0
 suspectscore=0 adultscore=0 bulkscore=0 mlxlogscore=999 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000
 definitions=main-2209260116
X-Proofpoint-ORIG-GUID: JRktM9-HBUQr25IKPzfX8f7yRbq2V4tn
X-Proofpoint-GUID: JRktM9-HBUQr25IKPzfX8f7yRbq2V4tn
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Sep 26, 2022, at 1:59 PM, Dai Ngo <dai.ngo@oracle.com> wrote:
>=20
> Hi Chuck,
>=20
> The v3 version simplifies the check for sc_cp_list empty in
> nfs4_free_deleg and nfs4_free_ol_stateid, as Jeff pointed out.
>=20
> Thanks,
>=20
> Dai Ngo (1):
> NFSD: fix use-after-free on source server when doing inter-server copy
>=20
> fs/nfsd/nfs4state.c | 5 +++++
> 1 file changed, 5 insertions(+)

Thanks, Dai. (Re)applied to nfsd's for-next.


--
Chuck Lever