Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3376ba7410b6211899c12872195a97219230823c.camel@kernel.org>
Subject: Re: [PATCH v2 0/9] A course adjustment, maybe...
From:   Jeff Layton <jlayton@kernel.org>
To:     Chuck Lever <chuck.lever@oracle.com>, linux-nfs@vger.kernel.org
Date:   Fri, 07 Oct 2022 09:19:18 -0400
In-Reply-To: <166507275951.1802.13184584115155050247.stgit@manet.1015granger.net>
References: <166507275951.1802.13184584115155050247.stgit@manet.1015granger.net>
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Thu, 2022-10-06 at 12:20 -0400, Chuck Lever wrote:
> I'm proposing this series as the first NFSD-related patchset to go
> into v6.2 (for-next), though I haven't opened that yet.
>=20
> For quite some time, we've been encouraged to disable filecache
> garbage collection for NFSv4 files, and I think I found a surgical
> way to do just that. That is presented in "NFSD: Add an NFSD_FILE_GC
> flag to enable nfsd_file garbage collection".
>=20
> Comments and opinions are welcome.
>=20
> Changes since RFC:
> - checking nfs4_files for inode aliases is now done only on hash
>   insertion
> - the nfs4_file reference count is now bumped only while the RCU
>   read lock is held
> - comments and function names have been revised and clarified
>=20
> I haven't updated the new @want_gc parameter... jury is still out.
>=20

It was just a nit I noticed since it looked like it was being used as a
bool. If you think it needs to be an int, then so be it.


> ---
>=20
> Chuck Lever (7):
>       NFSD: Pass the target nfsd_file to nfsd_commit()
>       NFSD: Revert "NFSD: NFSv4 CLOSE should release an nfsd_file immedia=
tely"
>       NFSD: Add an NFSD_FILE_GC flag to enable nfsd_file garbage collecti=
on
>       NFSD: Use const pointers as parameters to fh_ helpers.
>       NFSD: Use rhashtable for managing nfs4_file objects
>       NFSD: Clean up nfs4_preprocess_stateid_op() call sites
>       NFSD: Trace delegation revocations
>=20
> Jeff Layton (2):
>       nfsd: fix nfsd_file_unhash_and_dispose
>       nfsd: rework hashtable handling in nfsd_do_file_acquire
>=20
>=20
>  fs/nfsd/filecache.c | 165 +++++++++++++++---------------
>  fs/nfsd/filecache.h |   4 +-
>  fs/nfsd/nfs3proc.c  |  10 +-
>  fs/nfsd/nfs4proc.c  |  42 ++++----
>  fs/nfsd/nfs4state.c | 241 ++++++++++++++++++++++++++++++--------------
>  fs/nfsd/nfsfh.h     |  10 +-
>  fs/nfsd/state.h     |   5 +-
>  fs/nfsd/trace.h     |  58 ++++++++++-
>  fs/nfsd/vfs.c       |  19 ++--
>  fs/nfsd/vfs.h       |   3 +-
>  10 files changed, 351 insertions(+), 206 deletions(-)


I been doing some testing with this and it seems to be working well. You
can add:

Tested-by: Jeff Layton <jlayton@kernel.org>