Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp2678955rwb; Sat, 8 Oct 2022 12:08:19 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5tqHo4rq8TMhGAjTB/z3v9d04q03+X4QYKKRyv0sZMDTwPU4zcWICZDBwCEQfDoHhU1JVq X-Received: by 2002:a65:6bd3:0:b0:42b:9117:b9d1 with SMTP id e19-20020a656bd3000000b0042b9117b9d1mr9805278pgw.238.1665256099267; Sat, 08 Oct 2022 12:08:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665256099; cv=none; d=google.com; s=arc-20160816; b=AwH+zHzQ2Kdf96Ty7N0i++nKzyFrZzdTMkOwDX+LRbl1dgjBnmoQEbP9IL77n4/32i hgMJygWmi+q5q2W1OBz6ZVsjz4EhXmymfFKjj0+GLG/sURTxK+tPrHXpXSjwid3P3qg5 N8CyP0rOrEbVWXjsoqJ7mq6RGYJRv+gUiMyb3EGgbBSUaZ1FMsRlrvCfnqoxrEDbbc6k tqcMhnh7fjgBSk9GcBk8TYQlH8nFmZRDNHRCiTZMHmraH5hDIGXf0X41MPCFDw6D5Pvu s+w3FjLh/TiKcWAzzMR7xNIR/3jQDxlbS9SGCzQil+uBEhOfr+Zb74o3JLkhNgbYSI/U Q8Eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:message-id:date:cc:to:from:subject; bh=H56n80P/IprP/d9LhyMvOJWcZQdh8yHPIgzaSQ4bSYk=; b=QP5tkgYrQYv2XpXbRKoyuhxH13HpEPdgKLIglf1IFZDw18JhORIe+i4R2eamaLXJQV r4ENKZO8bwH8P16SUuFwgo6ntfYt6Araq20NuJRRJgh43dvWsVXXAT3rNCxmZwKTVFgR ANk3uXwI+xPXK2wj7HYDIAJwXGhR5jwt0ak1wBOgrMnCtvh4ZUxQls0HuXKPVGiiM3kT 2syIDf0thsMgsLvY5tkuOLhJsnqUpLjz3z1rb25wdRkXyi9b5ZVjfn9t73QZ7UCMjYmA wxQjza7XqWyUVYQobP264eArjAKpt80CpTbet/U4Niz4nlUU2yYrhqfZB6mUVM3IqPPY BT3A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r31-20020a635d1f000000b004413937eeadsi5990363pgb.178.2022.10.08.12.08.01; Sat, 08 Oct 2022 12:08:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229695AbiJHTAJ (ORCPT + 99 others); Sat, 8 Oct 2022 15:00:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229761AbiJHS7r (ORCPT ); Sat, 8 Oct 2022 14:59:47 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B572025F3 for ; Sat, 8 Oct 2022 11:58:33 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 622E2B80BA9 for ; Sat, 8 Oct 2022 18:58:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E4DA1C433C1; Sat, 8 Oct 2022 18:58:30 +0000 (UTC) Subject: [PATCH] SUNRPC: Fix crasher in gss_unwrap_resp_integ() From: Chuck Lever To: trondmy@hammerspace.com, anna.schumaker@netapp.com Cc: linux-nfs@vger.kernel.org Date: Sat, 08 Oct 2022 14:58:29 -0400 Message-ID: <166525550985.1954655.13884581337321315995.stgit@morisot.1015granger.net> User-Agent: StGit/1.5 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org If a zero length is passed to kmalloc() it returns 0x10, which is not a valid address. gss_unwrap_resp_integ() subsequently crashes when it attempts to dereference that pointer. Signed-off-by: Chuck Lever --- net/sunrpc/auth_gss/auth_gss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sunrpc/auth_gss/auth_gss.c b/net/sunrpc/auth_gss/auth_gss.c index a31a27816cc0..7bb247c51e2f 100644 --- a/net/sunrpc/auth_gss/auth_gss.c +++ b/net/sunrpc/auth_gss/auth_gss.c @@ -1989,7 +1989,7 @@ gss_unwrap_resp_integ(struct rpc_task *task, struct rpc_cred *cred, goto unwrap_failed; mic.len = len; mic.data = kmalloc(len, GFP_KERNEL); - if (!mic.data) + if (ZERO_OR_NULL_PTR(mic.data)) goto unwrap_failed; if (read_bytes_from_xdr_buf(rcv_buf, offset, mic.data, mic.len)) goto unwrap_failed;