Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp845698rwi; Mon, 10 Oct 2022 07:58:49 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4hn/nGIZNWSjDW/Dg1M9TwIS3BuJalYCw79AbL7ozJqGWEvvZv2zPvLwmB8AS1MXlhixVt X-Received: by 2002:a05:6402:3806:b0:450:bad8:8cd5 with SMTP id es6-20020a056402380600b00450bad88cd5mr18564993edb.305.1665413929509; Mon, 10 Oct 2022 07:58:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665413929; cv=none; d=google.com; s=arc-20160816; b=cYj07d0iXfu1WVoOXSj3N/dMKce0lNIsnukQQ2OjOilAeW3nmCoDE0lowH635PKbHK A6UDVA++IBx/edqrfgxo8/DdC3N//JOCQBg/8nMH1uyD6qzTq8c/Y6TxEU/hcFXC4rWl m+aGwdCni3dvnHwGR++FY8AGN2KVogsUmSlVzxeIMYdLHUiJONeC7B7t/wlE5malujsk OokWR3fT/wVRZ+ly70AD2W+lc1e+onb6PD3/Aylxjo2ulpA4YiTZjy38H1RVyYBFyuxd Zdu9RPy8aQ4nRLbFvzblzcTSfcCDEfFqOLwhvVduUe4NhMWxw3Z5DMq7p5S2lmGFR8CD Le8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=tWNv+XnhPuQn1XgzzrVulGQFEtbR6OyT4JppMuYKiQw=; b=Scr4XQPVQtZkDResEk6+Jt0F9VuHjXFJGaeBS2cfwAMBXIjDoaRSPhLh1hjtOHS67x RWzEdBoUItaVYNWgIISV7sJVIflIV6Z9ovNSEY3HCtV6mNO6zmp823GR4B/MD6sTxfxM m3qSrv52U0uo39fLFhfO93uhTXObmpUnEicWARNe2QeSITckAfpVIOJGLhXfEI4JYRjx nD+QFfLfUwvg9FOIy9SM5OgWIGaqBNI3lDIuvuiXaZl2pSnvV6r72ymIt+knoJAromtx 98Trg+CX1NcNcTytEBke0aMqJdGrfYZy1f44iYZHLAKGqxDGuPVCbJbqkBHsrrdI6qB9 qEnQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=eZBc+Hpm; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z6-20020a170906270600b007807e613e5bsi9380173ejc.933.2022.10.10.07.58.12; Mon, 10 Oct 2022 07:58:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=eZBc+Hpm; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230002AbiJJO4s (ORCPT + 99 others); Mon, 10 Oct 2022 10:56:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37284 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230099AbiJJO43 (ORCPT ); Mon, 10 Oct 2022 10:56:29 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84A8074CD5 for ; Mon, 10 Oct 2022 07:56:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=tWNv+XnhPuQn1XgzzrVulGQFEtbR6OyT4JppMuYKiQw=; b=eZBc+HpmcXRD111FNIdfAWNvju 46p9gu/QtXygXPlcqIdmVLL2d4uyUhRBhBH3UsKFtRs1ATyX7rBL5xvrUniGPZDXcb7SMo70eHHeM BZ8HYA24fkAaNACq6sGJremKkQ1xqVimLXyr0aYf0H2YHUktzDUnJs0N1Kl8LrhWFtG3T1VG4xKHj KUOCbtqk6hIvJ3vQ3RjKhk/ruGSXWe1UtQFSS2lgp/fqCuPqi0ovqvMXeeOkZerl7gzBA4Me/oIQe mftil8RYHLlBACagMOpCXp+XgzV9VdPa2OEc+Oh6+7ElDmK2VWIFgK9VtPOVSfQD1rdlhBJEcWdpQ REFxA0Ww==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ohuBl-001Gre-PS; Mon, 10 Oct 2022 14:55:29 +0000 Date: Mon, 10 Oct 2022 07:55:29 -0700 From: Christoph Hellwig To: Guillaume Nault Cc: Trond Myklebust , Anna Schumaker , Chuck Lever , Jeff Layton , linux-nfs@vger.kernel.org, Paolo Abeni , Benjamin Coddington Subject: Re: [PATCH v2] sunrpc: Use GFP_NOFS to prevent use of current->task_frag. Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Mon, Oct 10, 2022 at 01:41:57PM +0200, Guillaume Nault wrote: > However, ->sk_allocation isn't used just by the memory allocator. > In particular, sk_page_frag() uses it to figure out if it can return > the page_frag from current or if it has to use the socket one. Well, that just means sk_page_frag really needs to look at PF_MEMALLOC_* as well. So instead of reverting the proper change please fix that. A helper that looks at sk_allocation and current->flags is probably the right way to deal with that.