Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp1769373rwi; Mon, 10 Oct 2022 23:21:43 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5lWQjtdtlGGxz4T20805Txr/rLbKrCZPUVtqPF47DoEPaxXnhQQdoxw2OO2hkQzDMpJcLq X-Received: by 2002:a17:907:7b93:b0:770:1d4f:4de9 with SMTP id ne19-20020a1709077b9300b007701d4f4de9mr17382115ejc.201.1665469303024; Mon, 10 Oct 2022 23:21:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665469303; cv=none; d=google.com; s=arc-20160816; b=qo3FjrmYhEoiObDrTMQSMZZ66/xBzn8Z5gcDLvbZf5JkVtgN2dpj7FUabztTHeXdc2 2sBG6gwZld60CHhFBwI8hDghTxz3J64Po2aIqhLRfzD4s+TuZIH8XHdmiW1w5YPq0mPx 7AVK+g939VX8UQQpkNhPCSz55jA/j42s1rz5MpH7NeRZYmYDrFW9pH5ChOxyAD/Xm++U Ul1bDlm9qo/EBDtCC4gPH4T/TpRAtrGDEf1EwRM1VmAkMwvzkgvQq5ahUF4HS/OU8pZs c/jm7Ob3ACxhkKcFRZBRIPqWAhy7xgde6J1wjejCjc8fGo0jxGo6SiOFX2n6Z1P+TclQ kzlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=SDS0smZvOqwyP3wjoXD24/KXAf+DoPR5kwswdgy+J38=; b=Jtr0HoLleezeBnFQnegKWJ5UVa33OesDNp6HxskbggKSbo5Ztxl0OHspIoyznv9I5O OpB+qgvwP/CX7coJAz8B/smAdNfwpBs5T4BSz14oIz7MQt/GfxXjQZpCuPfGYGL0fw0g SS61T/GSz91aONUEYV9i4wfGx6X3VGwbx2ogXsDuc9mWJgS2TA68QNNu1I5sgorsVrvA T9dIqWCrLghchxW1hTQRXUNXbZZe+r1GXjMJcTF+Tcrr2hxac5gXH+Oze+hrgfSBXRQ8 TG5Fssfb5V0tNqLZPsMYFY1lWDUcGjiiDFoNI12FySud2iScu9jdOs1TlJX8StKLU7c2 j4SA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=xpKS1EEb; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dm17-20020a170907949100b0078d00203ab4si13612293ejc.691.2022.10.10.23.21.08; Mon, 10 Oct 2022 23:21:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=xpKS1EEb; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229481AbiJKGSp (ORCPT + 99 others); Tue, 11 Oct 2022 02:18:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229779AbiJKGSa (ORCPT ); Tue, 11 Oct 2022 02:18:30 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3191287F9A for ; Mon, 10 Oct 2022 23:18:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=SDS0smZvOqwyP3wjoXD24/KXAf+DoPR5kwswdgy+J38=; b=xpKS1EEbSbs8KcIPz3wBBm124s JUr5sdGgqcJSIhcUKknLW9+KccbjBQVzsJyemObB5n4xWOwJYV8qbF0WKifErWgXVuY4TXxx60nVS ia4bMXeKKNLl+JfInVXx4vO1BFkYvZtT0EsfwcfhSb0Xj2YF0MnzqZbNwbcyQdNiHzMO3nBQ6ZiWC GfWObLvRD1OpPAQkOTZptneXe3cVOPAspoxntqGm0xq5PJvmygP00CBJxm50SOEwKBSfHnVGXl7y/ z3qFRVdoFsZlYgbes3AusqnHAXpTB8GLu5FtgQ2U915sDSkDEx0PrcIQHxIo5Nfe15PF8lUDKN6Eb 76YTVyYg==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oi8ap-003OjD-Fa; Tue, 11 Oct 2022 06:18:19 +0000 Date: Mon, 10 Oct 2022 23:18:19 -0700 From: Christoph Hellwig To: Guillaume Nault Cc: Christoph Hellwig , Trond Myklebust , Anna Schumaker , Chuck Lever , Jeff Layton , linux-nfs@vger.kernel.org, Paolo Abeni , Benjamin Coddington Subject: Re: [PATCH v2] sunrpc: Use GFP_NOFS to prevent use of current->task_frag. Message-ID: References: <20221010165650.GA3456@ibm-p9z-18-fsp.mgmt.pnr.lab.eng.rdu2.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221010165650.GA3456@ibm-p9z-18-fsp.mgmt.pnr.lab.eng.rdu2.redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Mon, Oct 10, 2022 at 06:56:50PM +0200, Guillaume Nault wrote: > That's what my RFC patch did. It was rejected because reading > current->flags may incur a cache miss thus slowing down TCP fast path. > See the discussion in the Link tag: > https://lore.kernel.org/netdev/b4d8cb09c913d3e34f853736f3f5628abfd7f4b6.1656699567.git.gnault@redhat.com/ As GFP_NOFS/NOIO are on their way out the networking people will have to do this anyway.