Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Colin Ian King <colin.i.king@gmail.com>
CC:     Jeff Layton <jlayton@kernel.org>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] NFSD: Remove redundant assignment to variable host_err
Thread-Topic: [PATCH] NFSD: Remove redundant assignment to variable host_err
Thread-Index: AQHY3OZN5N4Ak51WjkytHVUZefVuva4JO5gA
Date:   Tue, 11 Oct 2022 14:06:47 +0000
Message-ID: <ECDFC360-1397-4C3E-AAC6-7FE532E8167C@oracle.com>
References: <20221010202423.3221664-1-colin.i.king@gmail.com>
In-Reply-To: <20221010202423.3221664-1-colin.i.king@gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?O+Khzvz1M8M6Z0QnDWD1lSQePmI9Xdj5sO5hCJHRbwNY4oBHSNea2PGDu7Nu?=
 =?us-ascii?Q?ofRHCrI0QsZchSzmtscQzI/YY+caPP3PZLzLe8qi4WkXUNvQ5l7WntzJ5Lna?=
 =?us-ascii?Q?6V7q7FeQgEcKMWTdKHoCFYslhspmFpFCAcFfcq2i1x4DBbpg0XGVyH4m8tSv?=
 =?us-ascii?Q?yULM24jqoPiTdIcYFTQed/a4VBknJpGN32N/L+Zua4QF/XgB17PvBNdzJTkX?=
 =?us-ascii?Q?fts/CQpN/qqldnuX5SkKfv5qmn6ffWaycoY/rU1HeHv8hnH4/jbHoQLQvDsj?=
 =?us-ascii?Q?zcKedQOWXQBBOlWZwdd2wIRcq9zheIcIkWlnzRWB+b5rJp56JfrxEj71yNYY?=
 =?us-ascii?Q?Czsk9rmwNAezFrMBoELot4d2srHlBOm1Tb4QCRiqZOur8Rw4v65ISEVsiUmC?=
 =?us-ascii?Q?QqjMG0q5ZKAZclA4R065OWh6o5wKn2envCb/SKzpIDgZ6ksnVuN0MuU43OLr?=
 =?us-ascii?Q?dKmjAYxx8+tzj59UKrLAXWFnanP8g2L2bZBr+T6MYrpsxsGi1P9oRsGkljiz?=
 =?us-ascii?Q?fvDa+hV3vyS3LnJgEhzEpnx+PLBZEG0w9jbFqDzZew6160BYvRy5aUn1K2k0?=
 =?us-ascii?Q?fzCMp2TbaHQyGG0+Fhricc9TyLP8iyZ+GHKWrtWDC0W+bUdVVpALxbGhNVQC?=
 =?us-ascii?Q?43ZpuOT/x6Em5d0X4/CIwbofUB4dVshSrDmC4htQgE98KNiDqyDpXkkzZjI4?=
 =?us-ascii?Q?Wfiwg59CzaJxmsmMnp3VrBIZq3xCVk/vCu3MCCIfU/jkbmeakjFhTaqy9ltV?=
 =?us-ascii?Q?oBBGYjl1YWLaWfk5wIoVlaQyXtOpieCS+Ny8UhjnrKh3v0OiEXXLGRJWmttc?=
 =?us-ascii?Q?Ii6MTnEi+WqAdaaJle72KZJGVCvysU0TATEdt2fe6c8fBbOOpYpSedWw2dQZ?=
 =?us-ascii?Q?TDeqgH9NWQNnW0udwleB4QEYelBy5+TBRnZB4uzW7dYjslUAIHQIeiRSJrQm?=
 =?us-ascii?Q?2oDEWcTlHe1JYyNgEqtyiLIxQ6qIQ7ajJ0FhnewSTWwokZ06RdACCYUIBj5I?=
 =?us-ascii?Q?rtzam2TJozAJVD5yu8Y1lumundi/EgzeOI5ekUGoDhZxyeYQr6BuH5OaXewu?=
 =?us-ascii?Q?s0uS13Q3jvHtxOXGoS+UTwvKQgsoV7WaAUqDSbAkOGw0vWk7lHeH+uw/ay8Q?=
 =?us-ascii?Q?RbyLi8NGxLIf+a0cHuM4IJdxy0V+GDYmQ74XMqc/oqsfeF2U9hNiqCfhH+jr?=
 =?us-ascii?Q?YG0sj5QYqyUrEtzQxnRrWmHmK+xUpYElb2EL5aC3wzSpV6O44BveCOQ425/1?=
 =?us-ascii?Q?wfDZO00rvREfkXDOf9bx4wiyike6pk0/9QoLTat9IFw3J++fZiIFjzKkMuJo?=
 =?us-ascii?Q?MqdXbaJnzuObKSn8V/mJxT6VLimBj3fbdvj7Q9GOitJuYGPz2d7ovvePJzel?=
 =?us-ascii?Q?PlMkwls1DPxsqujYrOUO8Xi0L0kr6EeL5xUTy88m+mlEsSZ3+/0rKlobxQ7X?=
 =?us-ascii?Q?tACbBVe7wt2LRR3T7TTtwgYomq+NPJ0BDhnayNTqlzstwJsmYjt1XsivNszn?=
 =?us-ascii?Q?StBaOD0irjwdis/TR1N2G2R7F/elhXkj44zYbwxX+TXAkb7NxrOenpwSH3H9?=
 =?us-ascii?Q?n0kVIq3X3uvj0U7yyp4xc5LWC676vKYABk9tA1LLTunpngFPpHgpSMlq4pj1?=
 =?us-ascii?Q?fA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <B1F51A122D49E541B84F32B1AB7E9F50@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 51df1729-8970-4836-42be-08daab91d5f0
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Oct 2022 14:06:47.3778
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: V63htRexjfxh7RLLryFJoHhQcgwWMgbciOLYBn6d6FscbSVjbLB10ih365MT91NQezqykYF8UEzlTxNRGzN3qA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB6372
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-11_08,2022-10-11_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 bulkscore=0
 adultscore=0 malwarescore=0 phishscore=0 suspectscore=0 mlxscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2210110080
X-Proofpoint-GUID: PTy_MvWXdbjcDS23Wxf29GkhqVG1Jorw
X-Proofpoint-ORIG-GUID: PTy_MvWXdbjcDS23Wxf29GkhqVG1Jorw
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Oct 10, 2022, at 4:24 PM, Colin Ian King <colin.i.king@gmail.com> wrot=
e:
>=20
> Variable host_err is assigned a value that is never read, it is being
> re-assigned a value in every different execution path in the following
> switch statement. The assignment is redundant and can be removed.
>=20
> Cleans up clang-scan warning:
> warning: Value stored to 'host_err' is never read [deadcode.DeadStores]
>=20
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

Applying this for nfsd's for-next (not yet public). Thanks!


> ---
> fs/nfsd/vfs.c | 1 -
> 1 file changed, 1 deletion(-)
>=20
> diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c
> index f650afedd67f..5093ae788f53 100644
> --- a/fs/nfsd/vfs.c
> +++ b/fs/nfsd/vfs.c
> @@ -1304,7 +1304,6 @@ nfsd_create_locked(struct svc_rqst *rqstp, struct s=
vc_fh *fhp,
> 		iap->ia_mode &=3D ~current_umask();
>=20
> 	err =3D 0;
> -	host_err =3D 0;
> 	switch (type) {
> 	case S_IFREG:
> 		host_err =3D vfs_create(&init_user_ns, dirp, dchild, iap->ia_mode, true=
);
> --=20
> 2.37.3
>=20

--
Chuck Lever