Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Jeff Layton <jlayton@kernel.org>
CC:     Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] nfsd: ensure we always call fh_verify_error tracepoint
Thread-Topic: [PATCH] nfsd: ensure we always call fh_verify_error tracepoint
Thread-Index: AQHY3mqFytLThGlQ20+5ABlFzwJE764MgSUA
Date:   Thu, 13 Oct 2022 16:15:21 +0000
Message-ID: <60075DF7-96ED-4636-8E02-4A322D9EB522@oracle.com>
References: <20221012184254.30539-1-jlayton@kernel.org>
In-Reply-To: <20221012184254.30539-1-jlayton@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/VYqGCy86F2zujCItGzE6Z4iuBVyyyq022r2FIxru56GxsHBkm2QSPsYx5Ge?=
 =?us-ascii?Q?XiltyUur2cMpOyO31asVhkuwSdGHCIJwDUT+gJrValpodn0YI+OnW//yMFsN?=
 =?us-ascii?Q?PrJ3PCO29KdoqscLblabv5MzF1TUuDrBXlMOk4N3uMvEJ+3+TaF2hotME40l?=
 =?us-ascii?Q?sIai1dUmlX3zLGxR/YawcGAz6jykYhj2o5fA4vjJjKs4gzeNGulzS+uEpwI1?=
 =?us-ascii?Q?pym4B3zqqepx3XrmzukmsseET1KoGDGvlKtfgw+043fmHnJpLFrKC5cIfZd2?=
 =?us-ascii?Q?PMD2yYAp2Er08QBS2T5hhooP4gBYbve49O4i3PnwK9lT43u8h9yM0Lk0HBUI?=
 =?us-ascii?Q?QMdumUskAYeXbW0ODwPhaxWAmIna/hlpI+emXYwi4w2rvnzFIW6NdCh+6wqM?=
 =?us-ascii?Q?yN2thKLqiBofAFWBU6Csa+L8K3kN0eaqUq94+wUiH5iDW20UA2L0PQNmRktt?=
 =?us-ascii?Q?eUjzv5LFpVUJCI37tqujiXAw0pUoezcLi07PdJ8PyTGittUTeHvR/Z3pfLeO?=
 =?us-ascii?Q?cCreeYm7op4bcXjd1AiFBs/r/oQl0SKgIqwb76ubcRIoaGi+3X1zA5PT4Zso?=
 =?us-ascii?Q?QvQfboWXWyb1s8+aDC/xnKtQHJ//8uEDZte4nHDYpsXRnkb+VGdvWHGSS8rN?=
 =?us-ascii?Q?UAQOjEnTKTY+sWaR4B31e5kbu07SPRMmEFzMNLD6Qv3udhglFTIvfC6GDhpx?=
 =?us-ascii?Q?FxFXYOSW1XUySBdL6NwFyfNN6W3yR+NQ9FL5Xg4D1Ez7mN69bHjqgXvGy/JH?=
 =?us-ascii?Q?RPt6LCcsCxf+o6pnHJOUhxTZTb0VdNsYOQ83EsGDDS2TEaxEnPNHcM1E24aw?=
 =?us-ascii?Q?wDQpcWymQpyKpEHZfCbCuRPa9pglXezyHQ4wI9kD+BnpKUayF/YeLuMYLA4R?=
 =?us-ascii?Q?86BA9yanYrLW3c24Xb5qWb+OHrg5VIIFjYwDv/iEwNgis7oV+gmBPr0E0VJp?=
 =?us-ascii?Q?9O7+gQvvO0RNKG0lRdPB4mkoDi8mbPSRcR+7Yax5PLDA+RaXPk0PAc21DvXA?=
 =?us-ascii?Q?BmoFJfu+Xa3fbfzPvNS3gOgV3iHRCiGI16SdUIXA9h+cuV0leLIUMnaaTm9I?=
 =?us-ascii?Q?Dak4ki8eUPU6OnEde8VaWu/73mul8txcN0TiZAXslpvWxKXwaVxy88zQWJnI?=
 =?us-ascii?Q?4ULeorsZaci0OQW6dpJktJRpzDrDuJT8Nb0Pz5dRiI6ddk98SpXOu9Pp6Mvj?=
 =?us-ascii?Q?Gxr26tzl5+nc8giy+NIJbY9ewWX9gjymqAYgNI9o35w87lwpMiqVijw0h3IG?=
 =?us-ascii?Q?EZrauCrxMd3sDfOhhagZyKqEMuDb9h4+X54n4/WNUQfxH6qhEmym4yhi48+T?=
 =?us-ascii?Q?YjdgERnkRhdt5qoP6jQl4WrO/vUa9fFd4PpLTxIrIsfxgfUBfCZzkygYWh+m?=
 =?us-ascii?Q?nTIz5a+yX/KABj7wuc8iRAF1mZOgAH8cPQrGma6l7jEvJdMhmUQDSfZK4SfR?=
 =?us-ascii?Q?/dmsJKcw+pxjEZBmymjdN7b6Y7UWtAVsRRi6gnt/piPub2KqOYikwShZtBU4?=
 =?us-ascii?Q?A5kuQ57uDgMzzH7tLafiFdekYL6MH8oWvIVH58/BVA3thGbP38qpmw7ymkyW?=
 =?us-ascii?Q?FgNCHK1bBR5N4pGZ3+uxlrj1rid76maDhfO2+1mtQQOYRiGBua3YLNEl1SPW?=
 =?us-ascii?Q?qQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1777A755416F3C42992B03FE8DC9F7E2@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 115e9b65-f581-4695-d245-08daad3620a6
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Oct 2022 16:15:21.3520
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: +hvcSgqxtr8xep0QPTB6BpwdqNd5uZkWsjEBgkya0cud7SJNnkcL/4L760U2bOoIvnA8q7f216s4ZXc2MHJJXg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB6677
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-13_08,2022-10-13_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 bulkscore=0
 adultscore=0 malwarescore=0 phishscore=0 suspectscore=0 mlxscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2210130094
X-Proofpoint-GUID: ZZBW7pa4WJ6vlmVMxFJKEUAlUJgzQdCa
X-Proofpoint-ORIG-GUID: ZZBW7pa4WJ6vlmVMxFJKEUAlUJgzQdCa
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Oct 12, 2022, at 2:42 PM, jlayton@kernel.org wrote:
>=20
> From: Jeff Layton <jlayton@kernel.org>
>=20
> This is a conditional tracepoint. Call it every time, not just when
> nfs_permission fails.
>=20
> Signed-off-by: Jeff Layton <jlayton@kernel.org>

I've applied this to nfsd's for-rc. Thanks!


> ---
> fs/nfsd/nfsfh.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/fs/nfsd/nfsfh.c b/fs/nfsd/nfsfh.c
> index 9c1f697ffc72..43bb34f1458e 100644
> --- a/fs/nfsd/nfsfh.c
> +++ b/fs/nfsd/nfsfh.c
> @@ -392,8 +392,8 @@ fh_verify(struct svc_rqst *rqstp, struct svc_fh *fhp,=
 umode_t type, int access)
> skip_pseudoflavor_check:
> 	/* Finally, check access permissions. */
> 	error =3D nfsd_permission(rqstp, exp, dentry, access);
> -	trace_nfsd_fh_verify_err(rqstp, fhp, type, access, error);
> out:
> +	trace_nfsd_fh_verify_err(rqstp, fhp, type, access, error);
> 	if (error =3D=3D nfserr_stale)
> 		nfsd_stats_fh_stale_inc(exp);
> 	return error;
> --=20
> 2.37.3
>=20

--
Chuck Lever