Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <355a0d843130bad8fc743b19fec2b829aed6b326.camel@kernel.org>
Subject: Re: [PATCH 1 1/3] SUNRPC: Remove unused svc_rqst::rq_lock field
From:   Jeff Layton <jlayton@kernel.org>
To:     Chuck Lever <chuck.lever@oracle.com>, linux-nfs@vger.kernel.org
Date:   Mon, 17 Oct 2022 08:55:33 -0400
In-Reply-To: <166593521604.1710.10648202421284171508.stgit@klimt.1015granger.net>
References: <166593521604.1710.10648202421284171508.stgit@klimt.1015granger.net>
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Sun, 2022-10-16 at 11:46 -0400, Chuck Lever wrote:
> Clean up after commit 22700f3c6df5 ("SUNRPC: Improve ordering of
> transport processing").
>=20
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---
>  include/linux/sunrpc/svc.h |    1 -
>  net/sunrpc/svc.c           |    1 -
>  2 files changed, 2 deletions(-)
>=20
> diff --git a/include/linux/sunrpc/svc.h b/include/linux/sunrpc/svc.h
> index daecb009c05b..3b59eb9cf884 100644
> --- a/include/linux/sunrpc/svc.h
> +++ b/include/linux/sunrpc/svc.h
> @@ -311,7 +311,6 @@ struct svc_rqst {
>  	struct auth_domain *	rq_gssclient;	/* "gss/"-style peer info */
>  	struct svc_cacherep *	rq_cacherep;	/* cache info */
>  	struct task_struct	*rq_task;	/* service thread */
> -	spinlock_t		rq_lock;	/* per-request lock */
>  	struct net		*rq_bc_net;	/* pointer to backchannel's
>  						 * net namespace
>  						 */
> diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c
> index 7c9a0d0b1230..d2bb1d04c524 100644
> --- a/net/sunrpc/svc.c
> +++ b/net/sunrpc/svc.c
> @@ -638,7 +638,6 @@ svc_rqst_alloc(struct svc_serv *serv, struct svc_pool=
 *pool, int node)
>  		return rqstp;
> =20
>  	__set_bit(RQ_BUSY, &rqstp->rq_flags);
> -	spin_lock_init(&rqstp->rq_lock);
>  	rqstp->rq_server =3D serv;
>  	rqstp->rq_pool =3D pool;
> =20
>=20
>=20

Reviewed-by: Jeff Layton <jlayton@kernel.org>