Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp4635118rwi; Mon, 17 Oct 2022 08:43:42 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7nGUJQ6oziCqtc2nzrveoQ5Thlia8KTJTy7v7cdl6N4kYICJ1rAiYJQguVEm3cwNuK+XFV X-Received: by 2002:a17:906:ced1:b0:78d:4448:e96f with SMTP id si17-20020a170906ced100b0078d4448e96fmr8847926ejb.490.1666021422257; Mon, 17 Oct 2022 08:43:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666021422; cv=none; d=google.com; s=arc-20160816; b=Sf26g60hEgMHKV3Ky0sOJn1bSW18GqP0HlgcMI7BVOWK8+g6zIC2A/K91BWfcWVmcJ LN0oObsTdNZpcLsHo1v/mR6GEw2p3XcETG8KgelzTsKvoiQRl4NymPogutefUnaF81KV 231yBrsPaUgiunuGuOMrufu6T9XmlKAi7MYD+I6d1MqrwYDcuCH4AXyv45f7W1a5P1t9 TTRozgwcwgJ64T8xE7m800oIllJ38066cXn7usjNJOxRzxFq7N1d0O9soh4zJrpNSMB5 vkpLPC3fqvMKGnN6qR1kJ91I8YHiVCu1SbcDqfG4IHH3kFOmsX7m3sFw7J/U2BAJqMGN 7zAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:message-id:date:cc:to:from:subject; bh=z8ulLWqHfDfCkxQqRBcJnNhDv2dJFa5mY+tYc/ppPP0=; b=foUJbEWfnrVOEg2Zcu1fhWwdMr22CUESbWxea2iczHZr8iUlQqe7s/X24KOj27ZxtX YW/bN+/T6/f1v4CTDanMnXWeODzSs5kyrUVGB+u3zAKlTI3+rJzII2gYeG5eN2plvMkJ yaFjO4dYjPNh9PJSMQlcp0OXhcBePF7RPfMVrEb9/Try3fvLgtvbdLmFCk2FRiJNQkRF F+3KzfOu1gSea9L2WP2s16tf2yiejuWhsW8Zzlgkut98x1n34ivgR3Xv8zpIMYw0lBjH Mvb0Q45oBbm6jxfpX1jI7trNdJjvmvyZT1joBcAGFs/c6Qh7FrMgKSxvLOBn19orjrpQ QiIg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hs21-20020a1709073e9500b0073d8b93700csi9043398ejc.165.2022.10.17.08.43.10; Mon, 17 Oct 2022 08:43:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231628AbiJQPIM (ORCPT + 99 others); Mon, 17 Oct 2022 11:08:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44480 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231281AbiJQPHy (ORCPT ); Mon, 17 Oct 2022 11:07:54 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60813402EF for ; Mon, 17 Oct 2022 08:07:52 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5768DB818F3 for ; Mon, 17 Oct 2022 15:02:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F3014C433D7; Mon, 17 Oct 2022 15:02:16 +0000 (UTC) Subject: [PATCH v3 0/7] A course adjustment, maybe... From: Chuck Lever To: linux-nfs@vger.kernel.org Cc: neilb@suse.de Date: Mon, 17 Oct 2022 11:02:15 -0400 Message-ID: <166601838800.1714.17970169995665888062.stgit@manet.1015granger.net> User-Agent: StGit/1.5.dev2+g9ce680a5 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org I'm proposing this series for v6.2 (for-next). I intend to open this branch soon, now that the v6.1 merge window is closed. For quite some time, we've been encouraged to disable filecache garbage collection for NFSv4 files, and I think I found a surgical way to do just that. That is presented in "NFSD: Add an NFSD_FILE_GC flag to enable nfsd_file garbage collection". The other major change in this set (previously left unmentioned) is reworking the file_hashtbl to resize itself dynamically. This reduces the average size of its bucket chains, greatly speeding up hash insertion, which holds the state_lock. Comments and opinions are welcome. Changes since v2: - Converted nfs4_file_rhashtbl to nfs4_file_rhltable - Addressed most or all other review comments Changes since RFC: - checking nfs4_files for inode aliases is now done only on hash insertion - the nfs4_file reference count is now bumped only while the RCU read lock is held - comments and function names have been revised and clarified --- Chuck Lever (7): NFSD: Pass the target nfsd_file to nfsd_commit() NFSD: Revert "NFSD: NFSv4 CLOSE should release an nfsd_file immediately" NFSD: Add an NFSD_FILE_GC flag to enable nfsd_file garbage collection NFSD: Use const pointers as parameters to fh_ helpers. NFSD: Use rhashtable for managing nfs4_file objects NFSD: Clean up nfs4_preprocess_stateid_op() call sites NFSD: Trace delegation revocations fs/nfsd/filecache.c | 79 +++++++++++----- fs/nfsd/filecache.h | 4 +- fs/nfsd/nfs3proc.c | 10 +- fs/nfsd/nfs4proc.c | 42 ++++----- fs/nfsd/nfs4state.c | 220 ++++++++++++++++++++++++++++++-------------- fs/nfsd/nfsfh.h | 10 +- fs/nfsd/state.h | 5 +- fs/nfsd/trace.h | 58 +++++++++++- fs/nfsd/vfs.c | 19 ++-- fs/nfsd/vfs.h | 3 +- 10 files changed, 304 insertions(+), 146 deletions(-) -- Chuck Lever