Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp4653263rwi; Mon, 17 Oct 2022 08:58:33 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4OQgmIW6somHMeIMunPxMXYPbHaMZdXkgGOjg6eib//ICfdMhlcr7OMqt2jnIqTkhC6cQZ X-Received: by 2002:a17:907:760c:b0:78d:b37f:5ce4 with SMTP id jx12-20020a170907760c00b0078db37f5ce4mr9004839ejc.50.1666022313631; Mon, 17 Oct 2022 08:58:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666022313; cv=none; d=google.com; s=arc-20160816; b=rAbc012ruu/NULnjrxG98M7ke0qYIOXXjghCpBl/cD+uFf4RfmveLfHBxhOdc6fxLW NakxO1nVJttSeWRH3jALOJfSoLiF2Lu6DPDcDGR6d6kcyi6UwPBfsYT6GmNXjQkht5HE nnWDWrT/w8Fa+gXT2uGa1zyGtp6OtR3BChy0o+lSpNXt/gWxDLm/l+SjwgcnXsbRFTfH WhPVyLvmqdn9dKF+RFeiIKq8IZdJROUcPlkKLP5BEtAgpM2iX1BqENsMCZsMuxB/RM7S 3SEHV6s9/2vy6gp/YL6+zjoNwQ7zyetEXQIShuYHMbCV9L/kJgk7/SWy7h3qyn2Ca2bA EfzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:cc:to:from :subject; bh=CC1Yh29Lklx2iHcYmxLjSZzwyhiHcAWyDgrh9Gdj8K0=; b=CRsyhnL+1E9pILoe0YqJ1LGh7qvpR/m7cF7rrXWsmYrx0/Ug4IWrCTHB4eGRDNNc/3 xYWvojfpJ8ALc+sFF7Y5OqYXvRQTmwsd44xddRU8aj//30AlHNGbj8VFvLcG/jNlWl/Q +E7BPobZDy+nZe2QKGP8zphJHFGPwQODELX20Abc4FeHwSJNZ7l4SWPNxh5XUg/6JiEW wP0fPD6nAN+s4Bc+3SDBIyWTC0KxNx9qetBCShODr0FywqssfVaXtNKwI3iK5q7XCr2o Uh55Ik4Ek9VDjtroEHlE7j53cncJSRwtS9KiSzGC0WVKwCVC3hiZ2AsiRof/mXFsmFNy vtuw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b25-20020aa7c6d9000000b00446b33b356asi8329818eds.502.2022.10.17.08.58.08; Mon, 17 Oct 2022 08:58:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230129AbiJQPEu (ORCPT + 99 others); Mon, 17 Oct 2022 11:04:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40152 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232006AbiJQPEe (ORCPT ); Mon, 17 Oct 2022 11:04:34 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B7D419FFB for ; Mon, 17 Oct 2022 08:04:32 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 236C361177 for ; Mon, 17 Oct 2022 15:02:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 66969C433D6; Mon, 17 Oct 2022 15:02:42 +0000 (UTC) Subject: [PATCH v3 4/7] NFSD: Use const pointers as parameters to fh_ helpers. From: Chuck Lever To: linux-nfs@vger.kernel.org Cc: neilb@suse.de Date: Mon, 17 Oct 2022 11:02:41 -0400 Message-ID: <166601896138.1714.4183838643878125201.stgit@manet.1015granger.net> In-Reply-To: <166601838800.1714.17970169995665888062.stgit@manet.1015granger.net> References: <166601838800.1714.17970169995665888062.stgit@manet.1015granger.net> User-Agent: StGit/1.5.dev2+g9ce680a5 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Enable callers to use const pointers where they are able to. Reviewed-by: Jeff Layton Tested-by: Jeff Layton Signed-off-by: Chuck Lever --- fs/nfsd/nfsfh.h | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/fs/nfsd/nfsfh.h b/fs/nfsd/nfsfh.h index c3ae6414fc5c..513e028b0bbe 100644 --- a/fs/nfsd/nfsfh.h +++ b/fs/nfsd/nfsfh.h @@ -220,7 +220,7 @@ __be32 fh_update(struct svc_fh *); void fh_put(struct svc_fh *); static __inline__ struct svc_fh * -fh_copy(struct svc_fh *dst, struct svc_fh *src) +fh_copy(struct svc_fh *dst, const struct svc_fh *src) { WARN_ON(src->fh_dentry); @@ -229,7 +229,7 @@ fh_copy(struct svc_fh *dst, struct svc_fh *src) } static inline void -fh_copy_shallow(struct knfsd_fh *dst, struct knfsd_fh *src) +fh_copy_shallow(struct knfsd_fh *dst, const struct knfsd_fh *src) { dst->fh_size = src->fh_size; memcpy(&dst->fh_raw, &src->fh_raw, src->fh_size); @@ -243,7 +243,8 @@ fh_init(struct svc_fh *fhp, int maxsize) return fhp; } -static inline bool fh_match(struct knfsd_fh *fh1, struct knfsd_fh *fh2) +static inline bool fh_match(const struct knfsd_fh *fh1, + const struct knfsd_fh *fh2) { if (fh1->fh_size != fh2->fh_size) return false; @@ -252,7 +253,8 @@ static inline bool fh_match(struct knfsd_fh *fh1, struct knfsd_fh *fh2) return true; } -static inline bool fh_fsid_match(struct knfsd_fh *fh1, struct knfsd_fh *fh2) +static inline bool fh_fsid_match(const struct knfsd_fh *fh1, + const struct knfsd_fh *fh2) { if (fh1->fh_fsid_type != fh2->fh_fsid_type) return false;