Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
From:   "NeilBrown" <neilb@suse.de>
To:     "David Disseldorp" <ddiss@suse.de>,
        Chuck Lever III <chuck.lever@oracle.com>
Cc:     linux-nfs@vger.kernel.org, "David Disseldorp" <ddiss@suse.de>
Subject: Re: [PATCH] exportfs: use pr_debug for unreachable debug statements
In-reply-to: <20221021122414.20555-1-ddiss@suse.de>
References: <20221021122414.20555-1-ddiss@suse.de>
Date:   Mon, 24 Oct 2022 09:11:27 +1100
Message-id: <166656308707.12462.9861114416829680469@noble.neil.brown.name>
Precedence: bulk

On Fri, 21 Oct 2022, David Disseldorp wrote:
> expfs.c has a bunch of dprintk statements which are unusable due to:
>  #define dprintk(fmt, args...) do{}while(0)
> Use pr_debug so that they can be enabled dynamically.
> Also make some minor changes to the debug statements to fix some
> incorrect types, and remove __func__ which can be handled by dynamic
> debug separately.
>=20
> Signed-off-by: David Disseldorp <ddiss@suse.de>

Reviewed-by: NeilBrown <neilb@suse.de>

Thanks,
NeilBrown

> ---
>  fs/exportfs/expfs.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>=20
> diff --git a/fs/exportfs/expfs.c b/fs/exportfs/expfs.c
> index c648a493faf23..3204bd33e4e8a 100644
> --- a/fs/exportfs/expfs.c
> +++ b/fs/exportfs/expfs.c
> @@ -18,7 +18,7 @@
>  #include <linux/sched.h>
>  #include <linux/cred.h>
> =20
> -#define dprintk(fmt, args...) do{}while(0)
> +#define dprintk(fmt, args...) pr_debug(fmt, ##args)
> =20
> =20
>  static int get_name(const struct path *path, char *name, struct dentry *ch=
ild);
> @@ -132,8 +132,8 @@ static struct dentry *reconnect_one(struct vfsmount *mn=
t,
>  	inode_unlock(dentry->d_inode);
> =20
>  	if (IS_ERR(parent)) {
> -		dprintk("%s: get_parent of %ld failed, err %d\n",
> -			__func__, dentry->d_inode->i_ino, PTR_ERR(parent));
> +		dprintk("get_parent of %lu failed, err %ld\n",
> +			dentry->d_inode->i_ino, PTR_ERR(parent));
>  		return parent;
>  	}
> =20
> @@ -147,7 +147,7 @@ static struct dentry *reconnect_one(struct vfsmount *mn=
t,
>  	dprintk("%s: found name: %s\n", __func__, nbuf);
>  	tmp =3D lookup_one_unlocked(mnt_user_ns(mnt), nbuf, parent, strlen(nbuf));
>  	if (IS_ERR(tmp)) {
> -		dprintk("%s: lookup failed: %d\n", __func__, PTR_ERR(tmp));
> +		dprintk("lookup failed: %ld\n", PTR_ERR(tmp));
>  		err =3D PTR_ERR(tmp);
>  		goto out_err;
>  	}
> --=20
> 2.35.3
>=20
>=20