Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <05574fc8-7d4a-e68d-2167-cac6f631e105@redhat.com>
Date:   Mon, 24 Oct 2022 13:48:18 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH] [nfs/nfs-utils/libtirpc] bindresvport.c: fix a potential
 resource leakage
Content-Language: en-US
To:     Zhi Li <yieli@redhat.com>, linux-nfs@vger.kernel.org
References: <20221020063309.3674419-1-yieli@redhat.com>
From:   Steve Dickson <steved@redhat.com>
In-Reply-To: <20221020063309.3674419-1-yieli@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 10/20/22 2:33 AM, Zhi Li wrote:
> Subject:
> [PATCH] [nfs/nfs-utils/libtirpc] bindresvport.c: fix a potential 
> resource leakage
> From:
> Zhi Li <yieli@redhat.com>
> Date:
> 10/20/22, 2:33 AM
> 
> To:
> linux-nfs@vger.kernel.org
> CC:
> steved@redhat.com, Zhi Li <yieli@redhat.com>
> 
> 
> Close the FILE *fp of load_blacklist() in another
> return path to avoid potential resource leakage.
> 
> Fixes:https://bugzilla.redhat.com/show_bug.cgi?id=2135405
> Signed-off-by: Zhi Li<yieli@redhat.com>
Committed...

steved.
> ---
>   src/bindresvport.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/src/bindresvport.c b/src/bindresvport.c
> index 5c0ddcf..efeb1cc 100644
> --- a/src/bindresvport.c
> +++ b/src/bindresvport.c
> @@ -130,6 +130,7 @@ load_blacklist (void)
>   	  if (list == NULL)
>   	    {
>   	      free (buf);
> +	      fclose (fp);
>   	      return;
>   	    }
>   	}
> -- 2.31.1
>