Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Neil Brown <neilb@suse.de>, David Disseldorp <ddiss@suse.de>
CC:     Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] exportfs: use pr_debug for unreachable debug statements
Thread-Topic: [PATCH] exportfs: use pr_debug for unreachable debug statements
Thread-Index: AQHY5UgGkwnmp58/L0OX2xyj/M+Kj64cjjqAgAE8nYA=
Date:   Mon, 24 Oct 2022 17:04:40 +0000
Message-ID: <000A2614-4C72-444A-A1D3-7B259D99C70A@oracle.com>
References: <20221021122414.20555-1-ddiss@suse.de>
 <166656308707.12462.9861114416829680469@noble.neil.brown.name>
In-Reply-To: <166656308707.12462.9861114416829680469@noble.neil.brown.name>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?dkQSLxIVsYO2N2nQuN2kPzottMjKQTQ3vkYu9pfzro6JLhuLvK1DMmKJQecx?=
 =?us-ascii?Q?gG8yfwuY6tEFwZ8SkCQLN7tyYSUX2V9QXVUTr8dL9UmqGTbxbTwt0VTMLKNd?=
 =?us-ascii?Q?ALzwBVFod6Cv1hsEsdXTv2H8M6Ea9Nisj1dtTUZ6rss7WrtgCsHMO7WnCtBw?=
 =?us-ascii?Q?zNADqRVV3SbMD3v62vVCZJu9reb5wO33mGYRRSCBMavYNNugkdqfN2Y8GXqw?=
 =?us-ascii?Q?M8//WhbPJkib2RQo/LJ+94eaxI5HaIU8B9kxM5LzBskR9xDobjYFMslqgiYP?=
 =?us-ascii?Q?gzt6MA7Jx6Q+7mYbcksg7ju6k6NzrTNacGIWNenkCwrlp/1e1awTrFztXPGR?=
 =?us-ascii?Q?aO5nzg1oPu6P0OeVFuICys+35m1+wTPgKv9UCnceaYjOL97Ow3TFcGaiKzqR?=
 =?us-ascii?Q?l8NzcN1DWHWM/VC/PIXim/lat87GDHeRDvlvcOEnkNveI/Z26oKCXUVmkSdM?=
 =?us-ascii?Q?xGpVQB2oYvaHqp9wntEJ6Iys1tUtOlh3TuHdcf3vWfhz87wzgnjT/nQXmN5O?=
 =?us-ascii?Q?8JPpJS+bDDdyGbKbMbkS3vyU7i995jRkeqTF75Fd+3A4RUt8+qNG03ZT2PHI?=
 =?us-ascii?Q?5Q8BtBWui5diNMfgg6gkGzGNLxeVW4lP347Hifcdr4qTLJDUpB/3hiwgTRtj?=
 =?us-ascii?Q?7tGq8vq6olTq0KGT2n3cL+FBV6sq4qC1RsfwHATtRhGzXRwHNXTaYtGJY9V1?=
 =?us-ascii?Q?hrjbofWIkk1F5NXpwn1xNesnqCQWsP3GAMQnFvQVkIplsY72TP99gc2Rq/88?=
 =?us-ascii?Q?PM+bnqBmLWfvPvSKwz/FEmqsKOkwSZd9tYixxUF107m8wgkcSL32o5jG/6ny?=
 =?us-ascii?Q?I+7Tf3V22Nk4kvo9kWHSRN4yheoB+NFRQEE7dLZzKVMGFkxxmPM/01pD7pbm?=
 =?us-ascii?Q?Wf61eNiKgM4w59B9Ia0j04KxK3LrHie2Vit0oHDdx5iYEwsw+KVhIxTK6iNt?=
 =?us-ascii?Q?hHZlI1NgHDsGTiBfTRWNpb2fkL394XrFVTJcGPCq7N49eOvppnAzAdkF1q2j?=
 =?us-ascii?Q?PZkc41mY4IjNDMMmlcex6bwJ1toqS0+klc7ZumEPyLLF+JLKPAF1pZybnpXt?=
 =?us-ascii?Q?PizBCsGx9bm31dnDosydNmhLWl0BOXVKHtGVaq9gF+T8oC2sgutLhLnRr6rx?=
 =?us-ascii?Q?nT0rZm6wLt9k+v4ea7b/VQLO2ffvTvseGvDwulph8HDUaLBLXNtU26jUpXhA?=
 =?us-ascii?Q?wvyhz+rj0YmDlS9I4b5dWNEOo2UCxx08qn2O+CfLl8bVkua2C5h3cuvhHuxF?=
 =?us-ascii?Q?0KNQ1EAtYDSzetcs/3VZxaOgl+LP1qU5ppvdZ04N7tZ9OgsvdI1QUqzu3fhl?=
 =?us-ascii?Q?oIM3DK8qcFQYiQ11TO0nMRLA4vdCsXdqlyaUP0dU7Kcr092v/ggnOmMi7aR4?=
 =?us-ascii?Q?2UcL4sFVZbw6zG0N1cat9KusrpfcwO4dXfh7ECY1yVupZKjLCB+zDk7q3dWG?=
 =?us-ascii?Q?RHOOzzoLDBA6NrBuk0P6jToOjuLMvCtQMrvKkx4ABRwNsiXiQDvd29iOahtF?=
 =?us-ascii?Q?V3p65Nux2oxvEqOnjLWDJ98mnlR6fxQejIOdVZTMLPpO27BZW5LZ/E8UpTVd?=
 =?us-ascii?Q?U/NSdH16+R/csmyyZBhcDa5PpfzzfjjidJe/zLOJjAqx8nB5PFjX/10Vghxh?=
 =?us-ascii?Q?Ag=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <DF001445B7FCE043AE11FFCED9D818E4@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e9365789-1c26-4434-4df4-08dab5e1d6f2
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Oct 2022 17:04:40.4496
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: i8hoszX+gn6CdkGiaxPCz0kzMUEFh35VdaK3MteME7iFtpblrb8Nqjqh8n20CC5ixzjtAUgblfUZeFo5+vkEQA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR10MB6549
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-24_05,2022-10-21_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 phishscore=0
 spamscore=0 suspectscore=0 bulkscore=0 malwarescore=0 mlxscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2210240104
X-Proofpoint-ORIG-GUID: xI42gYaI61JVTCccUnYRDHefKOVW4vK9
X-Proofpoint-GUID: xI42gYaI61JVTCccUnYRDHefKOVW4vK9
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Oct 23, 2022, at 6:11 PM, NeilBrown <neilb@suse.de> wrote:
>=20
> On Fri, 21 Oct 2022, David Disseldorp wrote:
>> expfs.c has a bunch of dprintk statements which are unusable due to:
>> #define dprintk(fmt, args...) do{}while(0)
>> Use pr_debug so that they can be enabled dynamically.
>> Also make some minor changes to the debug statements to fix some
>> incorrect types, and remove __func__ which can be handled by dynamic
>> debug separately.
>>=20
>> Signed-off-by: David Disseldorp <ddiss@suse.de>
>=20
> Reviewed-by: NeilBrown <neilb@suse.de>
>=20
> Thanks,
> NeilBrown

I don't think we're the maintainers of expfs.c ?

$ scripts/get_maintainer.pl fs/exportfs/expfs.c
Christian Brauner <brauner@kernel.org> (commit_signer:2/2=3D100%,authored:1=
/2=3D50%,added_lines:3/6=3D50%,removed_lines:2/6=3D33%)
Al Viro <viro@zeniv.linux.org.uk> (commit_signer:1/2=3D50%,authored:1/2=3D5=
0%,added_lines:3/6=3D50%,removed_lines:4/6=3D67%)
Miklos Szeredi <mszeredi@redhat.com> (commit_signer:1/2=3D50%)
Amir Goldstein <amir73il@gmail.com> (commit_signer:1/2=3D50%)
linux-kernel@vger.kernel.org (open list)

But maybe MAINTAINERS needs to be fixed. There's no entry
there for fs/exportfs.


>> ---
>> fs/exportfs/expfs.c | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>=20
>> diff --git a/fs/exportfs/expfs.c b/fs/exportfs/expfs.c
>> index c648a493faf23..3204bd33e4e8a 100644
>> --- a/fs/exportfs/expfs.c
>> +++ b/fs/exportfs/expfs.c
>> @@ -18,7 +18,7 @@
>> #include <linux/sched.h>
>> #include <linux/cred.h>
>>=20
>> -#define dprintk(fmt, args...) do{}while(0)
>> +#define dprintk(fmt, args...) pr_debug(fmt, ##args)
>>=20
>>=20
>> static int get_name(const struct path *path, char *name, struct dentry *=
child);
>> @@ -132,8 +132,8 @@ static struct dentry *reconnect_one(struct vfsmount =
*mnt,
>> 	inode_unlock(dentry->d_inode);
>>=20
>> 	if (IS_ERR(parent)) {
>> -		dprintk("%s: get_parent of %ld failed, err %d\n",
>> -			__func__, dentry->d_inode->i_ino, PTR_ERR(parent));
>> +		dprintk("get_parent of %lu failed, err %ld\n",
>> +			dentry->d_inode->i_ino, PTR_ERR(parent));
>> 		return parent;
>> 	}
>>=20
>> @@ -147,7 +147,7 @@ static struct dentry *reconnect_one(struct vfsmount =
*mnt,
>> 	dprintk("%s: found name: %s\n", __func__, nbuf);
>> 	tmp =3D lookup_one_unlocked(mnt_user_ns(mnt), nbuf, parent, strlen(nbuf=
));
>> 	if (IS_ERR(tmp)) {
>> -		dprintk("%s: lookup failed: %d\n", __func__, PTR_ERR(tmp));
>> +		dprintk("lookup failed: %ld\n", PTR_ERR(tmp));
>> 		err =3D PTR_ERR(tmp);
>> 		goto out_err;
>> 	}
>> --=20
>> 2.35.3
>>=20
>>=20

--
Chuck Lever