Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
From:   "NeilBrown" <neilb@suse.de>
To:     "Chuck Lever III" <chuck.lever@oracle.com>
Cc:     "David Disseldorp" <ddiss@suse.de>,
        "Linux NFS Mailing List" <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] exportfs: use pr_debug for unreachable debug statements
In-reply-to: <000A2614-4C72-444A-A1D3-7B259D99C70A@oracle.com>
References: <20221021122414.20555-1-ddiss@suse.de>,
 <166656308707.12462.9861114416829680469@noble.neil.brown.name>,
 <000A2614-4C72-444A-A1D3-7B259D99C70A@oracle.com>
Date:   Tue, 25 Oct 2022 09:09:56 +1100
Message-id: <166664939677.12462.18426253960350585268@noble.neil.brown.name>
Precedence: bulk

On Tue, 25 Oct 2022, Chuck Lever III wrote:
>=20
> > On Oct 23, 2022, at 6:11 PM, NeilBrown <neilb@suse.de> wrote:
> >=20
> > On Fri, 21 Oct 2022, David Disseldorp wrote:
> >> expfs.c has a bunch of dprintk statements which are unusable due to:
> >> #define dprintk(fmt, args...) do{}while(0)
> >> Use pr_debug so that they can be enabled dynamically.
> >> Also make some minor changes to the debug statements to fix some
> >> incorrect types, and remove __func__ which can be handled by dynamic
> >> debug separately.
> >>=20
> >> Signed-off-by: David Disseldorp <ddiss@suse.de>
> >=20
> > Reviewed-by: NeilBrown <neilb@suse.de>
> >=20
> > Thanks,
> > NeilBrown
>=20
> I don't think we're the maintainers of expfs.c ?
>=20
> $ scripts/get_maintainer.pl fs/exportfs/expfs.c
> Christian Brauner <brauner@kernel.org> (commit_signer:2/2=3D100%,authored:1=
/2=3D50%,added_lines:3/6=3D50%,removed_lines:2/6=3D33%)
> Al Viro <viro@zeniv.linux.org.uk> (commit_signer:1/2=3D50%,authored:1/2=3D5=
0%,added_lines:3/6=3D50%,removed_lines:4/6=3D67%)
> Miklos Szeredi <mszeredi@redhat.com> (commit_signer:1/2=3D50%)
> Amir Goldstein <amir73il@gmail.com> (commit_signer:1/2=3D50%)
> linux-kernel@vger.kernel.org (open list)
>=20
> But maybe MAINTAINERS needs to be fixed. There's no entry
> there for fs/exportfs.

Looking at recent commits, patches come in through multiple different
trees.
nfsd certainly has an interest in expfs.c.  The only other user is
name_to_handle/open_by_handle API.
I see it as primarily nfsd functionality which is useful enough to be
exported directly to user-space.
(It was created by me when I was nfsd maintainer - does that count?)

So I would support the suggestion of updating MAINTAINERS to include
fs/exportfs/ in the NFSD section.

Having said that - given your apparent preference of tracepoints for
tracing in nfsd - I suspect you might ask for a somewhat different patch
:-)


Thanks,
NeilBrown


>=20
>=20
> >> ---
> >> fs/exportfs/expfs.c | 8 ++++----
> >> 1 file changed, 4 insertions(+), 4 deletions(-)
> >>=20
> >> diff --git a/fs/exportfs/expfs.c b/fs/exportfs/expfs.c
> >> index c648a493faf23..3204bd33e4e8a 100644
> >> --- a/fs/exportfs/expfs.c
> >> +++ b/fs/exportfs/expfs.c
> >> @@ -18,7 +18,7 @@
> >> #include <linux/sched.h>
> >> #include <linux/cred.h>
> >>=20
> >> -#define dprintk(fmt, args...) do{}while(0)
> >> +#define dprintk(fmt, args...) pr_debug(fmt, ##args)
> >>=20
> >>=20
> >> static int get_name(const struct path *path, char *name, struct dentry *=
child);
> >> @@ -132,8 +132,8 @@ static struct dentry *reconnect_one(struct vfsmount =
*mnt,
> >> 	inode_unlock(dentry->d_inode);
> >>=20
> >> 	if (IS_ERR(parent)) {
> >> -		dprintk("%s: get_parent of %ld failed, err %d\n",
> >> -			__func__, dentry->d_inode->i_ino, PTR_ERR(parent));
> >> +		dprintk("get_parent of %lu failed, err %ld\n",
> >> +			dentry->d_inode->i_ino, PTR_ERR(parent));
> >> 		return parent;
> >> 	}
> >>=20
> >> @@ -147,7 +147,7 @@ static struct dentry *reconnect_one(struct vfsmount =
*mnt,
> >> 	dprintk("%s: found name: %s\n", __func__, nbuf);
> >> 	tmp =3D lookup_one_unlocked(mnt_user_ns(mnt), nbuf, parent, strlen(nbuf=
));
> >> 	if (IS_ERR(tmp)) {
> >> -		dprintk("%s: lookup failed: %d\n", __func__, PTR_ERR(tmp));
> >> +		dprintk("lookup failed: %ld\n", PTR_ERR(tmp));
> >> 		err =3D PTR_ERR(tmp);
> >> 		goto out_err;
> >> 	}
> >> --=20
> >> 2.35.3
> >>=20
> >>=20
>=20
> --
> Chuck Lever
>=20
>=20
>=20
>=20