Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp7600804rwi; Mon, 24 Oct 2022 17:27:54 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4uE3Bcjiv0Q+uar6XCZbYcYuAqMWBzf0dN25rRLrIb+zKrBb0bITpOMLWPdaYlUsDbB/GL X-Received: by 2002:a17:906:da85:b0:741:40a7:d08d with SMTP id xh5-20020a170906da8500b0074140a7d08dmr31575371ejb.263.1666657673989; Mon, 24 Oct 2022 17:27:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666657673; cv=none; d=google.com; s=arc-20160816; b=kxQn25ofTK9w0WTrvqqnKUtq87rX95yFmc9EV/mmZfrwqz77zXF7Zs8uRR2cqC9peD iAoDADBdSexE/b2owsLuHXPDCi4KX8Z8FmcpKsqHBKLNHHhOUvTU0gAnokuSzUPeuP3B rkQNKO+SctKS/p22eVSaOAEs1xXe3Zf17w6zGwWTLjSJvOgoTObMxXk1/e5M7L/8zKXz 9pDLPE004WP5Vx8zq74FthrkC1jd3sZ651U/H1iX4ULfucXE3DWzd5ZZHcdgO/ja4K+F d/rW65QCJQZBszYRpDAO423sfbsICTyfp8VIahN4SvlqtMMfheea7igrpMpEXQmGrFnY B1kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:cc:to:from :subject; bh=CC1Yh29Lklx2iHcYmxLjSZzwyhiHcAWyDgrh9Gdj8K0=; b=utKmgdmohc2KHGYCLMRqNS/0+H1jnxiS2PexC2haUQ42aj6h+jexHszXEtTCWdKudR PceVMmNbgC1hSzd9Mj68vl1ZJupjF76Gg2hZjxYkOAoSxou7Xc2Axiw6GA4Q5aSvzC1J gFINXfo2pB6Q1DY8ACE/wAaPP3ccz53myWO4FQEf5b5OkY9t+UVWKwpWIOkZKViX2Cjs QCt6N8eDD9U7VHdICKeRlZOiswV81IbEhIncxDiUixFeB1Q/BxpRKRWK4fBSrLOWcoDq CHuWzz8Fo3l8xlt/o814JHMwpnc1go6j3UyF4rGMMUTr/cCI9pjlWTLE5SMYHZ3u56F8 YEog== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x20-20020aa7dad4000000b00461d28ac266si988393eds.579.2022.10.24.17.27.29; Mon, 24 Oct 2022 17:27:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230127AbiJYAR6 (ORCPT + 99 others); Mon, 24 Oct 2022 20:17:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229956AbiJYARn (ORCPT ); Mon, 24 Oct 2022 20:17:43 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D675CA89D for ; Mon, 24 Oct 2022 15:37:33 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C07E9615ED for ; Mon, 24 Oct 2022 22:37:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0C4D1C433D7; Mon, 24 Oct 2022 22:37:31 +0000 (UTC) Subject: [PATCH v5 06/13] NFSD: Use const pointers as parameters to fh_ helpers From: Chuck Lever To: linux-nfs@vger.kernel.org Cc: neilb@suse.de Date: Mon, 24 Oct 2022 18:37:31 -0400 Message-ID: <166665105111.50761.7942577719601324860.stgit@klimt.1015granger.net> In-Reply-To: <166664935937.50761.7812494396457965637.stgit@klimt.1015granger.net> References: <166664935937.50761.7812494396457965637.stgit@klimt.1015granger.net> User-Agent: StGit/1.5.dev3+g9561319 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Enable callers to use const pointers where they are able to. Reviewed-by: Jeff Layton Tested-by: Jeff Layton Signed-off-by: Chuck Lever --- fs/nfsd/nfsfh.h | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/fs/nfsd/nfsfh.h b/fs/nfsd/nfsfh.h index c3ae6414fc5c..513e028b0bbe 100644 --- a/fs/nfsd/nfsfh.h +++ b/fs/nfsd/nfsfh.h @@ -220,7 +220,7 @@ __be32 fh_update(struct svc_fh *); void fh_put(struct svc_fh *); static __inline__ struct svc_fh * -fh_copy(struct svc_fh *dst, struct svc_fh *src) +fh_copy(struct svc_fh *dst, const struct svc_fh *src) { WARN_ON(src->fh_dentry); @@ -229,7 +229,7 @@ fh_copy(struct svc_fh *dst, struct svc_fh *src) } static inline void -fh_copy_shallow(struct knfsd_fh *dst, struct knfsd_fh *src) +fh_copy_shallow(struct knfsd_fh *dst, const struct knfsd_fh *src) { dst->fh_size = src->fh_size; memcpy(&dst->fh_raw, &src->fh_raw, src->fh_size); @@ -243,7 +243,8 @@ fh_init(struct svc_fh *fhp, int maxsize) return fhp; } -static inline bool fh_match(struct knfsd_fh *fh1, struct knfsd_fh *fh2) +static inline bool fh_match(const struct knfsd_fh *fh1, + const struct knfsd_fh *fh2) { if (fh1->fh_size != fh2->fh_size) return false; @@ -252,7 +253,8 @@ static inline bool fh_match(struct knfsd_fh *fh1, struct knfsd_fh *fh2) return true; } -static inline bool fh_fsid_match(struct knfsd_fh *fh1, struct knfsd_fh *fh2) +static inline bool fh_fsid_match(const struct knfsd_fh *fh1, + const struct knfsd_fh *fh2) { if (fh1->fh_fsid_type != fh2->fh_fsid_type) return false;