Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Jeff Layton <jlayton@kernel.org>
CC:     Neil Brown <neilb@suse.de>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 1/2] nfsd: make "gc" parameter a bool
Thread-Topic: [PATCH 1/2] nfsd: make "gc" parameter a bool
Thread-Index: AQHY6RMoUX70ip7+kkShnP1Jo9eKHq4gp9yA
Date:   Wed, 26 Oct 2022 13:15:23 +0000
Message-ID: <EFC738D6-8728-4DAF-839A-3D4565B7BC7F@oracle.com>
References: <20221026081539.219755-1-jlayton@kernel.org>
In-Reply-To: <20221026081539.219755-1-jlayton@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?wYWo5Zrg4tTDTR4dXpz/Odl859Gb5+oPQFsNgnVyt3TLcxcsZ6dKLmmtJ0vY?=
 =?us-ascii?Q?ljmX1wTxJYUu9gvST1tNHxiBS/SKjl7jWZ34wfWieFG7q79SI6DF9bCmqHbG?=
 =?us-ascii?Q?x11BlRBuykbwY65JoWZgw9MHC9GjGGxWYLNSrM48h5RRCKIj0a38ZetmeaC2?=
 =?us-ascii?Q?dikD0odOIno7nR/9cZcVljyrwyuqmeZytb1OdQIpk0qu08c45Z0He8sfAux1?=
 =?us-ascii?Q?qSN724FV9Rz9NmvOC/Hu7FwCWoxezpOnJ58NQmMr3zyKHwUo+KOuOwCSXeaC?=
 =?us-ascii?Q?T0Or7wDfAYbVPFp7PdxS/7LiZbogV540+ND0hY+llscPBSxyHA1NoMwTlnL/?=
 =?us-ascii?Q?S4/Kra23+vTRMZA/JY7DNxj0SmlayxxSo3WLLT92OiUj1/QOIzEOdHBl3BDN?=
 =?us-ascii?Q?FP4g0CywXINQRBrw/J67h/D09lActA5oULfIk2XwcyyUELbw+C8l4H92WmM/?=
 =?us-ascii?Q?KV8HkunAQANJ/0luQtj6fHvUkN0LBoO0L7Hx5hWGEVl3UFIfKAbPmlvpSaZu?=
 =?us-ascii?Q?Op7f0cDY9QKHGKcW9uZA2nmRyfzQfOhpar2zRMwL1V+IiVuzpxdqHRL7bzyC?=
 =?us-ascii?Q?ib3fv8DoAtv5UsYLKxt3Wg0r3tanxbZ5bp2Gw9NDORHeZg/qLPjhh6tCSiiw?=
 =?us-ascii?Q?TJEKwytVA59VCTfPS1i5m7VAh+P7qwcb8yBO9g94FlXIjTcZ/fUgSDri6Gc9?=
 =?us-ascii?Q?9oCEP9jiNtGDnjfmpMG02QtSxYQRDc7IkVf68Nadzh0VlJ2JGweiQPKZhnmS?=
 =?us-ascii?Q?engB2e82HPaQsBRZVb+FZ9ObNOSBC63JL0Z48OJgX2mN52Fxcw8a2v7dkdWQ?=
 =?us-ascii?Q?WihSd551D+aALPAm71tLmFbPrE59KfXAvckBzM3hZ/lbchrSBxCZuS86xz+z?=
 =?us-ascii?Q?nNutfVQPNuBO+197emux+4Ujlhu2oqK2rTFZCxc8nnrMOyH7AIhNqR7IUnI+?=
 =?us-ascii?Q?xZhqevUyilASMMZ0Hqi3oSeVSW+lKmWyOUKaKLBHxThbCl3rsGpkyJwmf1R2?=
 =?us-ascii?Q?Cy7ZWB3IGzVMuDI643MFXaPszBi8vRjFs9xcuMRiSYy3XfkfMHPj9bDNKVWi?=
 =?us-ascii?Q?1LUdGYUk0OJgT8zfg+lN9N87hmHP8S8dX9/s2RyD2zsayWeGRyz/UyVGZaMw?=
 =?us-ascii?Q?sDIwM8P38fXvTpnc9AKtkuwZe1PE7zfPhreS5YScfucOLi0M0XoyYy9FAYTD?=
 =?us-ascii?Q?MBwnk5tDlM/9r/RnvL3Hyw6T/wFi8EOgXtz4xs+9lh8Uhk/fMWKMG3uden58?=
 =?us-ascii?Q?F+15LgkQC5wT6TLS86IHOfh3Wd0Hks1o9Dow/Sty1lJatiMkfY6gVl5EyoxG?=
 =?us-ascii?Q?oCvCPPDWOZqqLivoe+5gw9di/vjT+XBZ9DxAOpVTZ1CQdgK31HZlTEM2I0OX?=
 =?us-ascii?Q?ls4ZjgQkQc3oQ3KvTTY/sze/3OBfbvI5TxW2cJVt1l22tKBr00MczedkgRM7?=
 =?us-ascii?Q?0hHEYWT7LGrfWQCaCHOLR3E+wRj30qsax+A4xgMdvAPtqq2xHe4Ytoc0QmnV?=
 =?us-ascii?Q?nzn5swWGFri4Loq/7ZNvkXqOB0dn5GqskDr0n1FjrLG7KbiXGE0jbdUBTNtB?=
 =?us-ascii?Q?hQaUqMR88twWPVPpMpKxrK0hdP4balilO/sg+iyVDIPfDCpay3BfBcUNPq6V?=
 =?us-ascii?Q?NA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <8C126525852DD54A8A7EBB3C25239F78@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2353a594-4a8c-4dcc-8c5b-08dab7542425
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Oct 2022 13:15:23.7298
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: HFJ/F+096zJyQfYCu6LB8WgOP+kyVAug6OgXtXCNpfsASXtnWdoKarMqPUELHJ4IqMQ7nQcpj70KOzkbHxiFBw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4621
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-26_06,2022-10-26_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 phishscore=0
 spamscore=0 suspectscore=0 bulkscore=0 malwarescore=0 mlxscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2210260075
X-Proofpoint-GUID: E6yHgoHxKGuGSUIWKjDPSIkbOmx3uZMS
X-Proofpoint-ORIG-GUID: E6yHgoHxKGuGSUIWKjDPSIkbOmx3uZMS
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Oct 26, 2022, at 4:15 AM, Jeff Layton <jlayton@kernel.org> wrote:
>=20
> This gets compared to the result of test_bit which may or may not always
> exactly match what the bitfield holds. Bitfields in C can be unintuitive
> to deal with. Make it a bool instead. This doesn't change the size of
> the struct anyway.
>=20
> Signed-off-by: Jeff Layton <jlayton@kernel.org>

I've already done this in my tree, thought it was in the repo already!
Thanks for the nudge.


> ---
> fs/nfsd/filecache.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>=20
> diff --git a/fs/nfsd/filecache.c b/fs/nfsd/filecache.c
> index 106e99b24b6f..918d67cec1ad 100644
> --- a/fs/nfsd/filecache.c
> +++ b/fs/nfsd/filecache.c
> @@ -63,7 +63,7 @@ struct nfsd_file_lookup_key {
> 	struct net			*net;
> 	const struct cred		*cred;
> 	unsigned char			need;
> -	unsigned char			gc:1;
> +	bool				gc;
> 	enum nfsd_file_lookup_type	type;
> };
>=20
> @@ -1034,7 +1034,7 @@ nfsd_file_is_cached(struct inode *inode)
> static __be32
> nfsd_file_do_acquire(struct svc_rqst *rqstp, struct svc_fh *fhp,
> 		     unsigned int may_flags, struct nfsd_file **pnf,
> -		     bool open, int want_gc)
> +		     bool open, bool want_gc)
> {
> 	struct nfsd_file_lookup_key key =3D {
> 		.type	=3D NFSD_FILE_KEY_FULL,
> @@ -1161,7 +1161,7 @@ __be32
> nfsd_file_acquire_gc(struct svc_rqst *rqstp, struct svc_fh *fhp,
> 		     unsigned int may_flags, struct nfsd_file **pnf)
> {
> -	return nfsd_file_do_acquire(rqstp, fhp, may_flags, pnf, true, 1);
> +	return nfsd_file_do_acquire(rqstp, fhp, may_flags, pnf, true, true);
> }
>=20
> /**
> @@ -1182,7 +1182,7 @@ __be32
> nfsd_file_acquire(struct svc_rqst *rqstp, struct svc_fh *fhp,
> 		  unsigned int may_flags, struct nfsd_file **pnf)
> {
> -	return nfsd_file_do_acquire(rqstp, fhp, may_flags, pnf, true, 0);
> +	return nfsd_file_do_acquire(rqstp, fhp, may_flags, pnf, true, false);
> }
>=20
> /**
> --=20
> 2.37.3
>=20

--
Chuck Lever