Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Ondrej Valousek <ondrej.valousek.xm@renesas.com>
CC:     Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 1/1] nfs: Move ACL xattr definitions to linux/xattr.h
Thread-Topic: [PATCH 1/1] nfs: Move ACL xattr definitions to linux/xattr.h
Thread-Index: AdjpFseyCVMG/398TgCgX5c43WmIgQAKE74A
Date:   Wed, 26 Oct 2022 13:30:29 +0000
Message-ID: <7C212DCA-6031-4E8D-A64B-7969EA4A40F7@oracle.com>
References: <TYXPR01MB18543A8B371E885CC9AA497CD9309@TYXPR01MB1854.jpnprd01.prod.outlook.com>
In-Reply-To: <TYXPR01MB18543A8B371E885CC9AA497CD9309@TYXPR01MB1854.jpnprd01.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?iQM7J0M+sWWcyoeYZ6P87O926HY2D3iXOmpRHpfnazLRNvKOYwoczhcP4DON?=
 =?us-ascii?Q?+xuaJ2HIIcL2FKaXyPYjWn5hZU6DevHXKCfoLI5ayRBMZCVEVFlLAnsSMzvS?=
 =?us-ascii?Q?Q8/ghVtUn/chAWADc7OgR6i3JV8o+uHJIhhOJ6Zt6DvYfRq/SIfcX6kLbgio?=
 =?us-ascii?Q?8bEWZjR1Hf2L/jc0AYAravKrRMc89nGlft7ls508tM2NCEMXK3KD/4gtDnJX?=
 =?us-ascii?Q?bFL3wMSYGUqiYfd8fBqdnwGEudMO7yPX0nbjjSsY9aKyh80jNwMjn+44H09R?=
 =?us-ascii?Q?3+p4FqhxqvyhaqWoPylUJF5J4VYAWpXEz8F2G8bOC4ZkyA3i5h3qOPIvKWFD?=
 =?us-ascii?Q?2FFqO8rMSAABPEit3ZbggGEmkUa1ts2LFojFHOHS5EUYHUwAgp0KMV720ZY8?=
 =?us-ascii?Q?4fkIBBJ2Yo1616sCjC6JFTR26v58czs/1the39jb5NoIOUf+8kmMZwgFEIcg?=
 =?us-ascii?Q?pPO8biaXnFs2AGgzURXQmOVJRWpdITgQBZZIWnvoZiFqR/WlaZEc7S7cIAaB?=
 =?us-ascii?Q?i36yi/l6YTBBxrCqbM7K9zHwYdUDZFp0s9qRs9FeO01qcGUf35IA7UOkue/1?=
 =?us-ascii?Q?MJ8cP14Fq+f7Z9Y369AaQjvBbanajyzujmntfe4+pK/cq39znPU3eOfQkaBj?=
 =?us-ascii?Q?6THFuYm2fZbcYldGG1s+KAsvDah2/DUK5G/r1olRZ3YXAa+GO0Ew8VDX/wyb?=
 =?us-ascii?Q?hH60OPftsrmsDqmr+LYUC9C3aEE+AvjxH3hveCX/1dPhFelSPzf9FQJSPR3E?=
 =?us-ascii?Q?bXBa2nMdtENFonXoeKi4KIBBviFSGVRv8ymw+eEjDrgV2fxACNhESPquG2pe?=
 =?us-ascii?Q?mLHds3W566UlNk0v9jR/BnCKlSLdD5E1+qcD7kEz0Andi+bh4HSv8qefUm8F?=
 =?us-ascii?Q?qymmu737DflDSJ3W1L4URB4DHL4d8AjyDTw3oUuc8X+LxYHeeLFQLJItfeeR?=
 =?us-ascii?Q?H5A5ikN/zk57Lxv2o8W/OYNyj7SN0IHK79i3Vh4WipT+kWsyvo1ObIOiOfm4?=
 =?us-ascii?Q?Nhs/aJFSFoo1dd9XLvnWw0rAaPM4BdGoxEElqLqoNfrYwR3DiKiy/ZNjFHY3?=
 =?us-ascii?Q?p50GnlF0NdDfWc5hLb+jaznK/x+KwpaD9FZTUZ3ld5LmNvqa29D+Ox+WVnRr?=
 =?us-ascii?Q?b2H+YgG9FXqiNBsLNaqxzoulatnQ1UZnIwRin+seSsMtXf+00YYBvLvzPbNi?=
 =?us-ascii?Q?bwtCl5EkOFE3qDS1IrWxEATe0Am5VeW4WXRz8fr8dVoQ5yPJpHIegtIGaVET?=
 =?us-ascii?Q?6VeYcUiwqFF/iaVDyuHk9+GhgasqrQVd9ONrGayAovISqChfHLM83NXEVQFg?=
 =?us-ascii?Q?SWlfQQlbCf6Yw6V/Ak2azhOWCQGExqBVe1kfqmG34W2Ofafv4MaXgQyW6n6g?=
 =?us-ascii?Q?LvWTdgri8Y+TdjuITifEKs2ylh6bV6LfN5QdEDh5ulHT7MCq5TfdjDVhLInP?=
 =?us-ascii?Q?xnkyTWK40KRzcOs9Da6Y5DvB/c+B1p6MRIXZDQ5bFm6f30uKV8hhsQwdUsAG?=
 =?us-ascii?Q?rQTcdcxlmZEeeiQBUsDC2eohUZl5QnMvioUw256Bw5kT2KueoQtoxaV8SKF6?=
 =?us-ascii?Q?pxgezmU51zTIvx5OFBzRWngkwhSJcSN+Po63WWlcfAAHJwr5kbSZ/HdrW94E?=
 =?us-ascii?Q?6w=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <0EC82816D762EF41BA171C3685C4FC53@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c659c827-f48f-450f-d051-08dab7564036
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Oct 2022 13:30:29.8594
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: MGT8pPv53wd/JFkXqC3yuN419jbrK/upFv8CmceBpqE6pfG192Df76wR9e1F+0ot+wd+PyztOgaL8xyFkxuN2g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB6496
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-26_06,2022-10-26_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxscore=0 phishscore=0
 mlxlogscore=999 adultscore=0 malwarescore=0 spamscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000
 definitions=main-2210260076
X-Proofpoint-ORIG-GUID: tYiB0DzwBa5Cu7bNwkULYTysWTTCkvmj
X-Proofpoint-GUID: tYiB0DzwBa5Cu7bNwkULYTysWTTCkvmj
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Oct 26, 2022, at 4:48 AM, Ondrej Valousek <ondrej.valousek.xm@renesas.=
com> wrote:
>=20
> Hi kernel maintainers,
>=20
> Please help to submit the following patch into kernel
> ---
> Signed-off-by: Ondrej Valousek <ondrej.valousek.xm@renesas.com>
> Short description:
>=20
> The XATTR_NAME_NFSV4_ACL definition is also useful for userspace (i.e. nf=
s4_acl_tools/libacl/coreutils) so makes a sense to move the definition to t=
he linux/xattr.h

Hey Ondrej!

Let's start by copying the correct maintainers for these files
so the patch gets proper review:

$ scripts/get_maintainer.pl include/uapi/linux/xattr.h
linux-kernel@vger.kernel.org (open list)
$ scripts/get_maintainer.pl fs/nfs/nfs4proc.c
Trond Myklebust <trond.myklebust@hammerspace.com> (maintainer:NFS, SUNRPC, =
AND LOCKD CLIENTS)
Anna Schumaker <anna@kernel.org> (maintainer:NFS, SUNRPC, AND LOCKD CLIENTS=
)
linux-nfs@vger.kernel.org (open list:NFS, SUNRPC, AND LOCKD CLIENTS)
linux-kernel@vger.kernel.org (open list)
$

Can you update the To/Cc and repost?


> diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
> index e2efcd26336c..07c3d8572912 100644
> --- a/fs/nfs/nfs4proc.c
> +++ b/fs/nfs/nfs4proc.c
> @@ -7680,8 +7680,6 @@ nfs4_release_lockowner(struct nfs_server *server, s=
truct nfs4_lock_state *lsp)
>        rpc_call_async(server->client, &msg, 0, &nfs4_release_lockowner_op=
s, data);
> }
>=20
> -#define XATTR_NAME_NFSV4_ACL "system.nfs4_acl"
> -
> static int nfs4_xattr_set_nfs4_acl(const struct xattr_handler *handler,
>                                   struct user_namespace *mnt_userns,
>                                   struct dentry *unused, struct inode *in=
ode,
> diff --git a/include/uapi/linux/xattr.h b/include/uapi/linux/xattr.h
> index 9463db2dfa9d..77eb8c885861 100644
> --- a/include/uapi/linux/xattr.h
> +++ b/include/uapi/linux/xattr.h
> @@ -81,5 +81,7 @@
> #define XATTR_POSIX_ACL_DEFAULT  "posix_acl_default"
> #define XATTR_NAME_POSIX_ACL_DEFAULT XATTR_SYSTEM_PREFIX XATTR_POSIX_ACL_=
DEFAULT
>=20
> +#define XATTR_NFSV4_ACL "nfs4_acl"
> +#define XATTR_NAME_NFSV4_ACL XATTR_SYSTEM_PREFIX XATTR_NFSV4_ACL
>=20
> #endif /* _UAPI_LINUX_XATTR_H */

--
Chuck Lever