Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp662901rwi; Thu, 27 Oct 2022 06:15:52 -0700 (PDT) X-Google-Smtp-Source: AMsMyM59Jyh+PcpTBOG9BN+lTFmqUONdr95917x8crWXQZEtXZh9uv4R1cwnXoBzQMZANMbfpxhN X-Received: by 2002:a05:6402:51c9:b0:45d:5efe:d1a3 with SMTP id r9-20020a05640251c900b0045d5efed1a3mr45682652edd.58.1666876552472; Thu, 27 Oct 2022 06:15:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666876552; cv=none; d=google.com; s=arc-20160816; b=NXdiRj1ijKDsQokguC+rBlpgPwttrZG4+b/pifdVHq5WKwSuE3Zor2FwB2f8F2LOqP iWL5pv4XagY21+ezt8s1EvRrcEvb88AiOyCYy5SG4QXw71NmGqfrXYj0KZ1FeMxG2dQo A+L/YLPAqoxLvwRg/lhqBNZIA6asViGc+U1CaIDEMcnhNBxbSEbph+q7xPbe5+X6XzOw dzG4Df1pb4uq3e38ZAn6GyXQLaj5RgqBC/An0IZGqAgNqZmOl4Ht/taajsN6mavm//Pu BXxwaxtD9UjChnS57RMtldo100J74aqYWnm26XHdurAlwfO0znNo/6XugvSLRigsY3oJ edvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:content-id:mime-version:subject :cc:to:references:in-reply-to:from:organization:dkim-signature; bh=h3esAL34hsd7fi8HYNIYP56t4S/yycCKV0wPq2bO/WI=; b=Obo3tdCt7r+KL53E7bdShDQXNaLkPkC477ylaBGfrpfRUoa2ZnzKXZsUhkw0bvhPXP BCQxup4miF6KiTINT9SJlVRXn/VHsMzn7XBs60McdoPieI7TDZL0y9tQ/i0UqdPH48I6 J9Ulh2R/lEnpKrzZhVcO5AB/YgSrskKk+DGJVLKh/RPT11lfAiFG0ibA6auhnRDEwhKV 9FWbtBCP/joh4OPtp6hGHNBsc7REa0slTU3VkgDsuioLdW6+xNaRVm0MUXiKOB1rVL+C nCvwmBkc1xbaNhB4fo0lgBoetRaTVAAKxYrqxNLS1eXu92YZKd8PDCT/A2hzmHlybYwG XRAA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Knxptaue; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l6-20020a056402254600b00459563e2c60si1862154edb.329.2022.10.27.06.15.22; Thu, 27 Oct 2022 06:15:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Knxptaue; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235011AbiJ0NGc (ORCPT + 99 others); Thu, 27 Oct 2022 09:06:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57864 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235624AbiJ0NGa (ORCPT ); Thu, 27 Oct 2022 09:06:30 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A0EB5A3CB for ; Thu, 27 Oct 2022 06:06:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666875987; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=h3esAL34hsd7fi8HYNIYP56t4S/yycCKV0wPq2bO/WI=; b=KnxptaueTQCedCBDQdcftFR0OfJgUSCKP6KQi9UQfoaWwNjt6dTDn5g7pOaiHnM9upGSbw yz1i8QRaCSI8TVW0014MULgiEiqv+n/n83d1L+3WKnIo/UIH+X194ITveyJZ9ZRVX3Zg9w 5Ig/N772j3dRycKzqJ75lqQTIbTgqXc= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-673-AEZKjTL8P1mUcLgflbbgGQ-1; Thu, 27 Oct 2022 09:06:22 -0400 X-MC-Unique: AEZKjTL8P1mUcLgflbbgGQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A6D95800B30; Thu, 27 Oct 2022 13:06:20 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.73]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7A9D32024CB7; Thu, 27 Oct 2022 13:06:19 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20221027083547.46933-9-jefflexu@linux.alibaba.com> References: <20221027083547.46933-9-jefflexu@linux.alibaba.com> <20221027083547.46933-1-jefflexu@linux.alibaba.com> To: Jingbo Xu Cc: dhowells@redhat.com, jlayton@kernel.org, linux-cachefs@redhat.com, linux-erofs@lists.ozlabs.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-afs@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 8/9] fscache,netfs: move PageFsCache() family helpers to fscache.h MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3306288.1666875978.1@warthog.procyon.org.uk> Date: Thu, 27 Oct 2022 14:06:18 +0100 Message-ID: <3306289.1666875978@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Jingbo Xu wrote: > Besides, it's also quite reasonable to move these helpers to fscache.h > given their names. They're going to go away. Please don't use them at all unless you must. Just leave them where they are. David